aws: enable PCI write-combine for arm64

Bug #1893817 reported by Kamal Mostafa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-aws (Ubuntu)
High
Kamal Mostafa
Bionic
High
Kamal Mostafa
Focal
High
Kamal Mostafa
Groovy
High
Kamal Mostafa

Bug Description

To improve PCI performance on certain arm64 AWS instance types, enable arch_can_pci_mmap_wc() via the patch:

    From: Clint Sbisa <email address hidden>
    Subject: [PATCH] arm64: Enable PCI write-combine resources under sysfs

    https://<email address hidden>/

--------------

[Impact]

 * AWS requires PCI-write-combine be enabled for arm64 via this one-line patch, to effect a significant performance improvement on certain AWS arm64 instance types.

 * After considerable discussion, upstream indicates that this patch will be accepted into mainline[0] once additional documentation details get added to the commit description.

 * Applying this patch to linux-aws affects only AWS arm64 instance types.

[Test Case]

 * Has been performance-tested by AWS; smoke-tested by me.

[Regression Potential]

 * Low.

[0] https://<email address hidden>/

Changed in linux-aws (Ubuntu Bionic):
status: New → In Progress
Changed in linux-aws (Ubuntu Focal):
status: New → In Progress
Changed in linux-aws (Ubuntu Bionic):
assignee: nobody → Kamal Mostafa (kamalmostafa)
Changed in linux-aws (Ubuntu Focal):
assignee: nobody → Kamal Mostafa (kamalmostafa)
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :
Stefan Bader (smb)
Changed in linux-aws (Ubuntu Bionic):
importance: Undecided → Low
Changed in linux-aws (Ubuntu Focal):
importance: Undecided → Low
Changed in linux-aws (Ubuntu Groovy):
importance: Undecided → Low
Changed in linux-aws (Ubuntu Bionic):
importance: Low → Medium
Changed in linux-aws (Ubuntu Focal):
importance: Low → Medium
Changed in linux-aws (Ubuntu Groovy):
importance: Low → Medium
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Application of this will be deferred pending resolution of upstream discussion.

Changed in linux-aws (Ubuntu Bionic):
status: In Progress → Won't Fix
Changed in linux-aws (Ubuntu Focal):
status: In Progress → Won't Fix
Changed in linux-aws (Ubuntu Groovy):
status: In Progress → Won't Fix
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Upstream resolution: https://<email address hidden>/

TL;dr "If that's the case we can go ahead and merge this patch with a reworded commit log [...] Clint, please reword the commit and resend, not sure we can hit v5.10 but we shall try."

description: updated
Changed in linux-aws (Ubuntu):
importance: Medium → High
Changed in linux-aws (Ubuntu Bionic):
importance: Medium → High
Changed in linux-aws (Ubuntu Groovy):
importance: Medium → High
Changed in linux-aws (Ubuntu Focal):
importance: Medium → High
Changed in linux-aws (Ubuntu Bionic):
status: Won't Fix → In Progress
Changed in linux-aws (Ubuntu Focal):
status: Won't Fix → In Progress
Changed in linux-aws (Ubuntu Groovy):
status: Won't Fix → In Progress
Ian May (ian-may)
Changed in linux-aws (Ubuntu Focal):
status: In Progress → Fix Committed
Ian May (ian-may)
Changed in linux-aws (Ubuntu Bionic):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (10.4 KiB)

This bug was fixed in the package linux-aws - 5.8.0-1008.8

---------------
linux-aws (5.8.0-1008.8) groovy; urgency=medium

  * groovy/linux-aws: 5.8.0-1008.8 -proposed tracker (LP: #1899092)

  * aws: enable PCI write-combine for arm64 (LP: #1893817)
    - SAUCE: arm64: Enable PCI write-combine resources under sysfs

  * Miscellaneous Ubuntu changes
    - CONFIG_UBUNTU_HOST=m
    - [Packaging] [aws] remove python3-venv dependency

  [ Ubuntu: 5.8.0-22.23 ]

  * groovy/linux: 5.8.0-22.23 -proposed tracker (LP: #1899099)
  * Packaging resync (LP: #1786013)
    - update dkms package versions
  * oops in nvkm_udevice_info() [nouveau] (LP: #1898130)
    - drm/nouveau/device: return error for unknown chipsets
  * python3-venv is gone (LP: #1896801)
    - SAUCE: doc: remove python3-venv dependency
  * *-tools-common packages descriptions have typo "PGKVER" (LP: #1898903)
    - [Packaging] Fix typo in -tools template s/PGKVER/PKGVER/
  * Enable brightness control on HP DreamColor panel (LP: #1898865)
    - SAUCE: drm/i915/dpcd_bl: Skip testing control capability with force DPCD
      quirk
    - SAUCE: drm/dp: HP DreamColor panel brigntness fix
  * Groovy update: v5.8.14 upstream stable release (LP: #1898853)
    - io_uring: always delete double poll wait entry on match
    - btrfs: fix filesystem corruption after a device replace
    - mmc: sdhci: Workaround broken command queuing on Intel GLK based IRBIS
      models
    - USB: gadget: f_ncm: Fix NDP16 datagram validation
    - Revert "usbip: Implement a match function to fix usbip"
    - usbcore/driver: Fix specific driver selection
    - usbcore/driver: Fix incorrect downcast
    - usbcore/driver: Accommodate usbip
    - gpio: siox: explicitly support only threaded irqs
    - gpio: mockup: fix resource leak in error path
    - gpio: tc35894: fix up tc35894 interrupt configuration
    - gpio: amd-fch: correct logic of GPIO_LINE_DIRECTION
    - clk: samsung: Keep top BPLL mux on Exynos542x enabled
    - clk: socfpga: stratix10: fix the divider for the emac_ptp_free_clk
    - scsi: iscsi: iscsi_tcp: Avoid holding spinlock while calling getpeername()
    - i2c: i801: Exclude device from suspend direct complete optimization
    - Input: i8042 - add nopnp quirk for Acer Aspire 5 A515
    - iio: adc: qcom-spmi-adc5: fix driver name
    - ftrace: Move RCU is watching check after recursion check
    - tracing: Fix trace_find_next_entry() accounting of temp buffer size
    - memstick: Skip allocating card when removing host
    - drm/amdgpu: restore proper ref count in amdgpu_display_crtc_set_config
    - xen/events: don't use chip_data for legacy IRQs
    - clocksource/drivers/timer-gx6605s: Fixup counter reload
    - vboxsf: Fix the check for the old binary mount-arguments struct
    - mt76: mt7915: use ieee80211_free_txskb to free tx skbs
    - libbpf: Remove arch-specific include path in Makefile
    - drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices
    - Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"
    - drm/sun4i: mixer: Extend regmap max_register
    - hv_netvsc: Cache the current data path to avoid duplicate call and message
    - net: dec: de2104x: Increase receive...

Changed in linux-aws (Ubuntu Groovy):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-aws - 4.15.0-1087.92

---------------
linux-aws (4.15.0-1087.92) bionic; urgency=medium

  * bionic/linux-aws: 4.15.0-1087.92 -proposed tracker (LP: #1900674)

  * CVE-2020-12351 // CVE-2020-12352 // CVE-2020-24490
    - [Config] aws: Disable BlueZ highspeed support

  * EFA: add support for 0xefa1 devices (LP: #1896791)
    - RDMA/efa: Expose maximum TX doorbell batch
    - RDMA/efa: Expose minimum SQ size
    - RDMA/efa: User/kernel compatibility handshake mechanism
    - RDMA/efa: Add EFA 0xefa1 PCI ID

  * aws: enable PCI write-combine for arm64 (LP: #1893817)
    - SAUCE: arm64: Enable PCI write-combine resources under sysfs

  [ Ubuntu: 4.15.0-122.124 ]

  * bionic/linux: 4.15.0-122.124 -proposed tracker (LP: #1899941)
  * CVE-2020-12351 // CVE-2020-12352 // CVE-2020-24490
    - Bluetooth: Disable High Speed by default
    - Bluetooth: MGMT: Fix not checking if BT_HS is enabled
    - [Config] Disable BlueZ highspeed support
  * CVE-2020-12351
    - Bluetooth: L2CAP: Fix calling sk_filter on non-socket based channel
  * CVE-2020-12352
    - Bluetooth: A2MP: Fix not initializing all members

 -- Stefan Bader <email address hidden> Tue, 20 Oct 2020 12:01:06 +0200

Changed in linux-aws (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-aws - 5.4.0-1029.30

---------------
linux-aws (5.4.0-1029.30) focal; urgency=medium

  * focal/linux-aws: 5.4.0-1029.30 -proposed tracker (LP: #1900671)

  * CVE-2020-12351 // CVE-2020-12352 // CVE-2020-24490
    - [Config] [aws] Disable BlueZ highspeed support

  * EFA: add support for 0xefa1 devices (LP: #1896791)
    - RDMA/efa: Expose maximum TX doorbell batch
    - RDMA/efa: Expose minimum SQ size
    - RDMA/efa: User/kernel compatibility handshake mechanism
    - RDMA/efa: Add EFA 0xefa1 PCI ID

  * aws: enable PCI write-combine for arm64 (LP: #1893817)
    - SAUCE: arm64: Enable PCI write-combine resources under sysfs

  * AWS: enable FPGA support in amd64 AWS kernels (LP: #1898781)
    - [Config] aws: enable FPGA for amd64 also

  [ Ubuntu: 5.4.0-52.57 ]

  * focal/linux: 5.4.0-52.57 -proposed tracker (LP: #1899920)
  * CVE-2020-12351 // CVE-2020-12352 // CVE-2020-24490
    - Bluetooth: Disable High Speed by default
    - Bluetooth: MGMT: Fix not checking if BT_HS is enabled
    - [Config] Disable BlueZ highspeed support
  * CVE-2020-12351
    - Bluetooth: L2CAP: Fix calling sk_filter on non-socket based channel
  * CVE-2020-12352
    - Bluetooth: A2MP: Fix not initializing all members

 -- Andrea Righi <email address hidden> Tue, 20 Oct 2020 11:32:33 +0200

Changed in linux-aws (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers