lighttpd init file should not chown or chmod on status check

[Joseph Piché]

Binary package hint: lighttpd

The lighttpd init file performs `chmod` and `chown` on the PID file every time it's run. This should only be done under certain actions of the init file as it is not necessary for the "status" action.

$ lsb_release -rd
Description: Ubuntu 9.04
Release: 9.04

[Daniel Hahler (blueyed)]

I cannot confirm this.

Are you referring to the following snippet?

# be sure there is a /var/run/lighttpd, even with tmpfs
mkdir -p /var/run/lighttpd > /dev/null 2> /dev/null
chown www-data:www-data /var/run/lighttpd
chmod 0750 /var/run/lighttpd

[Joseph Piché (josephpiche)]

I believe that is the offending code. Now that I think about it I should have titled this bug differently. The issue I saw was `/etc/init.d/lighttpd status` cannot be run as a non-root user. When I looked into why it couldn't be run, I saw that quoted code. Plus, shouldn't the user and group be pulled from a config file? Please let me know if I am missing something. Thanks.

[Joseph Piché (josephpiche)]

I believe this is related to bug 424991 in that `/etc/init.d/lighttpd` assumes directory locations and 109559 and permissions when this should be pulled from a config file like `/etc/default/lighttpd` or something.

I'm not familiar enough with with bash scripting to know what to do to fix this, otherwise I would write a patch. Could someone else please either confirm or deny that this is a bug?

[Joseph Piché (josephpiche)]

Sorry, I meant bug 109559--I had the wrong one in my clipboard.

[gstrauss (gstrauss)]

Fixed in lighttpd tag debian/1.4.26-2

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538662
https://salsa.debian.org/debian/lighttpd/-/commit/e2be4e91169135b92c22eace7ef01a55701d46f0
https://salsa.debian.org/debian/lighttpd/-/commit/b674a409fa3253e08e59fdcc8781eb700a6409dc