Comment 5 for bug 326899

Revision history for this message
Morten Kjeldgaard (mok0) wrote :

Hi Andreas,

I sponsored your lighttpd patch into karmic. IMHO it is definitely a packaging error not to include a -dev package. However, I had to change a few things in your patches. I see from the debbug that you are asking for feedback, so here it is (public so others can benefit):

It is not correct to patch the Makefile.in's like you have done. You have correctly patched configure.in and Makefile.am, but then you need to rerun the autotools (libtool, aclocal, autoconf, autoheader, automake) to regenerate configure and the Makefiles. This has to be done before running configure, and it's a bit inconvenient with CDBS that this package uses. But it can be done with some variables.

It can be debated if it's a bit overkill to invoke the autotools system just to produce the lighttpd.pc file with the proper values set. Another way would be to put the .pc file in debian and just copy it to the destination using the .install file. Much simpler and merges better, but of course you need to hardwire the version number and remember to update it.

Cheers, & thx for your work!