[enhancement] Please move /tmp/mir_socket to /run/mir_socket (or similar)
Bug #1322300 reported by
Jamie Strandboge
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Light Display Manager |
Fix Released
|
Medium
|
Unassigned | ||
lightdm (Ubuntu) |
Fix Released
|
High
|
Chris Halse Rogers |
Bug Description
/tmp/mir_socket is created by unity-system-
# stop lightdm ; touch /tmp/mir_socket ; start lightdm
lightdm fails to start. It would be better if /run/mir_socket (or some other root-owned directory) were used.
Related branches
lp:~raof/lightdm/run-is-the-new-tmp
- Robert Ancell: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 329 lines (+26/-26)25 files modifiedsrc/seat-xlocal.c (+1/-1)
src/unity-system-compositor.c (+1/-1)
tests/scripts/mir-autologin.conf (+1/-1)
tests/scripts/mir-greeter.conf (+1/-1)
tests/scripts/mir-session-compositor-crash.conf (+1/-1)
tests/scripts/mir-session-crash.conf (+1/-1)
tests/scripts/mir-session.conf (+1/-1)
tests/scripts/unity-autologin.conf (+1/-1)
tests/scripts/unity-compositor-command.conf (+1/-1)
tests/scripts/unity-compositor-crash.conf (+1/-1)
tests/scripts/unity-compositor-fail-ready.conf (+1/-1)
tests/scripts/unity-compositor-fail-start.conf (+1/-1)
tests/scripts/unity-compositor-fallback.conf (+2/-2)
tests/scripts/unity-compositor-mir-next-session.conf (+1/-1)
tests/scripts/unity-compositor-next-session.conf (+1/-1)
tests/scripts/unity-login.conf (+1/-1)
tests/scripts/unity-mir-autologin.conf (+1/-1)
tests/scripts/unity-mir-greeter-mir-session.conf (+1/-1)
tests/scripts/unity-mir-greeter-x-session.conf (+1/-1)
tests/scripts/unity-mir-lock-seat.conf (+1/-1)
tests/scripts/unity-mir-session-x-greeter.conf (+1/-1)
tests/scripts/unity-mir-switch-to-user-resettable.conf (+1/-1)
tests/scripts/unity-plymouth.conf (+1/-1)
tests/scripts/unity-switch.conf (+1/-1)
tests/scripts/unity-xdg-seat.conf (+1/-1)
Changed in mir: | |
status: | New → Opinion |
Changed in unity-system-compositor (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in mir: | |
milestone: | none → 0.2.0 |
Changed in unity-system-compositor (Ubuntu): | |
milestone: | none → ubuntu-14.05 |
tags: | added: enhancement |
summary: |
- Please move /tmp/mir_socket to /run/mir_socket (or similar) + [enhancement] Please move /tmp/mir_socket to /run/mir_socket (or + similar) |
Changed in mir: | |
importance: | Undecided → High |
Changed in mir: | |
assignee: | nobody → Chris Halse Rogers (raof) |
Changed in unity-system-compositor (Ubuntu): | |
assignee: | nobody → Chris Halse Rogers (raof) |
Changed in lightdm (Ubuntu): | |
importance: | Undecided → High |
no longer affects: | mir |
Changed in lightdm: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in lightdm: | |
milestone: | none → 1.11.3 |
Changed in lightdm: | |
status: | Triaged → Fix Committed |
Changed in lightdm: | |
status: | Fix Committed → Fix Released |
Changed in lightdm (Ubuntu): | |
status: | Triaged → Fix Released |
To post a comment you must log in.
An exposed endpoint allowing "anyone" to connect to the system compositor is a bad idea wherever it.
It has been the plan for the system compositor not to create an endpoint on the filesystem and instead to pass a connection FD to the session compositors and clients. (Although we could specify a file to create on the command-line for debugging purposes.)
I think Robert Ansell started work on the system compositor code to pass the FD via dbus.
Surely not creating the FD at all is a better fix than just moving the fallback location? (/tmp is only used if =$XDG_RUNTIME_DIR is not set)
Notes:
A suitable FD can be created using connector- >client_ socket_ fd() - there's been an an example in <mir>/examples/ basic_server_ configuration. cpp for over a year.
We are also using this approach with "trust sessions" (to allocate sockets before launching new participants in the trust session).