lightdm overrides dh_installinit in debian/rules and shouldn't

[Steve Langasek]

The debian/rules for lightdm includes the following:

override_dh_installinit:
        dh_installinit --no-start

This appears to have been in place since the beginning of the package's history, with no reason given. And the result of this override is that if you install lightdm on a running system, lightdm will not be automatically started at install time like it should be.

Please drop this override from the package.

[Sebastien Bacher (seb128)]

that override is there to avoid having lightdm restarting on upgrade, which would have as an effect to restart user sessions...

[Steve Langasek (vorlon)]

On Sun, Mar 16, 2014 at 10:26:41AM -0000, Sebastien Bacher wrote:
> that override is there to avoid having lightdm restarting on upgrade,
> which would have as an effect to restart user sessions...

That's not the right way to avoid restarting. If you need to avoid
restarts, there's a separate '-r' option to dh_installinit.

[Sebastien Bacher (seb128)]

Robert, was I right assuming the reason for the override? If so it seems like using -r would be right. Note that gdm has the same issue

[Robert Ancell (robert-ancell)]

If GDM has the same issue then it's probably just a copy-paste error. I'm happy with whatever you guys think is appropriate.

[Launchpad Janitor (janitor)]

This bug was fixed in the package lightdm - 1.19.0-0ubuntu1

---------------
lightdm (1.19.0-0ubuntu1) yakkety; urgency=medium

  * New upstream release:
    - Use /dev/tty0 instead of /dev/console for VT operations (LP: #1566073)
    - Don't quit on SIGUSR1, SIGUSR2 or SIGHUP (LP: #960157)
    - Improve XDMCP IPv6 address selection (LP: #1575200)
    - Set XDMCP hostname field in to system hostname or configured value
      (LP: #1578442)
    - Allow fcitx and mozc to run in guest session (LP: #1509829)
    - Fix lxsession running in guest session
    - Drop support for legacy XMir
    - Fix g_spawn compiler warning
  * debian/rules:
    - Fix usage of dh_installinit (LP: #1292990)

 -- Robert Ancell <email address hidden> Thu, 05 May 2016 12:23:45 +1200

[Martin Pitt (pitti)]

> lightdm will not be automatically started at install time like it should be

I disagree that a display manager should start at install time. It's potentially too disruptive and as we've seen you might still need to configure it first before it actually works. (Like in bug 1581106).

[Robert Ancell (robert-ancell)]

Based on Martins issue I've reverted this change and added a comment.