root user displayed on greeter screen

Bug #1248541 reported by Marc Deslauriers
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Light Display Manager
Fix Released
Medium
Robert Ancell
1.8
Fix Released
Medium
Robert Ancell
1.9
Fix Released
Medium
Robert Ancell
lightdm (Ubuntu)
Fix Released
Low
Robert Ancell
Saucy
Fix Released
Low
Robert Ancell
Trusty
Fix Released
Low
Robert Ancell

Bug Description

Reproduced on 1.8.2 and 1.8.4:

If you open an ssh session as the root user, it gets displayed in the greeter.

Steps to reproduce:

1- Log in as a regular user
2- Set up ssh key auth for root user
3- ssh into machine as root user
4- Log out as regular user
5- Notice "root" account being displayed in greeter

Related branches

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Marc, could you check if that's fixed in trusty or with the version waiting in the saucy SRU queue? That seems similar to bug #1242939

Changed in lightdm (Ubuntu):
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

The lightdm version in the saucy SRU queue is the one I just pushed out as a security update, and it definitely is affected.

I can also reproduce this with 1.9.2-0ubuntu1 in trusty.

Changed in lightdm (Ubuntu Trusty):
status: Incomplete → Confirmed
Changed in lightdm (Ubuntu Saucy):
status: New → Confirmed
importance: Undecided → Low
Changed in lightdm:
status: New → In Progress
assignee: nobody → Robert Ancell (robert-ancell)
importance: Undecided → Medium
assignee: Robert Ancell (robert-ancell) → nobody
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Found the problem - while AccountsService doesn't return system users when calling ListCachedUsers() it does generate the UserAdded signal when a system user is created (e.g. by calling FindUserByName()). The greeter then picks up this new user and doesn't check if it's a system user.

I think this is the actual cause of the LightDM user showing up - the daemon gets this user via FindUserByName and if there happens to be a greeter open at this time (probably racy) then the greeter will show the user.

lp:~robert-ancell/lightdm/system-user fixes this by ignoring system users when generating the user list for the greeter.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:lightdm at revision None, scheduled for release in lightdm, milestone Unknown

Changed in lightdm:
status: In Progress → Fix Committed
Changed in lightdm:
assignee: nobody → Robert Ancell (robert-ancell)
Changed in lightdm (Ubuntu Trusty):
status: Confirmed → In Progress
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 1.9.3-0ubuntu1

---------------
lightdm (1.9.3-0ubuntu1) trusty; urgency=low

  * New upstream release:
    - Don't pass system user accounts from AccountsService to greeters.
      (LP: #1248541)
    - Fix crash if switching to greeter and it isn't installed. (LP: #1246529)
 -- Robert Ancell <email address hidden> Thu, 07 Nov 2013 15:07:34 +1300

Changed in lightdm (Ubuntu Trusty):
status: In Progress → Fix Released
Changed in lightdm (Ubuntu Saucy):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in lightdm:
status: Fix Committed → Fix Released
Changed in lightdm (Ubuntu Saucy):
status: Confirmed → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Marc, or anyone else affected,

Accepted lightdm into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lightdm/1.8.5-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lightdm (Ubuntu Saucy):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote : [lightdm/saucy] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for saucy for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

I have successfully tested the package in saucy-proposed, and it works as intended and solves the issue.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 1.8.5-0ubuntu1

---------------
lightdm (1.8.5-0ubuntu1) saucy; urgency=low

  * New upstream release:
    - Don't pass system user accounts from AccountsService to greeters.
      (LP: #1248541)
    - Fix crash if switching to greeter and it isn't installed. (LP: #1246529)
 -- Robert Ancell <email address hidden> Thu, 07 Nov 2013 15:39:20 +1300

Changed in lightdm (Ubuntu Saucy):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for lightdm has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers