Please merge lightdm-gtk-greeter 1.8.1-1 from Debian experimental

Bug #1280670 reported by Sean Davis on 2014-02-15
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lightdm-gtk-greeter (Ubuntu)
Undecided
Unassigned

Bug Description

The LightDM GTK+ Greeter has a new stable release, 1.8.1 and it has been packaged in Debian experimental. I've updated the Ubuntu packaging and would like to submit it to be uploaded for 14.04

lightdm-gtk-greeter (1.8.1-1ubuntu1) UNRELEASED; urgency=medium

  * Merge from debian experimental.
  * debian/lightdm-gtk-greeter-ubuntu.conf
    - updated hints from 1.8 template file
    - use new indicator loading for language, session, power indicators
  * debian/rules
    - add indicators to dh_auto_configure
  * debian/control
    - add depends for indicator support
    - fix binary-control-field-duplicates-source lintian tag
    - fix wiki-copyright-format-uri lintian tag
    - fix obsolete-field-in-dep5-copyright lintian tags

 -- Sean Davis <email address hidden> Sat, 15 Feb 2014 08:20:49 -0500

Sean Davis (bluesabre) wrote :

Attaching Ubuntu debdiff,

lightdm-gtk-greeter_1.6.1-0ubuntu3 to lightdm-gtk-greeter_1.8.1-1

Changed in lightdm-gtk-greeter (Ubuntu):
status: New → In Progress
assignee: nobody → Sean Davis (smd-seandavis)
Sean Davis (bluesabre) wrote :

Attaching debdiff, debian 1.8.1-1 to ubuntu 1.8.1-1

Changed in lightdm-gtk-greeter (Ubuntu):
assignee: Sean Davis (smd-seandavis) → nobody
status: In Progress → Confirmed
Dmitry Shachnev (mitya57) wrote :

Thanks for your work, I have some questions (based on looking at debian→ubuntu debdiff):

- Why did you drop 07_fix-NULL-username.patch?
- Why do you depend on libido3-0.1-0, libindicator3-7? That should be handled by dh_shlibdeps instead.

Also, please document all the remaining Ubuntu changes in debian/changelog as described in <https://wiki.ubuntu.com/UbuntuDevelopment/Merging>.

Subscribing myself so that I can upload it quickly once you address my comments.

Sean Davis (bluesabre) wrote :

Hi Dmitry,

As noted in the debian changelog, the 07_fix-NULL-username is no longer needed, it was fixed in 1.8.1. It is also not listed in debian/series, which leads me to believe it was meant to be dropped from the package.
"07_fix-NULL-username dropped, included upstream"

I've documented the additional changes, and removed the depends as suggested. Please let me know if there is anything else that needs to be done.

Dmitry Shachnev (mitya57) wrote :

Tweaked the changelog, added some missing links to debian/copyright, and uploaded. Thanks!

Changed in lightdm-gtk-greeter (Ubuntu):
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm-gtk-greeter - 1.8.1-1ubuntu1

---------------
lightdm-gtk-greeter (1.8.1-1ubuntu1) trusty; urgency=medium

  [ Sean Davis ]
  * Merge from debian experimental (LP: #1280670), remaining changes:
    - debian/rules:
      + add indicators to dh_auto_configure
    - debian/control:
      + add depends for indicator support
      + add depends for liblightdm-gobject-1-dev (ubuntu naming is different)
      + fix binary-control-field-duplicates-source lintian tag
    - debian/copyright:
      + fix wiki-copyright-format-uri lintian tag
      + fix obsolete-field-in-dep5-copyright lintian tags
    - debian/lightdm-gtk-greeter-ubuntu.conf,
    - debian/lightdm-gtk-greeter.install,
    - debian/lightdm-gtk-greeter.{post,pre}{inst,rm},
    - debian/60-lightdm-gtk-greeter.conf,
      + install and remove ubuntu conf files
  * debian/lightdm-gtk-greeter-ubuntu.conf:
    - updated hints from 1.8 template file
    - use new indicator loading for language, session, power indicators
  * Remove debian patches:
    - 04_default-gtk-greeter-config.patch: not used in ubuntu
    - 07_fix-NULL-username.patch: patch was included upstream, no longer used

  [ Dmitry Shachnev ]
  * Add missing license information to debian/copyright.
 -- Sean Davis <email address hidden> Tue, 18 Feb 2014 04:29:53 -0500

Changed in lightdm-gtk-greeter (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers