Ambiance/Radiance should use chromium specific theming controls

Bug #697854 reported by Elliot Glaysher on 2011-01-05
164
This bug affects 40 people
Affects Status Importance Assigned to Milestone
light-themes
Fix Released
Wishlist
Andrea Cimitan
light-themes (Ubuntu)
Low
Andrea Cimitan

Bug Description

Binary package hint: light-themes

(Context: I'm the author of the Google Chrome GTK+ integration code.)
(Related fixed xubuntu bug: https://bugs.launchpad.net/xubuntu-artwork/+bug/686239)

The current interaction between Ambiance and both Chrome 8 and 9 results in a bright orange frame. There appear to be some changes in Ambiance between Lucid and Maverick (our previous autoselected gray wasn't optimal, but wasn't so...bright).

Since (at least as an outsider looking in) CSD doesn't appear like it's going to occur, we've added some explicit nobs for GTK+ authors to fiddle with to force the non-GTK+ parts of the Chrome interface. The new theming controls for Chrome 9 and forward are documented at: http://code.google.com/p/chromium/wiki/LinuxGtkThemeIntegration

This is obviously a low priority, but it'd be a nice to have before Natty is shipped.

Here is an example for Ambiance based on me naively picking colors from screenshots taken with the gimp. Your art team will probably be displeased with it and want to fine tune it. These individual style properties are documented in the link above. It is only meant as an example of what can be done. To try this out, please install either Google Chrome/Chromium 9.0.597 or newer:

style "chrome-gtk-frame"
{
    ChromeGtkFrame::frame-color = @fg_color
    ChromeGtkFrame::inactive-frame-color = lighter(@fg_color)

    ChromeGtkFrame::frame-gradient-size = 16
    ChromeGtkFrame::frame-gradient-color = "#5c5b56"

    ChromeGtkFrame::scrollbar-trough-color = @bg_color
    ChromeGtkFrame::scrollbar-slider-prelight-color = "#F8F6F2"
    ChromeGtkFrame::scrollbar-slider-normal-color = "#E7E0D3"
}

class "ChromeGtkFrame" style "chrome-gtk-frame"

Related branches

Charlie Kravetz (charlie-tca) wrote :

Thanks for reporting this bug and any supporting documentation. Since this bug has enough information provided for a developer to begin work, I'm going to mark it as confirmed and let them handle it from here. Thanks for taking the time to make Ubuntu better!

Changed in light-themes (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Omer Akram (om26er) wrote :

oh, really nice. Just tried and it does the wonders ;) would be really great to have for natty.

subscribed cimi to this bug report too.

Changed in light-themes (Ubuntu):
milestone: none → ubuntu-11.04-beta
status: Triaged → Confirmed
Andrea Cimitan (cimi) wrote :

will publish a branch next week, thanks

Patrick Ulbrich (pulb) wrote :

I use a similar style, it also applies to the incognito frame:

style "chrome-gtk-frame"
{
    ChromeGtkFrame::frame-color = "#3c3b37"
    ChromeGtkFrame::inactive-frame-color = "#3c3b37"

    ChromeGtkFrame::frame-gradient-size = 16
    ChromeGtkFrame::frame-gradient-color = "#5c5b56"

    ChromeGtkFrame::incognito-frame-color = "#3c3b37"
    ChromeGtkFrame::incognito-inactive-frame-color = "#3c3b37"

    ChromeGtkFrame::incognito-frame-gradient-size = 16
    ChromeGtkFrame::incognito-frame-gradient-color = "#5c5b56"

# ChromeGtkFrame::scrollbar-trough-color = @bg_color
# ChromeGtkFrame::scrollbar-slider-prelight-color = "#F8F6F2"
# ChromeGtkFrame::scrollbar-slider-normal-color = "#E7E0D3"
}

class "ChromeGtkFrame" style "chrome-gtk-frame"

Andrea Cimitan (cimi) wrote :

I don't have time to work on a branch right now, but I'm willing to review your branches! so go with bzr branch lp:light-themes!

Andrea Cimitan (cimi) wrote :

that is really nice, just tried the snippet. well done chromium guys and please someone else, branch and propose the merge!

Andrea Cimitan (cimi) wrote :

branch linked

Omer Akram (om26er) on 2011-03-17
Changed in light-themes (Ubuntu):
assignee: nobody → Andrea Cimitan (cimi)
Greg A (etulfetulf) wrote :

I think it would be great to have some theming for chromium in natty!

However I'm not keen on this patche's tab colour for unfocused tabs. I notice in the heavily used extension at [1] the unfocused tab colour is the same as for the current tab - white(ish).

[1]https://chrome.google.com/extensions/detail/elnmibmpefhmfgphdphdncoogpbfmlbp

Andrea Cimitan (cimi) on 2011-03-21
Changed in light-themes:
status: New → In Progress
assignee: nobody → Andrea Cimitan (cimi)
importance: Undecided → Wishlist
Omer Akram (om26er) wrote :

fix committed to trunk. Thanks cimi.

Changed in light-themes:
status: In Progress → Fix Committed
Changed in light-themes (Ubuntu):
status: Confirmed → Triaged
Andrea Cimitan (cimi) wrote :

missing the theming for radiance in incognito, someone please have a look at it, it's a small fix

James Schriver (dashua) wrote :

I got it, Cimi. I'll add it to my merge.

Omer Akram (om26er) on 2011-04-01
Changed in light-themes (Ubuntu):
milestone: ubuntu-11.04-beta-1 → ubuntu-11.04-beta-2
Dmitry Shachnev (mitya57) wrote :

Please update the package before the BetaFreeze!

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package light-themes - 0.1.8.11

---------------
light-themes (0.1.8.11) natty; urgency=low

  [Andrea Cimitan]
  * Ambiance/Radiance/gtk-2.0/gtkrc
    - Fix inconsistent menu item distances (LP: #659866)
  * Ambiance/apps/gnome-terminal.rc
    - Add dark-terminal theming to tweak resize grip
  * Ambiance/Radiance/apps/chromium.rc
    - Add specific chromium theming bits (LP: #697854)

  [Daniel Foré]
  * Ambiance/gtk-2.0/apps/ubuntuone.rc
    - Further tweaks following on from (LP: #715717)
    - May need further adjusting to cope with widgetname adjustments
      in the application itself.

  [James Schriver]
  * Radiance/metacity/metacity-theme-1.xml
    - Fix borderless overlap (LP: #733504)*
    - Update <info> meta-data; version, and incorrect Radiance *name*.
    - Downcase some hexadecimal colours

  [Paul Sladen]
  * This release is known not to be perfect but is an iterative
    improvement on the previous and should get a new base-line.
 -- Paul Sladen <email address hidden> Mon, 11 Apr 2011 08:36:37 +0000

Changed in light-themes (Ubuntu):
status: Triaged → Fix Released
Andrea Cimitan (cimi) on 2011-04-13
Changed in light-themes:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers