(From update of attachment 305310) >+ for (PRInt32 i = urisToUnescape.Count(); --i >= 0; ) { ug that's a confusing loop
>+ rv = fixURI->BindUTF8StringParameter(0, *urisToUnescape[i]); >+ NS_ENSURE_SUCCESS(rv, rv); >+ >+ (void)textToSubURI->UnEscapeURIForUI(charset, *urisToUnescape[i], uriSpec); >+ >+ rv = fixURI->BindStringParameter(1, uriSpec); >+ NS_ENSURE_SUCCESS(rv, rv); >+ >+ rv = fixURI->Execute(); >+ NS_ENSURE_SUCCESS(rv, rv); I think it'd probably be best here to do if (NS_FAILED(rv)) continue;
r=sdwilsh for what it's worth
(From update of attachment 305310) Count() ; --i >= 0; ) {
>+ for (PRInt32 i = urisToUnescape.
ug that's a confusing loop
>+ rv = fixURI- >BindUTF8String Parameter( 0, *urisToUnescape [i]); SUCCESS( rv, rv); URI->UnEscapeUR IForUI( charset, *urisToUnescape[i], uriSpec); >BindStringPara meter(1, uriSpec); SUCCESS( rv, rv); SUCCESS( rv, rv);
>+ NS_ENSURE_
>+
>+ (void)textToSub
>+
>+ rv = fixURI-
>+ NS_ENSURE_
>+
>+ rv = fixURI->Execute();
>+ NS_ENSURE_
I think it'd probably be best here to do
if (NS_FAILED(rv)) continue;
r=sdwilsh for what it's worth