please sync libyuv from Debian 0.0~git20230616.a366ad7-2

[Vladimir Petko]

Ubuntu changes to libyuv can be dropped as they were introduced to resolve build issues.

PPA: ppa:vpa1977/libheif [1]

[Why it is necessary]
The sync will require a feature freeze exception in order to provide a package that:
 - does not have a test failure on arm64
 - does not have build issues on amd64
 - has autopkgtest
 - will allow to progress with libheif MIR application

[Changelog]
The upstream does not provide a changelog file. Attached log of upstream git commits as changelog.txt.

[Build logs]
The build logs are available from the PPA build[2]

[Install logs]

See attachment piuparts.log

[Testing]

The package provides build and runtime dependencies for aom and libavif.
- aom should build against the new version of libyuv[3]
- libavif should build against the new version of libyuv[4]
- aom unit test suite should pass when built with the new version of libyuv (see attachment test.log)

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/libheif
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/libheif/+sourcepub/15164770/+listing-archive-extra
[3] https://launchpad.net/~vpa1977/+archive/ubuntu/libheif/+sourcepub/15155539/+listing-archive-extra
[4] https://launchpad.net/~vpa1977/+archive/ubuntu/libheif/+sourcepub/15164786/+listing-archive-extra

[Vladimir Petko (vpa1977)]

Notes:
 - library contains API changes but dependencies are not affected
 - library contains significant performance improvements

[Paride Legovini (paride)]

Hello, I think this was a perfectly valid "please sync" bug, but looking as it as a FFe request, I find it lacks a compelling reason to be accepted. In particular the [Why it is necessary] section lists reasons why the sync is probably be safe, but do not state why we should do it in the first place.

Your latest comment to the FFe states that the new version "contains significant performance improvements", however: do these fix specific performance issues? Is there a bug report about those?

[Vladimir Petko (vpa1977)]

I am referring to commit 65e7c9d5706a77d1949da59bfcb0817c252ef8d6 in the changelog. It does not reference a public bug (libyuv:XXX) but provides ARM benchmarks that give 7-38% improvements (see changelog.txt).
Commit 3e38ce50589d9319badc0501f96d6c5b2b177472 provides SSE optimization for MM21ToYUY2 conversion (again no public bug).
Main improvement in this version is RISC-V optimizations[1].

[1] https://bugs.chromium.org/p/libyuv/issues/detail?id=956

[Paride Legovini (paride)]

Thanks for the additional information, however I think the performance improvements and the better risc-v support are enough to grant a FFe given were the are in the cycle. In general optimizations are not good material for FFe [1]. The fact that the package is based on git snapshots doesn't help to really tell what changes are in it.

The libheif MIR will likely happen during the NN cycle at this point, so landing a libyuv version with autopkgtests in Mantic won't really make a difference with the MIR process.

In short: NACK for this FFe. If you agree with the points I made above, please change this back into a "please sync" bug, to be tackled early in the NN cycle. If you still think we should grant a FFe on this, please make your point again and and re-subscribe ubuntu-release. Thanks!

[1] https://wiki.ubuntu.com/FreezeExceptionProcess#FeatureFreeze_Exceptions

[Vladimir Petko (vpa1977)]

I agree with this conclusion. Current version has test suite disabled on arm64. This is not the case in the latest version.
On the other hand there are significant implementation/API changes which could introduce a regression.

[Vladimir Petko (vpa1977)]

Resubscribing Ubuntu Sponsors for the sync.

[Graham Inggs (ginggs)]

This bug was fixed in the package libyuv - 0.0~git20230907.cbfb661-1
Sponsored for Vladimir Petko (vpa1977)

---------------
libyuv (0.0~git20230907.cbfb661-1) unstable; urgency=medium

  * New upstream snapshot 20230907.

 -- Boyuan Yang <email address hidden> Fri, 15 Sep 2023 14:06:12 -0400

libyuv (0.0~git20230616.a366ad7-2) unstable; urgency=medium

  [ Vladimir Petko ]
  * debian/tests/: Add autopkgtest using upstream testsuite.

 -- Boyuan Yang <email address hidden> Fri, 15 Sep 2023 04:41:31 -0400

libyuv (0.0~git20230616.a366ad7-1) unstable; urgency=medium

  * New upstream snapshot 20230616.
  * debian/rules: Update UNIT_TEST flag name.
  * debian/patches: Refresh patches.

 -- Boyuan Yang <email address hidden> Tue, 20 Jun 2023 13:44:03 -0400

libyuv (0.0~git20230123.b2528b0-1) unstable; urgency=medium

  * New upstream snapshot 20230123.

 -- Boyuan Yang <email address hidden> Sun, 12 Feb 2023 16:42:22 -0500

libyuv (0.0~git20230104.6e4b0ac-1) unstable; urgency=medium

  * New upstream snapshot 20230104.

 -- Boyuan Yang <email address hidden> Sat, 07 Jan 2023 11:07:37 -0500

libyuv (0.0~git20221206.610e0cd-1~exp1) experimental; urgency=medium

  * New upstream snapshot 20221206.

 -- Boyuan Yang <email address hidden> Sun, 11 Dec 2022 14:54:16 -0500

libyuv (0.0~git20221118.ea26d7a-2) unstable; urgency=medium

  * Upload to unstable.

 -- Boyuan Yang <email address hidden> Wed, 23 Nov 2022 13:44:31 -0500

libyuv (0.0~git20221118.ea26d7a-1) experimental; urgency=medium

  * New upstream snapshot 20221118.

 -- Boyuan Yang <email address hidden> Sun, 20 Nov 2022 14:22:05 -0500

libyuv (0.0~git20221018.8084f0b-1) unstable; urgency=medium

  * New upstream snapshot 20221018.
    + Build yuvconstants tool.
  * debian/patches: Add CMakeLists.txt patch to ensure yuvconstants
    in installed after build.

 -- Boyuan Yang <email address hidden> Tue, 18 Oct 2022 16:09:17 -0400

libyuv (0.0~git20220923.b9adaef-1) unstable; urgency=medium

  * Upload to unstable.

 -- Boyuan Yang <email address hidden> Wed, 28 Sep 2022 16:07:45 -0400

libyuv (0.0~git20220923.b9adaef-1~exp1) experimental; urgency=medium

  * New upstream snapshot 20220923 (version 1845).
  * debian/libyuv0.shlibs: Tighten minimum version requirement.
  * debian/rules: Explicitly disable LTO. Enabling LTO will cause
    the following test to fail:
    - LibYUVPlanarTest.TestInterpolatePlane_16

 -- Boyuan Yang <email address hidden> Sat, 24 Sep 2022 20:14:11 -0400