Does not handle microphone mute button (KEY_MICMUTE)

Bug #408903 reported by Christopher Snapp
486
This bug affects 92 people
Affects Status Importance Assigned to Milestone
OEM Priority Project
Won't Fix
Medium
James M. Leddy
Precise
Won't Fix
Medium
James M. Leddy
Raring
Won't Fix
Medium
James M. Leddy
xkeyboard-config
Fix Released
Medium
gnome-settings-daemon (Ubuntu)
Fix Released
Medium
Unassigned
Declined for Natty by Michael Casadevall
Declined for Quantal by Michael Casadevall
Declined for Saucy by Mathew Hodson
Precise
Fix Released
Undecided
Unassigned
libx11 (Ubuntu)
Fix Released
Undecided
Unassigned
Declined for Natty by Michael Casadevall
Declined for Quantal by Michael Casadevall
Declined for Saucy by Mathew Hodson
Precise
Fix Released
Undecided
Unassigned
udev (Ubuntu)
Fix Released
Medium
Martin Pitt
Declined for Natty by Michael Casadevall
Declined for Quantal by Michael Casadevall
Declined for Saucy by Mathew Hodson
Precise
Fix Released
Undecided
Unassigned
x11proto-core (Ubuntu)
Fix Released
Undecided
Unassigned
Declined for Natty by Michael Casadevall
Declined for Quantal by Michael Casadevall
Declined for Saucy by Mathew Hodson
Precise
Fix Released
Medium
Unassigned
xkeyboard-config (Ubuntu)
Fix Released
Undecided
Unassigned
Declined for Natty by Michael Casadevall
Declined for Quantal by Michael Casadevall
Declined for Saucy by Mathew Hodson
Precise
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
 * People buying thinkpad hardware are not able to use a mic mute key, that comes with
   their machine

[Test Case]

 * Press mic mute key
 * Observe that nothing happens

[Regression Potential]

 * Very low. This is very isolated code. All it does is add functionality. In fact there
   are very few deletions in the diffs.

 * There is an existing acpi solution, that's already been mentioned in this bug. I'm
   not sure how these users would be affected once the upgrade hits, but it was never
   released as an official fix.

[Original Report]

Pressing the new microphone mute button does not do anything. It should toggle the mute on the current capture device and toggle an led that is part of the button.

acpi_listen output:

ibm/hotkey HKEY 00000080 0000101b

xev output:

MappingNotify event, serial 34, synthetic NO, window 0x0,
    request MappingKeyboard, first_keycode 8, count 248

MappingNotify event, serial 34, synthetic NO, window 0x0,
    request MappingKeyboard, first_keycode 8, count 247

KeyPress event, serial 34, synthetic NO, window 0x3400001,
    root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

KeyRelease event, serial 34, synthetic NO, window 0x3400001,
    root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XFilterEvent returns: False

Related branches

Revision history for this message
Jerone Young (jerone) wrote :

What does adding to the kernel command line "acpi_osi=Linux" do ?

Revision history for this message
Jerone Young (jerone) wrote :

This is something I plan to look into for next release. The microphone mute key is not a standard key. It will not even work under windows without a special driver from Lenovo.

Though let me know what happens if you put acpi_osi=Linux on the command line.

Changed in ubuntu:
status: New → Incomplete
Revision history for this message
Christopher Snapp (snappca) wrote :

I did not see any difference when I added "acpi_osi=Linux" to the kernel args. Thanks for looking into it.

Revision history for this message
Patrick (94bc1052) wrote :

I have the same issue, but with the rather new Thinkpad T410. Volume up/down and mute work right out of the box, microphone mute does not, as described above.

Revision history for this message
Tom Gelinas (tomgelinas) wrote :

The T510 is obviously affected, too.

acpi_listen output:

 ibm/hotkey HKEY 00000080 0000101b

XEV Output:

MappingNotify event, serial 38, synthetic NO, window 0x0,
    request MappingKeyboard, first_keycode 8, count 248

KeyPress event, serial 38, synthetic NO, window 0x5000001,
    root 0x15d, subw 0x0, time 3725773, (19,-15), root:(1310,37),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

KeyRelease event, serial 38, synthetic NO, window 0x5000001,
    root 0x15d, subw 0x0, time 3725773, (19,-15), root:(1310,37),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XFilterEvent returns: False

Revision history for this message
Martijn de Nerd (martijn-de-nerd) wrote :

Same problem on Lucid with a T410

Changed in ubuntu:
status: Incomplete → Confirmed
Revision history for this message
Tom Gelinas (tomgelinas) wrote :
Revision history for this message
Jerone Young (jerone) wrote :

There is work going on on the thinkpad-acpi mailing list. To get a support for the button & LED.

Initial support to support the T410s is here:

http://sourceforge.net/mailarchive/forum.php?thread_name=20100420210327.GA1003%40ranger.taprogge.wh&forum_name=ibm-acpi-devel

summary: - thinkpad t400s microphone mute button does not work
+ Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work
Revision history for this message
Victor Vargas (kamus) wrote : Re: Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work

@Christopher, please could you check if this issue is still affecting you under latest release included in Ubuntu Lucid? Additionally, maybe your issue is related to https://bugzilla.novell.com/show_bug.cgi?id=594363. Thanks!

affects: ubuntu → linux (Ubuntu)
Changed in linux (Ubuntu):
importance: Undecided → Low
status: Confirmed → Incomplete
Revision history for this message
Christopher Snapp (snappca) wrote : Re: [Bug 408903] Re: Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work

To be clear the microphone itself works fine, it is only the thinkpad mute
button that is not functional. On the newer thinkpad keyboards there are
two mute buttons one for speakers and one for microphone, each with an led
that should light up when they are activated. The speaker mute button is
functional but its led does not light up, whereas the microphone mute button
does not work at all.

This is still the case in Kubuntu 10.04 with the latest updates.

On Thu, Jul 8, 2010 at 3:44 PM, Kamus <email address hidden> wrote:

> @Christopher, please could you check if this issue is still affecting
> you under latest release included in Ubuntu Lucid? Additionally, maybe
> your issue is related to
> https://bugzilla.novell.com/show_bug.cgi?id=594363. Thanks!
>
> ** Bug watch added: Novell/SUSE Bugzilla #594363
> https://bugzilla.novell.com/show_bug.cgi?id=594363
>
> ** Package changed: ubuntu => linux (Ubuntu)
>
> ** Changed in: linux (Ubuntu)
> Importance: Undecided => Low
>
> ** Changed in: linux (Ubuntu)
> Status: Confirmed => Incomplete
>
> --
> Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work
> https://bugs.launchpad.net/bugs/408903
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in “linux” package in Ubuntu: Incomplete
>
> Bug description:
> Ubuntu 9.04
>
> Pressing the new microphone mute button does not do anything. It should
> toggle the mute on the current capture device and toggle an led that is part
> of the button.
>
> acpi_listen output:
>
> ibm/hotkey HKEY 00000080 0000101b
>
>
> xev output:
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 248
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 247
>
> KeyPress event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XmbLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> KeyRelease event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/408903/+subscribe
>

--
Chris

Revision history for this message
David Strauss (davidstrauss) wrote : Re: Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work

This is still an issue in Ubuntu 10.04.

Changed in linux (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Pete Graner (pgraner) wrote :

Can everyone restest this with Maverick, I am not seeing this with our T410 reference model.

Revision history for this message
Lorenzo (lorped) wrote :

Led is *not* working on T410 with Maverick (right now at Release Candidate version )

Revision history for this message
vyncere (vyncere) wrote :

On my Thinkpad T410 with Ubuntu 10.10 RC, mute recording button does not work at all :
- Led is always off (default)
- Microphone is not never mute (default)

System :
Description: Ubuntu maverick (development branch), Release: 10.10
Linux ubuntu 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:32:27 UTC 2010 x86_64 GNU/Linux
Ubuntu 2.6.35-22.33-generic 2.6.35.4

dmesg :
[ 2917.343368] keyboard: can't emulate rawmode for keycode 240
[ 2917.343393] keyboard: can't emulate rawmode for keycode 240

xev:
KeyPress event, serial 37, synthetic NO, window 0x4200001,
    root 0xb4, subw 0x0, time 3000330, (18,-17), root:(1277,678),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

acpi_listen :
ibm/hotkey HKEY 00000080 0000101b

Revision history for this message
Peter Andreus (peter-andreus) wrote :

On 10.10 Ubuntu with Lenovo l512 same issue microphone mute button doesnt work, LEDs in sound and microphone mute button doesnt work.

But i found funny thing. After reboot from W7 where i mute sound LED in button still lights even in Ubuntu, but now i cant turn that LED off.

Revision history for this message
andypiper (andypiperuk) wrote :

Confirmed still an issue on T510 with Ubuntu 10.10. Mic mute button does not work, speaker mute button does.

Revision history for this message
nameiner (nameiner) wrote :

I can confirm the same behavior on the W510 with 10.10.

Revision history for this message
dm (jan-rauberg) wrote :

Oh, I see, I'm not alone with that kind of problem. I own a T400s with maverick currently installed. The mute and micro buttons don't work in the right manner. I don't need the micro button so I've informed the makers of the thinkpad kernel module about the problem. They answered that without an T400s it is difficult to analyze this behavior. But for the mute button I think it worked some versions before. As far as I know in 9.10 it worked like in Windows 7. In 10.10 and also 10.04 the mute button toggles off the sound but not the system beeps. This is the really annoying thing and therefore the buttons LED doesn't switched on. Only if the LED is on the sound is really muted (also system beeps) and this is what I want. I have colleague who owns a T510 and I've seen that at least the mute LED does work on his laptop in opposite to some posters before. Both laptops (T400s and T510) are using the same keyboard layout. I can't see a reason why the behavior is so different.

Jan

Revision history for this message
sxe.funky (sxe-funky) wrote :

On my T410i with Ubuntu 10.04.1:
 + Sound mute works with its led.
 - Mic mute doesn't works

Revision history for this message
Barry Carroll (baz8080) wrote :

T410i.

The mic mute button does not mute the mic as confirmed with sound preferences.

Revision history for this message
Bausparfuchs (bausparfuchs) wrote :

Issue exists in Natty on my New Lenovo Thinkpad x220i

Steve Langasek (vorlon)
Changed in acpi-support (Ubuntu):
status: New → Invalid
Changed in gnome-control-center (Ubuntu):
status: New → Invalid
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Steve, why is this not valid for acpi-support? AFAIR this is an ACPI-related issue. You need some support to actually trigger the LED on that button to change when pressed.

Revision history for this message
Steve Langasek (vorlon) wrote :

Hey Zyga,

> why is this not valid for acpi-support?

Because acpi-support is a deprecated package which is being phased out - new features should not be added there.

> You need some support to actually trigger the LED on that
> button to change when pressed.

I think this should probably be implemented in the kernel itself (as suggested by the already-open 'linux' task); we don't want that handling to be dependent on a desktop component (like gnome-settings-daemon), and as acpi-support should go away, that leaves the kernel as the preferred place to implement this. (And that would definitely be consistent with other LED handling.)

Revision history for this message
Daniël van Eeden (dveeden) wrote :

The microphone mute button needs:
- Support in linux
- Support in high level tools (There is no key binding in GNOME for microphone mute a.t.m.)

The microphone mute button also has a LED(-like) indicator which also needs support.

The LED(-like) indicator for the 'normal' mute button can easily get out of sync with the indicator-sound-service one.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

The LED(-like) indicator for the 'normal' mute button can easily get out of sync with the indicator-sound-service one.

I think this is a separate and valid bug. The LED indicator should be controlled by alsa when sound is becomes mute.

Revision history for this message
Daniël van Eeden (dveeden) wrote :

I've created Bug #788540 for the seperate issue about the mute button indicator getting out of sync.

Revision history for this message
Thomas Hood (jdthood) wrote :

The microphone mute key is not currently supported in Ubuntu but the fix is fairly straightforward.

First, udev needs to map the micmute key's scancode to a keyname which corresponds to an X key event. This has been fixed[0] in udev upstream. It is possible to make the same change locally, as described here[1].

Second, the key event needs to mute the microphone. This can be accomplished with a small script as described here[1].

[0]http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=6e3b1694a4dea049591af1f089adce327bf6a542
[1]http://www.thinkwiki.org/wiki/Installing_Ubuntu_11.04_(Natty_Narwhal)_on_a_ThinkPad_X220#Fix_for_hotkey_shortcomings

Revision history for this message
O Gopal (jswami) wrote :

Issue exists with Natty on my T420s.

Revision history for this message
Simon Hirscher (codethief) wrote :

I can confirm this for my W510 (can we add it to the bug title?).

summary: - Thinkpad T400s, T410s, T410, & T510 microphone mute button does not work
+ Thinkpad T400s, T410s, T410, T510 & W510 microphone mute button does not
+ work
Revision history for this message
Simon Hirscher (codethief) wrote : Re: Thinkpad T400s, T410s, T410, T510 & W510 microphone mute button does not work

(I should add: I'm on Oneiric)

Revision history for this message
mitakas (mitakas) wrote :

I can also confirm this issue on 11.10 and Thinkpad T420.

Revision history for this message
Grigory Rechistov (atakua) wrote :

I confirm this issue on Lenovo Thinkpad X220i with Oneiric x86_64.

Revision history for this message
matze (matzex) wrote :

On Thinkpad X220 with Oneric (64bit) i can confirm this issue, too!

Revision history for this message
Norbert Varga (nonoo) wrote :

Issue confirmed on a T520.

Revision history for this message
Martin Pitt (pitti) wrote :

Since linux 3.0 we actually have a KEY_MICMUTE, so I'll update the udev keymaps accordingly.

Changed in linux (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: Confirmed → In Progress
affects: linux (Ubuntu) → udev (Ubuntu)
Revision history for this message
Martin Pitt (pitti) wrote :

The module-lenovo keymap actually already is updated to "micmute" upstream and in precise already. So that part is done, if it still doesn't work in precise it's a gnome-settings-daemon bug.

Changed in udev (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Simon Hirscher (codethief) wrote :

Still doesn't work for me, so it must be gnome-settings-daemon.

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 408903] Re: Thinkpad T400s, T410s, T410, T510 & W510 microphone mute button does not work

Simon Hirscher [2011-12-14 23:04 -0000]:
> Still doesn't work for me, so it must be gnome-settings-daemon.

If you press the key, do you get anything in xev? If not, we'll need
to fix X.org first to translate the new KEY_MICMUTE to an appropiate
X.org event.

Revision history for this message
Daniël van Eeden (dveeden) wrote : Re: Thinkpad T400s, T410s, T410, T510 & W510 microphone mute button does not work

With kernel 3.0.0-14-generic on oneiric with a T410s this is the output from xev when I press the micmute button. There is no event when I release the key. Pressing the micmute button emits a KeyPress and a KeyRelease event.

KeyPress event, serial 35, synthetic NO, window 0x4600001,
    root 0xc1, subw 0x0, time 93097135, (103,-18), root:(1544,10),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

KeyRelease event, serial 35, synthetic NO, window 0x4600001,
    root 0xc1, subw 0x0, time 93097135, (103,-18), root:(1544,10),
    state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XFilterEvent returns: False

As far as I known there is still no micmute shortcut defined in gnome3.

Revision history for this message
Martin Pitt (pitti) wrote :

  state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,

This shows that X.org does not yet know how to translate KEY_MICMUTE to an X.org key name. Opening -evdev task for now, which is probably wrong (xkb-data?).

affects: acpi-support (Ubuntu) → xserver-xorg-input-evdev (Ubuntu)
Changed in xserver-xorg-input-evdev (Ubuntu):
assignee: nobody → Canonical X.org (canonical-x)
importance: Undecided → Low
status: Invalid → Triaged
summary: - Thinkpad T400s, T410s, T410, T510 & W510 microphone mute button does not
- work
+ Does not handle microphone mute button (KEY_MICMUTE)
Revision history for this message
Martin Pitt (pitti) wrote :

Opening task for gnome-settings-daemon as well. Once X.org passes an actual key event, we need to handle it there to actually mute the microphone.

affects: gnome-control-center (Ubuntu) → gnome-settings-daemon (Ubuntu)
Changed in gnome-settings-daemon (Ubuntu):
importance: Undecided → Low
status: Invalid → Triaged
Revision history for this message
Chris Van Hoof (vanhoof) wrote :

Couple bits to note:

1: As for the mic-mute LED. There was a thread a few months back (would have to dig it up) where the LED functioning was brought up and the proposed patch was never ack'd in favor of a more scale-able approach, however I'm not sure if that is still an active effort. Here is the patch in question for reference which I've tested on Precise and my x220's LED light does function with the patch:

http://kernel.ubuntu.com/git?p=vanhoof/ubuntu-precise.git;a=commitdiff;h=94758d8ce7068c5c3b7eb91fceb3c7acca9b0bd5

2: There is no userspace plumbing for this key (as pitti mentioned). I have been using a workaround on my x220 to get the mic mute button to function. With Oneiric and Precise, with these acpi script workarounds the mute function _should_ function (no LED) when depressed (verify in sound settings).

Here are the two scripts I'm using:

==> /etc/acpi/micmute.sh <==
#!/bin/bash

test -x /usr/bin/amixer || exit 0

mic_status () {
 STATUS=$(amixer sget Capture | grep ': Capture' | grep -v Limits | head -n 1 | awk '{print $7}' | sed 's/\[//;s/\]//')
}

mic_status

if [[ $STATUS == "on" ]]; then
 /bin/echo "1" > '/sys/devices/platform/thinkpad_acpi/leds/tpacpi::micmute/brightness'
elif [[ $STATUS == "off" ]]; then
 /bin/echo "0" > '/sys/devices/platform/thinkpad_acpi/leds/tpacpi::micmute/brightness'
fi

/usr/bin/amixer -q sset Capture toggle

==> /etc/acpi/events/lenovo-micmute <==
#
# listens for an acpi event when micmute hotkey is pressed
# ... and executes /etc/acpi/micmute.sh
#
event=ibm/hotkey HKEY 00000080 0000101b
action=/etc/acpi/micmute.sh

======================================================================================

Couple additional bits to note:

1: If using these scripts make sure you're seeing the acpi event when the mic mute key is pressed, and that value matches what is entered in /etc/acpi/events/lenovo-micmute:

$ acpi_listen
    ... press the mic-mute key

You should see something similar (if not identical) to this:

"ibm/hotkey HKEY 00000080 0000101b"

2: Set both /etc/acpi/events/lenovo-micmute and /etc/acpi/micmute.sh to be executable and restart the acpid service.

3: I've written micmute.sh in a way where the LED will be toggled, so it relies on LED support, however it should work even without the aforementioned patch.

Lastly, if you would like to test out a precise kernel with the LED patch you can download a build here:

http://kernel.ubuntu.com/~vanhoof/tp/precise/amd64/
http://kernel.ubuntu.com/git?p=vanhoof/ubuntu-precise.git;a=shortlog;h=refs/heads/tp

-chris

Revision history for this message
Thomas Hood (jdthood) wrote :

The microphone mute key yields Linux key input event KEY_MICMUTE which has the value 248. Add 8 to get the X KeyCode number, you get 256. This is greater than the maximum KeyCode that X handles, 255.

See: http://www.x.org/wiki/XI2

The problem is similar to the problem with the Zoom hotkey combination on the X220, Fn-Space. The key combination yields KEY_ZOOM, value 372. The corresponding X KeyCode, 380, is also above 255.

A workaround is to remap the keycodes to ones that X can handle.

See: http://www.thinkwiki.org/wiki/Installing_Ubuntu_11.04_(Natty_Narwhal)_on_a_ThinkPad_X220#Fix_for_hotkey_shortcomings

(This page doesn't describe a way to control the LED on the Microphone Mute key.)

Revision history for this message
Thomas Hood (jdthood) wrote :

Question: What has to happen before 32-bit keycodes can be used in Ubuntu? If the work will be done, when is it likely to be finished?

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

XKB 2.0 needs to happen in the xserver, see bug 313514.

TL;DR - not anytime soon. Though now that multitouch is nearly finished, you never know what the input guy(s) will work on next..

tags: added: blocks-hwcert-enablement
Revision history for this message
Steven Keys (steevven1) wrote :

I'm on a ThinkPad X220 running Xubuntu 11.10 64-bit and can confirm that the mic mute button does not respond, and the LED does not light up either. Have not tried any of the fixes.

Revision history for this message
Alan Goodman (zgzx6-alan-kecso) wrote :

I can confirm on my x220 in 12.04 daily updated as of today hat the mic mute key doesnt work.

Revision history for this message
lopthopman (lopthopman-ann0) wrote :

Not working on t420s on updated 11.10

Revision history for this message
rooobertek (rooobertek) wrote :

Not working on L520 on 12.04.
I tried to manually set the keyboard shortcut adding item to "Custom shortcuts". Other buttons I can choose. This one not.

Revision history for this message
rooobertek (rooobertek) wrote :

QuickFix, I think it may handle some thinkpad-specific package.

1. create and edit file /etc/acpi/events/lenovo-micmute
2. write this into:
    event=ibm/hotkey HKEY 00000080 0000101b
    action=amixer set Capture toggle
3. execute as root:
    killall -HUP acpid

After I wrote code above, I have found this:
http://www.thinkwiki.org/wiki/How_to_configure_acpid#Make_the_Microphone_Mute_button_work
There is it made more pretty

Revision history for this message
James M. Leddy (jm-leddy) wrote :
Revision history for this message
James M. Leddy (jm-leddy) wrote :
Revision history for this message
James M. Leddy (jm-leddy) wrote :

I've read the comment in x11proto/keysymdef.h, but it isn't immediately clear what I should do to define a new keysym with X. It appears that there haven't been any new keysyms since XF86XK_TouchpadOn/Off to go by example either. If anyone has some tips or a document that specifics the correct way to define a new keysym in 2012, I would greatly appreciate it.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Okay, I've created some test packages. Please keep in mind these are only test packages, I haven't even sent upstream yet. To get around the complications with keycodes over 248 I've remapped to the F20 key, which most keyboards don't have. We've been using the Function keys for this purpose for a while now, for example, touchpadtoggle events are F21.

Please let me know if there are any dependencies missing. These packages were compiled on Precise, and it is very likely they will be overwritten by a future sru:

http://people.canonical.com/~jmleddy/micmute/

You can see what it looks like here:

http://people.canonical.com/~jmleddy/micmute/2012-08-07-132202_1366x768_scrot.png

All the source is in my source directory under the name micmute:

https://code.launchpad.net/~jm-leddy/

Revision history for this message
gustavo panizzo (gfa) wrote : Re: [Bug 408903] Re: Does not handle microphone mute button(KEY_MICMUTE)

On 07.08.2012 14:29, James M. Leddy wrote:
> Okay, I've created some test packages. Please keep in mind these are
can you, please, provide i386 packages, or at least a .dsc file

> All the source is in my source directory under the name micmute:
>
> https://code.launchpad.net/~jm-leddy/

i don't see it for 12.04

thanks!

Revision history for this message
James M. Leddy (jm-leddy) wrote :
Revision history for this message
gustavo panizzo (gfa) wrote :

sorry but gnome-settings-daemon crashes, i cannot test it :(

On 08.08.2012 10:25, James M. Leddy wrote:
> The branches are here:
>
> lp:~jm-leddy/ubuntu/quantal/gnome-settings-daemon/micmute
> lp:~jm-leddy/ubuntu/quantal/x11proto-core/micmute
> lp:~jm-leddy/ubuntu/quantal/udev/micmute
> lp:~jm-leddy/ubuntu/quantal/xkeyboard-config/micmute
>
> I thought I based properly on 12.04 packages. Please let me know if
> there is an error.
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (751471).
> https://bugs.launchpad.net/bugs/408903
>
> Title:
> Does not handle microphone mute button (KEY_MICMUTE)
>
> Status in “gnome-settings-daemon” package in Ubuntu:
> Triaged
> Status in “udev” package in Ubuntu:
> Fix Released
> Status in “xserver-xorg-input-evdev” package in Ubuntu:
> Triaged
>
> Bug description:
> Ubuntu 9.04
>
> Pressing the new microphone mute button does not do anything. It
> should toggle the mute on the current capture device and toggle an
> led
> that is part of the button.
>
> acpi_listen output:
>
> ibm/hotkey HKEY 00000080 0000101b
>
>
> xev output:
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 248
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 247
>
> KeyPress event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162),
> root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XmbLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> KeyRelease event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162),
> root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/408903/+subscriptions

Revision history for this message
James M. Leddy (jm-leddy) wrote :

I just recompiled to be sure and it works fine for me. I'm on precise at the moment. Are you using the dpkgs or compiling yourself? Please keep in mind you have to install the new x11proto-core-dev and then recompile libx11 for this to work.

tags: added: rls-q-incoming
Revision history for this message
gustavo panizzo (gfa) wrote : Re: [Bug 408903] Re: Does not handle microphone mute button (KEY_MICMUTE)

i didn't recompile libx11, i will do it asap

On Wed, Aug 08, 2012 at 04:50:59PM -0000, James M. Leddy wrote:
> I just recompiled to be sure and it works fine for me. I'm on precise at
> the moment. Are you using the dpkgs or compiling yourself? Please keep
> in mind you have to install the new x11proto-core-dev and then recompile
> libx11 for this to work.
>
> ** Tags added: rls-q-incoming
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (751471).
> https://bugs.launchpad.net/bugs/408903
>
> Title:
> Does not handle microphone mute button (KEY_MICMUTE)
>
> Status in “gnome-settings-daemon” package in Ubuntu:
> Triaged
> Status in “udev” package in Ubuntu:
> Fix Released
> Status in “xserver-xorg-input-evdev” package in Ubuntu:
> Triaged
>
> Bug description:
> Ubuntu 9.04
>
> Pressing the new microphone mute button does not do anything. It
> should toggle the mute on the current capture device and toggle an led
> that is part of the button.
>
> acpi_listen output:
>
> ibm/hotkey HKEY 00000080 0000101b
>
>
> xev output:
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 248
>
> MappingNotify event, serial 34, synthetic NO, window 0x0,
> request MappingKeyboard, first_keycode 8, count 247
>
> KeyPress event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XmbLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> KeyRelease event, serial 34, synthetic NO, window 0x3400001,
> root 0x118, subw 0x0, time 10334714, (317,-162), root:(322,207),
> state 0x0, keycode 248 (keysym 0x0, NoSymbol), same_screen YES,
> XLookupString gives 0 bytes:
> XFilterEvent returns: False
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/408903/+subscriptions

--
1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333

Revision history for this message
gustavo panizzo (gfa) wrote :

after recompiling everything, including libx11 segfault festival!
udev crashes machine is almost unusable.

sorry

Revision history for this message
James M. Leddy (jm-leddy) wrote :

That's odd, the only thing I changed is a configuration file /lib/udev/keymaps/module-lenovo . If you want, you can install the old udev and just modify that file and you _should_ have it working. What distro/version are you using? I can help out by debugging on the same platform.

Here's the patch if you want to edit module-lenovo yourself:

https://bazaar.launchpad.net/~jm-leddy/ubuntu/quantal/udev/micmute/view/head:/debian/patches/remap_micmute.patch

Revision history for this message
gustavo panizzo (gfa) wrote : Re: [Bug 408903] Re: Does not handle microphone mute button(KEY_MICMUTE)

now it worked fine :)

only one problem, when i press the button it mutes the sound but input
freezes for a few seconds, i need to switch to tty1 and go back to get
input (mouse click or keypress)
but i think that is a problem of my laptop, when i ran xev i saw many
key presses when i press (touch) any of the top-right buttons

system is ubuntu lts 12.04.1 i386, lenovo z470

thanks

Revision history for this message
James M. Leddy (jm-leddy) wrote :

That sounds like it may hardware problem. Unfortunately we never certified the z470 so I can't debug the issue further.

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

Unfortunately, udev and the kernel use a keymap that is out of range of X for micmute. We should use a key that X can process. Since there is no F20 key on the thinkpad, which is the only platform I know of that has a micmute key, we can use that.

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

I guess it would be more correct to fix udev/kernel. Isn't that so?

Currently symbols/inet(evdev) is used for all keyboards, so all of them would use F20 for micmute. I am not very happy about that...

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

(In reply to comment #1)
> I guess it would be more correct to fix udev/kernel. Isn't that so?

It's already "fixed" in udev/kernel, because udev/kernel can handle keycodes over 255. However, X11 can't (MICMUTE is out of range), we have to remap it to something that X11 can use. We've used F21-23 before, so I assumed that was the best place to put it. I'm open to suggestions.

> Currently symbols/inet(evdev) is used for all keyboards, so all of them would
> use F20 for micmute. I am not very happy about that...

What keyboards have F20? We're already using F21-23 for the touchpad on/off/toggle buttons, so there is a precedent for this.

Revision history for this message
In , Bugzilla-x (bugzilla-x) wrote :

Are there physical keyboards with an F20 key?

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

(In reply to comment #3)

Not in common use. The M keyboard only has 12, and the Sun keyboard only has 12. Seems that every PC vendor and certainly every laptop maker only goes up to F12. Even the X Termainal photo from Wikipedia only has up to F12

Revision history for this message
In , Alan Coopersmith (alan-coopersmith) wrote :

(In reply to comment #4)
> Not in common use. The M keyboard only has 12, and the Sun keyboard only has
> 12. Seems that every PC vendor and certainly every laptop maker only goes up to
> F12. Even the X Termainal photo from Wikipedia only has up to F12

Sun keyboards in the 80's had 35 F-keys - since around 1990 many of those were
relabeled - the left side keys to the SunStop, SunProps, etc and the right side
to the numeric keypad. Those were only found on the old Sun 4 and older
systems, not any UltraSPARC, x86 or AMD64 systems. I think other Unix
workstations from the era had similarly large amounts of F keys for the
CAD/CAM applications of the time, but those fell out of use over the years.

Revision history for this message
In , Wettstein509 (wettstein509) wrote :

> Are there physical keyboards with an F20 key?

Unicomp "terminal" keyboards have 24 function keys, are still manufactured, and available with USB for use with a PC.

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

> Unicomp "terminal" keyboards have 24 function keys, are still manufactured, and
> available with USB for use with a PC.
So, F30?

tags: added: rls-q-notfixing
removed: rls-q-incoming
Revision history for this message
In , James H. Cloos Jr. (cloos-jhcloos) wrote :

I wasn’t ready to come out of the woodwork with this, but given this bug
report....

I've started implementing my earlier suggestion to get around X’s 8–bit
keycode limitation by modifying evdev to create one X keyboard device
for each 7–bit block of linux event key codes.

This will make every key available to X, inlcuding the mic mute key,
the zoom key (Fn-SPC), et al.

Not to mention all of the telephone and media-device input keys
(KEY_OK .. KEY_CAMERA_RIGHT).

My plan was/is to get it into shape by the end of this (holiday)
weekend.

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

Wow, okay. That's great news! I can certainly wait a few more months, thanks for working on it.

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

s/months/days/

Bryce Harrington (bryce)
Changed in xserver-xorg-input-evdev (Ubuntu):
assignee: Canonical X.org (canonical-x) → nobody
Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

Hi James,

I don't think I'm on the relevant mailing lists. Have you posted the code yet?

Changed in udev (Ubuntu Raring):
status: New → Triaged
importance: Undecided → Medium
Changed in xserver-xorg-input-evdev (Ubuntu Raring):
status: New → Triaged
importance: Undecided → Medium
Changed in gnome-settings-daemon (Ubuntu Raring):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
gherardo (gherardo) wrote :

I have a T410 with 12.04 64bit and doesn't work.

tags: added: rls-r-incoming
Revision history for this message
wheelerlaw (wheelerlaw) wrote :

I have a T430 running 12.10 and can confirm that the key is not working.

xev outputs nothing when the key is pressed/released.
acpi_listen outputs:
        ibm/hotkey HKEY 00000080 0000101b
input-events 5 outputs :

EV_MSC MSC_SCAN 26
EV_KEY KEY_MICMUTE (0xf8) pressed
EV_SYN code=0 value=0
EV_MSC MSC_SCAN 26
EV_KEY KEY_MICMUTE (0xf8) released
EV_SYN code=0 value=0

Not quite sure what course of action I should take, but I found this page (http://askubuntu.com/questions/125367/enabling-mic-mute-button-and-light-on-lenovo-thinkpads), and it seems like a very similar solution to that of Chris Van Hoof's.

Revision history for this message
wheelerlaw (wheelerlaw) wrote :

Edit:

As I have just discovered, the acpi scripts do not appear to be working in 12.10 x64 on a lenovo t430. Using both the method described in the link I posted and Chris Van Hoof's, I can't get the acpi events system to execute the micmute.sh script. I followed both guides _exactly_. I can manually invoke the script, but that defeats the purpose of having the button. This is a simple script I created as a workaround for this issue:

#!/bin/bash
while true
do
event="`acpi_listen -c 1`"
if [[ $event == "ibm/hotkey HKEY 00000080 0000101b" ]]
then
bash /etc/acpi/micmute.sh
fi
done

To use it, set it to be executable and add the path to the script in /etc/rc.local

Revision history for this message
Thomas Hood (jdthood) wrote :
Bryce Harrington (bryce)
tags: added: raring
Revision history for this message
In , Ozancag (ozancag) wrote :

What's the status of this?

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

The bug is stagnant. I'm not sure if James Cloos has fixed it in X yet, but because we're waiting on that proper fix we haven't mapped micmute to F20 just yet.

Changed in oem-priority:
assignee: nobody → James M. Leddy (jm-leddy)
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
LuisMi (luismi-cruz) wrote :

Failing also in a thinkpad x1 too, with 12.04

Revision history for this message
Joseph A (jahn89) wrote :

Thinkpad T520 w NVS 4200M
Ubuntu 12.10

Fails to work as well.

Fixed it by patching thinkpad_acpi and recompiling (don't know if it's necessary). Someone posted http://askubuntu.com/questions/125367/enabling-mic-mute-button-and-light-on-lenovo-thinkpads/279135#279135 before I actually managed to get this to work.

The first answer gets the idea of it but there were some minor problems when I tired to use it... ie nothing happened. There was a minor problem with the bash script variables but works with some tweeking. I tested while running with sudo but won't know until I restart.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Looks like this has been upstreamed as well. Since we have not yet explicitly gotten the "F20" to be the new XF86MicMute key, upstream g-s-d devs just mapped it to F20 themselves. https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=5cda26ee

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Unfortunately, the patch to gnome-settings-daemon didn't get in soon enough to make the raring release, and we're past feature freeze. But at the same time, we also don't have a new enough x11proto-core to use the XF86MicMute keysym anyway. The first version that works is xproto-7.0.24, released on March 29th, and the latest version debian has is 7.0.23.

In any case, I've created a PPA that allows intersted people to try the new functionality present in g-s-d (using F20). Please only proceed if you are confident in what you're doing. If you're using a thinkpad, the first thing you need to do is edit your /lib/udev/keymaps/module-lenovo file so that 'micmute' is 'f20', since we will be using f20 for that key. Other laptops already have proper udev keymap files.

The second thing is to make sure keycode 198 is maped to 'F20' as far as X is concerned. This is easily done with

xmodmap -e "keycode 198 = F20"

To make it permant, edit your ~/.Xmodmap file

And finally install gnome-settings-daemon from the PPA:

https://launchpad.net/~jm-leddy/+archive/micmute
https://wiki.archlinux.org/index.php/Xmodmap

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

I've sent another message to the list to see if they would include the patch. It is not worth holding off on this, even if we do eventually get around the 8 bit keycode limitation, since while I wasn't looking both udev and gnome-settings-daemon have standardized on F20 for this key.

https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=5cda26ee

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

I would prefer for James Cloos to fix it properly..

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

(In reply to comment #1)
> Currently symbols/inet(evdev) is used for all keyboards, so all of them
> would use F20 for micmute. I am not very happy about that...

This doesn't really make sense. Yes, today symbols/inet is used for all keyboards, but FK20 (code 198) is not mapped to _anything_. If you actually have a keyboard with an F20 key, it'll be remapped by the vendor specific keyboard map anyway (eg digital_vndr/lk).

A quick grep reveals that only 3 keyboards even use this key: a VT105, an ancient DEC keyboard that also requires a special driver, and a fujitsu keyboard that I can't find any mention of online.

The other approach if people are really big on keeping F20 functionality around is to map FK20 to F20, and leave gnome-settings-daemon as it is. This has the downside of making XF86AudioMicMute irrelevent.

Revision history for this message
In , Peter Hutterer (peter-hutterer) wrote :

quite frankly, I think we should admit defeat and go with the F20 route. X gaining support for > 255 keycodes is unlikely to ever happen and F20 is as good/bad a key as any.

Revision history for this message
In , James H. Cloos Jr. (cloos-jhcloos) wrote :

Anthough I know what needs to be done, and have a preliminary commit for
xkeyboard-config, the changes for xf86-input-evdev will require a block
of time I've not been able to schedule.

I agree that that f20 patch is good for now.

I'll post something on the list about my proposed patches.

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

Ok, let's do it with F20. The patch does not apply to git:

$ git am ~/Downloads/mail.google.com
Applying: Add XF86AudioMicMute mappings
error: patch failed: symbols/inet:120
error: symbols/inet: patch does not apply
Patch failed at 0001 Add XF86AudioMicMute mappings
The copy of the patch that failed is found in:
   /home/svu/git/xkeyboard-config/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

Created attachment 79265
0001-https-bugs.freedesktop.org-show_bug.cgi-id-54171.patch

Sorry about that, this patch should work.

Revision history for this message
In , James M. Leddy (jm-leddy) wrote :

Created attachment 79266
0001-Add-XF86AudioMicMute-mappings.patch

Forgot the title for the last patch. This one is better.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Upstream said they were willing to take my patch: https://bugs.freedesktop.org/show_bug.cgi?id=54171

Changed in xkeyboard-config:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

applied, thanks!

Changed in xkeyboard-config:
status: Confirmed → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

@James: thanks, I've backported that patch to saucy ... is the xkeyboard-config change enough or do we still need other component patched? Do we need to SRU that as well?

Revision history for this message
James M. Leddy (jm-leddy) wrote :

We need to SRU udev as well, and ultimately g-s-d so that it actually mutes the volume when it gets this keycode. I'll work on the SRU template since Lenovo would probably like this to work in 12.04

Revision history for this message
James M. Leddy (jm-leddy) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Closing udev task. As far as I can see, KEY_MICMUTE is being emitted correctly, but X.org cannot handle this key.

Changed in udev (Ubuntu):
status: Triaged → Invalid
Changed in udev (Ubuntu Raring):
status: Triaged → Invalid
Revision history for this message
James M. Leddy (jm-leddy) wrote :

Hi Martin,

I don't think we should close it just yet. The key still maps to micmute (as you mention), and upstream udev and X and gnome-settings-daemon all agree on f20. I can prepare a bzr branch if it makes things easier. Alternately we could just wait for udev v199 or greater to land in the distro, but I don't consider it closed.

Revision history for this message
Sebastien Bacher (seb128) wrote :

@James: we have the new udev in saucy since today: https://launchpad.net/ubuntu/+source/systemd/202-0ubuntu6

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Great! Thanks for the clarification.

Revision history for this message
Martin Pitt (pitti) wrote :

Ah right, turning from "invalid" to "fix released" then, sorry.

Changed in udev (Ubuntu):
status: Invalid → Fix Released
Changed in udev (Ubuntu Raring):
status: Invalid → Triaged
Revision history for this message
James M. Leddy (jm-leddy) wrote :

This bug is blocking on resolution of bug 937822. I don't know if I need to revert on top of the -proposed branch or if it's better to just go off the -updates branch of xkeyboard-config.

description: updated
Revision history for this message
James M. Leddy (jm-leddy) wrote :

Ideally, we get this SRUed to Precise. I've filled out the SRU template. It's just a bit tricky because functionality cross cuts a lot of packages. I've added branches for all of the packages that require code changes. It works something like this:

1) x11-proto gets updated with a new #define
2) install x11proto-core-dev on the build server
3) rebuild libx11
4) update the remaining linked packages: udev, gnome-settings-daemon, xkeyboard-config

I've subbed sponsors for some guidance and to get x11-proto updated. Alternately if this is out of scope we can close this bug for precise.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Hey James, I'm going to sponsor x11-proto has a first step, then we can rebuild libx11 with it ... I'm not sure about the updates for the other packages listed, let's see once we have libx11 updated

Revision history for this message
Sebastien Bacher (seb128) wrote :

(unsubscribing sponsors, please subscribe them back once the current package makes it in the archive and we are ready to sponsor libx11 (that's next right?)

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Okay, Thanks for your help Sebastien.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Christopher, or anyone else affected,

Accepted x11proto-core into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/x11proto-core/7.0.22-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in x11proto-core (Ubuntu Precise):
importance: Undecided → Medium
status: New → In Progress
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
James M. Leddy (jm-leddy) wrote :

The only way I can think to verify this is to compile against it. I'll try it this afternoon.

Revision history for this message
Lothar Fausthenze (fausthenze) wrote :

Is it possible for me to test the above fixes (g-s-d, x11-proto-core, udev, xkeyboard-config) on precise?

I just built x11-proto-core from proposed but apparently the package alone doesn't fix the bug for me. I also have to admit that I'm not familiar with inter-distribution fixes and how to apply them to my distribution, be it Ubuntu or Debian.

Thanks in advance. :)

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Hi Lothar,

In order to get full functionality, you have got to download x11-proto-core (sounds like that's already done), and then follow steps 3 and 4 from comment 108. If haven't compiled Ubuntu packages from source before, this bug probably isn't the best place to start ;)

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Rebuilds were successful!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Thomas Hood (jdthood) wrote :

I was about to test the new versions of the various packages but then I noticed that x11proto-core isn't currently installed on my Ubuntu Desktop 13.04 system. So clearly I am failing to understand something. Exactly which package versions should I install on Ubuntu Desktop 13.04 in order to test the newly added support for the ThinkPad microphone mute button?

Revision history for this message
James M. Leddy (jm-leddy) wrote :

It's x11proto-core-dev, if you get stuck with that again, you can figure it out by following the link in the call to test the proposed package:

https://launchpad.net/ubuntu/+source/x11proto-core/7.0.22-1ubuntu0.1

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package x11proto-core - 7.0.22-1ubuntu0.1

---------------
x11proto-core (7.0.22-1ubuntu0.1) precise-proposed; urgency=low

  * Add 0001-Add-XF86XK_AudioMicMute.patch:
    - Backport commit f1b8b4dd from upstream. This adds a key that
      is used on some thinkpad keyboards. Fixes (LP: #408903)
 -- James M Leddy <email address hidden> Thu, 30 May 2013 20:11:37 -0400

Changed in x11proto-core (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Per comment #109, I've added libx11 as a component. Additionally, I'm re-subbing -sponsors so that they will see this request. All we need is a rebuild of the package with the latest x11proto-core.

Changed in libx11 (Ubuntu):
status: New → Confirmed
Revision history for this message
Iain Lane (laney) wrote :

Uploaded a no-change rebuild of libx11 to precise, thanks

Revision history for this message
James M. Leddy (jm-leddy) wrote :

Thanks Ian,

Waiting for it to hit -proposed to test.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

We don't any changes to xserver-xorg-input-evdev in order to fix this problem. Marking as Won't Fix.

Changed in xserver-xorg-input-evdev (Ubuntu):
status: Triaged → Won't Fix
Changed in xserver-xorg-input-evdev (Ubuntu Precise):
status: New → Won't Fix
Changed in xserver-xorg-input-evdev (Ubuntu Raring):
status: Triaged → Won't Fix
Changed in libx11 (Ubuntu Precise):
status: New → In Progress
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

libx11 is in precise unapproved queue. Unsubscribing ubuntu-sponsors for now. If more uploads needed, please re-subscribe the team, when ready.

Revision history for this message
Ara Pulido (ara) wrote :

Adding the SRU team, to get it approved in the queue

Revision history for this message
Sebastien Bacher (seb128) wrote :

> Adding the SRU team, to get it approved in the queue

Thanks Ara, I don't think it's necessary though, the SRU team tends to work the other way around: they check the queue and come back to the bugs from the changelog. I guess the message/subscribe can help as a gently review nudge though ;-)

Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Christopher, or anyone else affected,

Accepted libx11 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libx11/2:1.4.99.1-0ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libx11 (Ubuntu Precise):
status: In Progress → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Lothar Fausthenze (fausthenze) wrote :

I installed libx11-6 from precise-proposed but can't verify the included bugfix. Apart from that, is there any other relevant package that has to be updated? I have the following (latest) versions installed:

 gnome-settings-daemon: 3.4.2-0ubuntu0.6.2
 libx11-6: 2:1.4.99.1-0ubuntu2.2
 udev: 175-0ubuntu9.4
 xkb-data: 2.5-1ubuntu1.3
 xkb-data-i18n: 2.5-1ubuntu1.3

Of course the affected Precise system is up to date as of today.

Revision history for this message
Sebastien Bacher (seb128) wrote :

James, Ara, can you help verifying that one?

Revision history for this message
James M. Leddy (jm-leddy) wrote :

I have verified by compile testing a version of g-s-d that uses XF86AudioMicMute.

tags: added: verification-done
removed: verification-needed
Revision history for this message
James M. Leddy (jm-leddy) wrote :

Sebastien,

Thanks for flipping the tag. As noted in comment #108 , we still need backports of udev, gnome-settings-daemon, and xkeyboard-config to close this bug out. Additionally, this requires a revert of xkeyboard-config that we have in -proposed. I'm not sure how to work that because this is my first verification-failed bug, but I assume I can just revert it.

https://code.launchpad.net/~jm-leddy/ubuntu/precise/xkeyboard-config/micmute

We have two vendors in addition to Lenovo that have added micmute keys since this bug has been opened, and we're shipping 12.04 as the standard for all oem builds. So this bug has a higher priority now.

Revision history for this message
Sebastien Bacher (seb128) wrote :

@James:

right, we still need to change other components, I've tagged the verification-done because the only piece up for verification at the moment is libx11 and you verified that one, getting it in updates would put us one step closer from fixing the issue right?

> Additionally, this requires a revert of xkeyboard-config that we have in -proposed. I'm not sure how to work that because this is my first verification-failed bug, but I assume I can just revert it.

Do you need revert or extra changes? in any case the update is in precise-updates so you can't verification-failed it anymore (that's just used to get things dropped from proposed/not copied to updates), you need another upload on top of the current version

Revision history for this message
James M. Leddy (jm-leddy) wrote :

> right, we still need to change other components, I've tagged the verification-done because the only piece up for verification at the moment is libx11 and you verified that one, getting it in updates would put us one step closer from fixing the issue right?

This is exactly right.

>> Additionally, this requires a revert of xkeyboard-config that we have in -proposed. I'm not sure how to work that because this is my first verification-failed bug, but I assume I can just revert it.
>
> Do you need revert or extra changes? in any case the update is in precise-updates so you can't verification-failed it anymore (that's just used to get things dropped from proposed/not copied to updates), you need another upload on top of the current version

This is in relation to bug #937822. Since that bug is verification-failed, we pulled the update of xkeyboard-config from the -proposed archive. But it's still living out in the launchpad bzr code archive. So specifically, my question is whether I should branch from the -updates lp archive or the -proposed lp archive (and pull the patch, as I have have done). I've ran into this situation before in bug 1011073 but cyphermox solved it for me. Sorry if this is too much minutia.

https://code.launchpad.net/~ubuntu-branches/ubuntu/precise/xkeyboard-config/precise-updates
https://code.launchpad.net/~ubuntu-branches/ubuntu/precise/xkeyboard-config/precise-proposed

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libx11 - 2:1.4.99.1-0ubuntu2.2

---------------
libx11 (2:1.4.99.1-0ubuntu2.2) precise; urgency=low

  * Rebuild against SRUed x11-proto-core (LP: #408903)
 -- Iain Lane <email address hidden> Mon, 22 Jul 2013 11:09:59 +0100

Changed in libx11 (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
James M. Leddy (jm-leddy) wrote :

Fixed released as in bug 1193147.

Changed in udev (Ubuntu Precise):
status: New → Fix Released
Revision history for this message
James M. Leddy (jm-leddy) wrote :

Subscribed sponsors and submitted the remaining packages for merge requests.

Revision history for this message
Thomas Hood (jdthood) wrote :

I see that a lot of work has been done to get this change into precise, but it is not clear to me what the status of this change is for raring and saucy.

Revision history for this message
James M. Leddy (jm-leddy) wrote :

I've confirmed that these two branches work on a machine with the micmute button.

Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Stéphane Graber (stgraber) wrote :

Hello Christopher, or anyone else affected,

Accepted gnome-settings-daemon into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.4.2-0ubuntu0.6.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-settings-daemon (Ubuntu Precise):
status: New → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
Changed in xkeyboard-config (Ubuntu Precise):
status: New → Fix Committed
Revision history for this message
Stéphane Graber (stgraber) wrote :

Hello Christopher, or anyone else affected,

Accepted xkeyboard-config into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/xkeyboard-config/2.5-1ubuntu1.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Sebastien Bacher (seb128) wrote :

Bug #1248368 was reported as new issue due to the g-s-d change (osd feedback on sound keys not working after update), setting the bug as verification-failed

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Tormod Volden (tormodvolden) wrote :

Verified on a T410 with Ubuntu 12.04.3: After installing gnome-settings-daemon 3.4.2-0ubuntu0.6.5 and xkb-data 2.5-1ubuntu1.5 from precise-proposed the Mic Mute button actually toggles mic mute. However, the LED still does not light up.

Revision history for this message
Edle8 (edle8) wrote :

The same problem in the ThinkPad L530 with Ubuntu 13.10.

Revision history for this message
Ray Chen (ray.chen) wrote :

Verified on Lenovo E431 and E531, can not reproduce this issue.

ii gnome-settings-daemon 3.4.2-0ubuntu0.6.5 daemon handling the GNOME session settings
ii xkb-data 2.5-1ubuntu1.5 X Keyboard Extension (XKB) configuration data

tags: added: verification-done
removed: verification-failed
Revision history for this message
Brian Murray (brian-murray) wrote :

The verification for this bug should still be failed due to the regression introduced and documented in bug 1248368.

tags: added: verification-failed
removed: verification-done
Revision history for this message
Brian Murray (brian-murray) wrote :

The reporter of bug 1248368 indicates they are no longer having the regression they reported, so I'm setting this back to verification-done.

tags: added: verification-done
removed: verification-failed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.4.2-0ubuntu0.6.5

---------------
gnome-settings-daemon (3.4.2-0ubuntu0.6.5) precise; urgency=low

  * debian/patches/64_micmute.patch:
    - put the mic mute key used on thinkpad laptops to good use
      (lp: #408903)
 -- James M Leddy <email address hidden> Sat, 01 Jun 2013 10:01:49 -0400

Changed in gnome-settings-daemon (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Ilya G. Ryabinkin (ileyka) wrote :

I didn't get what this update is doing. My mic.mute still doesn't work -- when I'm pressing it nothing happening, even the button LED does not lit up.

Lenovo x220 4286CTO

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xkeyboard-config - 2.5-1ubuntu1.5

---------------
xkeyboard-config (2.5-1ubuntu1.5) precise-proposed; urgency=low

  * Revert last commit due to a SRU verification failure.
  * Add patch 115_add_XF86AudioMicMute.patch. This maps F20 to the new
    XF86AudioMicMute keysym. Cherrypick from upstream. (LP: #408903)
 -- James M Leddy <email address hidden> Fri, 31 May 2013 15:39:35 -0400

Changed in xkeyboard-config (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Ilya G. Ryabinkin (ileyka) wrote :

After today's update and rebooting a microphone mute button is now working for me! Thanks.

Revision history for this message
Christian Dysthe (christian-dysthe) wrote :

I just installed Ubuntu 14.04 Beta 1 and the microphone mute button stopped working. Just to make sure I ran Manjaro Live and it works there.

Revision history for this message
Marius Gedminas (mgedmin) wrote :

Trusty has gnome-settings-daemon 3.8.6. Support for XF86AudioMicMute was added in gnome-settings-daemon 3.9.2:
https://github.com/GNOME/gnome-settings-daemon/commit/3a8beaaf380a483ce33363031d8d276c371d7af1

I believe gnome-settings-daemon (and unity-settings-daemon) need to backport that patch for XF86AudioMicMute support.

Ara Pulido (ara)
Changed in oem-priority:
status: Triaged → Won't Fix
Revision history for this message
Marius Gedminas (mgedmin) wrote :

This was fixed in unity-settings-daemon 14.04.0+14.04.20140402-0ubuntu1.

It remains unfixed in gnome-settings-daemon.

no longer affects: gnome-settings-daemon (Ubuntu Raring)
no longer affects: libx11 (Ubuntu Raring)
no longer affects: udev (Ubuntu Raring)
no longer affects: xkeyboard-config (Ubuntu Raring)
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

Regarding xfce4-volumed please submit any patch upstream (see https://bugs.launchpad.net/xfce4-volumed/+bug/1323030).

Revision history for this message
In , Martin Pitt (pitti) wrote :

Current kernels have KEY_MICMUTE==248, i. e. X.org should be perfectly able to recognize this. Apparently this was done in 2011 already.

Can we update xkeyboard-config to also recognize KEY_MICMUTE in addition to F20, so that it works with both kinds of udev/kernel keymaps for a while? After that version has been out in the wild for some time, we can mass-convert the udev keymaps to produce the proper KEY_MICMUTE instead of KEY_F20.

Revision history for this message
In , Bugzilla-x (bugzilla-x) wrote :

(In reply to comment #23)
> Current kernels have KEY_MICMUTE==248, i. e. X.org should be perfectly able
> to recognize this.

I'm not certain that's enough for X.org to be able to handle it. Any changes to this should go in another bug anyway.

Revision history for this message
In , James H. Cloos Jr. (cloos-jhcloos) wrote :

> Current kernels have KEY_MICMUTE==248, i. e. X.org should be
> perfectly able to recognize this. Apparently this was done in
> 2011 already.

248 is the first linux kernel value which X cannot handle.

The mapping is +8, so 248 ⟹ 256, which does not fix in 8 bits.

(The first 8 are reserved – from way back – for the modifiers.)

Revision history for this message
In , Bugzilla-x (bugzilla-x) wrote :

(In reply to comment #25)
> > Current kernels have KEY_MICMUTE==248, i. e. X.org should be
> > perfectly able to recognize this. Apparently this was done in
> > 2011 already.
>
> 248 is the first linux kernel value which X cannot handle.
>
> The mapping is +8, so 248 ⟹ 256, which does not fix in 8 bits.
>
> (The first 8 are reserved – from way back – for the modifiers.)

So nothing to change until we're all using Wayland.

Revision history for this message
In , Martin Pitt (pitti) wrote :

Ah, thanks for the heads-up!

Revision history for this message
Dave Gilbert (ubuntu-treblig) wrote :

Comment #19 https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1248368 is showing a regressing caused by this fix.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

raring has seen the end of its life and is no longer receiving any updates. Marking the raring task for this ticket as "Won't Fix".

Changed in x11proto-core (Ubuntu Raring):
status: New → Won't Fix
Mathew Hodson (mhodson)
Changed in gnome-settings-daemon (Ubuntu):
status: Triaged → Fix Released
Changed in libx11 (Ubuntu):
status: Confirmed → Fix Released
Changed in x11proto-core (Ubuntu):
status: New → Fix Released
Changed in xkeyboard-config (Ubuntu):
status: New → Fix Released
no longer affects: xserver-xorg-input-evdev (Ubuntu)
no longer affects: xserver-xorg-input-evdev (Ubuntu Precise)
no longer affects: xserver-xorg-input-evdev (Ubuntu Raring)
no longer affects: x11proto-core (Ubuntu Raring)
Mathew Hodson (mhodson)
no longer affects: xfce4-volumed (Ubuntu)
no longer affects: xfce4-volumed (Ubuntu Precise)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.