Ubuntu
libwnck3 package

Add support for WM_CLASS instance getter API

Bug #800946 reported by Marco Trevisan (Treviño) on 2011-06-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	libwnck	Fix Released	Medium	gnome-bugs #168718
	libwnck3 (Ubuntu)	Fix Released	Wishlist	Marco Trevisan (Treviño)

Bug Description

BAMF and other projects needs to retrieve the WM_CLASS instance for a window, and this is not possible now using libwnck (they would need to use Xlib directly, and this is a waste). See bug #702452 for example.

Applying this patch will fix it.

This patch is requested for merge in upstream too [1].

[1] https://bugzilla.gnome.org/show_bug.cgi?id=168718#c5

Tags:

Related branches

lp:~3v1n0/ubuntu/oneiric/libwnck/fix-800946

Rejected for merging into lp:~ubuntu-desktop/libwnck/ubuntu

Marco Trevisan (Treviño): Abstain on 2011-07-30

Michael Vogt: Needs Fixing on 2011-07-29

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-06-23:

Added APIs for getting WM_CLASS name and instance for a wnkWindow Edit (5.3 KiB, text/plain)

Changed in libwnck (Ubuntu):
status:	New → In Progress
assignee:	nobody → Treviño (Marco Trevisan) (3v1n0)

Marco Trevisan (Treviño) (3v1n0) on 2011-06-23

Changed in libwnck (Ubuntu):
status:	In Progress → Fix Committed

Bug Watch Updater (bug-watch-updater) on 2011-06-23

Changed in libwnck:
importance:	Unknown → Medium
status:	Unknown → New

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-06-23:

thank you for your work, don't bug ubuntu bugs to fix commited when the fix is not commited upstream nor to the packaging vcs though

Changed in libwnck (Ubuntu):
status:	Fix Committed → Triaged
importance:	Undecided → Wishlist

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-06-23:

note that the correct vcs is lp:~ubuntu-desktop/libwnck/ubuntu, we should also wait for an upstream review rather than adding an api in a distro specific way

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-06-23:

Sorry, I've fixed that... And yes, I do agree that upstream should agree with this, also if I've not heard something from them since when I've posted something in bugzilla.
However this feature would be needed by projects like BAMF, also if in the mid-time I could implement this duplicating the code (it's not that much, BTW) in BAMF itself...

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-06-28:

Upstream is still not responding... I guess I'd go for a duplicated implementation...

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-06-29:

Vincent said yesterday that it was on his todolist and that he will review it in the coming week

Sebastien Bacher (seb128) on 2011-07-04

tags:

added: patch-forwarded-upstream
removed: patch

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2011-07-13:

First review has been done [1], it seems fine, but I'm waiting for the final decision about the naming of these APIs.

[1] https://bugzilla.gnome.org/review?bug=168718&attachment=190480

Bug Watch Updater (bug-watch-updater) on 2011-08-12

Changed in libwnck:
status:	New → Fix Released

Sebastien Bacher (seb128) on 2011-08-17

Changed in libwnck (Ubuntu):
status:	Triaged → Fix Committed
affects:	libwnck (Ubuntu) → libwnck3 (Ubuntu)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-08-17:

This bug was fixed in the package libwnck3 - 3.1.5-0ubuntu1

---------------
libwnck3 (3.1.5-0ubuntu1) oneiric; urgency=low

  * New upstream version with a new api to get WM_CLASS group name & instance
    name of a WnckWindow, thanks Marco Trevisan (lp: #800946)
  * libwnck-3-0.symbols: updated stymbols
  * debian/rules: use --enable-static
-- Sebastien Bacher <email address hidden> Wed, 17 Aug 2011 17:19:58 +0200