Add support for WM_CLASS instance getter API

Bug #800946 reported by Marco Trevisan (Treviño) on 2011-06-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libwnck
Fix Released
Medium
libwnck3 (Ubuntu)
Wishlist
Marco Trevisan (Treviño)

Bug Description

BAMF and other projects needs to retrieve the WM_CLASS instance for a window, and this is not possible now using libwnck (they would need to use Xlib directly, and this is a waste). See bug #702452 for example.

Applying this patch will fix it.

This patch is requested for merge in upstream too [1].

[1] https://bugzilla.gnome.org/show_bug.cgi?id=168718#c5

Related branches

Changed in libwnck (Ubuntu):
status: New → In Progress
assignee: nobody → Treviño (Marco Trevisan) (3v1n0)
Changed in libwnck (Ubuntu):
status: In Progress → Fix Committed
Changed in libwnck:
importance: Unknown → Medium
status: Unknown → New
Sebastien Bacher (seb128) wrote :

thank you for your work, don't bug ubuntu bugs to fix commited when the fix is not commited upstream nor to the packaging vcs though

Changed in libwnck (Ubuntu):
status: Fix Committed → Triaged
importance: Undecided → Wishlist
Sebastien Bacher (seb128) wrote :

note that the correct vcs is lp:~ubuntu-desktop/libwnck/ubuntu, we should also wait for an upstream review rather than adding an api in a distro specific way

Sorry, I've fixed that... And yes, I do agree that upstream should agree with this, also if I've not heard something from them since when I've posted something in bugzilla.
However this feature would be needed by projects like BAMF, also if in the mid-time I could implement this duplicating the code (it's not that much, BTW) in BAMF itself...

Upstream is still not responding... I guess I'd go for a duplicated implementation...

Sebastien Bacher (seb128) wrote :

Vincent said yesterday that it was on his todolist and that he will review it in the coming week

tags: added: patch-forwarded-upstream
removed: patch

First review has been done [1], it seems fine, but I'm waiting for the final decision about the naming of these APIs.

[1] https://bugzilla.gnome.org/review?bug=168718&attachment=190480

Changed in libwnck:
status: New → Fix Released
Changed in libwnck (Ubuntu):
status: Triaged → Fix Committed
affects: libwnck (Ubuntu) → libwnck3 (Ubuntu)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libwnck3 - 3.1.5-0ubuntu1

---------------
libwnck3 (3.1.5-0ubuntu1) oneiric; urgency=low

  * New upstream version with a new api to get WM_CLASS group name & instance
    name of a WnckWindow, thanks Marco Trevisan (lp: #800946)
  * libwnck-3-0.symbols: updated stymbols
  * debian/rules: use --enable-static
 -- Sebastien Bacher <email address hidden> Wed, 17 Aug 2011 17:19:58 +0200

Changed in libwnck3 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.