[SRU] virtlogd not rotating logs properly

[David Negreira]

[Impact]

 When one enables max_age_days on /etc/libvirt/virtlogd.conf, for example by setting it to max_age_days = 1, the log files are not rotated correctly and we see this error on virtlogd:

[Test Case]

1) Launch a couple of dummy VMs to ensure that there are some logs in /var/log/libvirt
2) Edit /etc/libvirt/virtlogd.conf and ensure that the max_age_days setting is uncommented as per the following:
   max_age_days = 1
3) sudo systemctl restart virtlogd
4) Wait 24 hours. (There is no way to accelerate the timer unless one edits the source code)
5) Verify that logs are cleaned up and there are no errors in syslog or virtlogd journal like the following:
   Feb 28 08:58:57 dixie virtlogd[7205]: internal error: Failed to parse rotated index from ''

[Where problems could occur]

There could be some issues with virtlogd, but the code path only executes when max_age_days is different than 0.
 In the event of a regression, one could disable the setting by commenting max_age_days.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp2072647-libvirt.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]