Activity log for bug #1823676

Date Who What changed Old value New value Message
2019-04-08 09:19:28 bugproxy bug added bug
2019-04-08 09:19:30 bugproxy tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin---
2019-04-08 09:19:53 bugproxy attachment added sosreport on host https://bugs.launchpad.net/bugs/1823676/+attachment/5254039/+files/sosreport-ltcgen6-20190328061103.tar.xz
2019-04-08 09:19:55 bugproxy ubuntu: assignee Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
2019-04-08 09:19:57 bugproxy affects ubuntu libvirt (Ubuntu)
2019-04-08 09:46:53 Frank Heimes bug task added ubuntu-power-systems
2019-04-08 09:47:06 Frank Heimes ubuntu-power-systems: importance Undecided Medium
2019-04-08 09:47:18 Frank Heimes ubuntu-power-systems: assignee Canonical Server Team (canonical-server)
2019-04-08 13:41:25 Manoj Iyer ubuntu-power-systems: status New Won't Fix
2019-04-08 13:41:30 Manoj Iyer libvirt (Ubuntu): status New Won't Fix
2019-04-08 13:42:18 Frank Heimes ubuntu-power-systems: status Won't Fix Invalid
2019-04-08 14:36:37 bugproxy attachment added preview patch https://bugs.launchpad.net/bugs/1823676/+attachment/5254165/+files/0001-qemu-Use-the-correct-vm-def-on-cold-attach.patch
2019-04-08 15:31:24 Frank Heimes ubuntu-power-systems: status Invalid Triaged
2019-04-10 12:20:39 Christian Ehrhardt  nominated for series Ubuntu Bionic
2019-04-10 12:20:39 Christian Ehrhardt  bug task added libvirt (Ubuntu Bionic)
2019-04-10 12:20:39 Christian Ehrhardt  nominated for series Ubuntu Cosmic
2019-04-10 12:20:39 Christian Ehrhardt  bug task added libvirt (Ubuntu Cosmic)
2019-04-10 12:39:25 Christian Ehrhardt  libvirt (Ubuntu): status Won't Fix Fix Released
2019-04-10 12:39:27 Christian Ehrhardt  libvirt (Ubuntu Cosmic): status New Fix Released
2019-04-10 12:39:30 Christian Ehrhardt  libvirt (Ubuntu Bionic): status New Triaged
2019-04-10 13:27:24 Christian Ehrhardt  description == Comment: #0 - SRIKANTH AITHAL - 2019-03-28 05:10:54 == ---Problem Description--- Failed to attach scsi contr. with opt. "--config --live" when index attribute isn't specified in XML ---Steps to Reproduce--- 1. Use below guest: # virsh list Id Name State ---------------------------------------------------- 11 srik_ubuntu running 2.Use below xml for controller attach # cat /home/srikanth/controller_scsi.xml <controller type='scsi' model='virtio-scsi' /> 3. Check for any previous controllers attached: # virsh dumpxml srik_ubuntu | grep controller.*scsi 4.Issue with persistent hot-attach: # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --persistent error: Failed to attach device from /home/***/controller_scsi.xml error: internal error: Cannot parse controller index -1 5.Issue with persistent live-config: # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --live --config error: Failed to attach device from /home/***/controller_scsi.xml error: internal error: Cannot parse controller index -1 6. Where as index is getting auto generated for live attach, as well as config attach # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --live Device attached successfully # virsh dumpxml test_vm1 | grep controller.*scsi <controller type='scsi' index='0' model='virtio-scsi'> Expected result: From Libvirt >=1.3.5 all attach varients of hot controller attach should generate the controller index automatically if not given explicitly. Machine Type = witherspoon ---uname output--- Linux ltcgen6 4.15.0-1017.19-bz175922-ibm-gt #bz175922 SMP Thu Mar 21 09:34:09 CDT 2019 ppc64le ppc64le ppc64le GNU/Linux ---Debugger--- A debugger is not configured Userspace tool common name: libvirt-bin 4.0.0-1ubuntu8.6 The userspace tool has the following bit modes: 64 Userspace rpm: libvirt-bin [Impact] * Libvirt has a concept of a live and a persistent config. The code was so far workign on a copy due to that the handling of device attach that caused some issues as some functions e.g. the scsi attach here - rely on knowing data from the other live content. * This was fixed upstream to use the correct definition in those cases and by effectively splitting the definitions used for checks/code in CONFIG/LIVE cases. [Test Case] * Simplified, but complete test steps (working on a fresh Bionic x86 host): $ sudo apt install uvtool-libvirt $ time uvt-simplestreams-libvirt --verbose sync --source http://cloud-images.ubuntu.com/daily arch=amd64 label=daily release=bionic $ ssh-keygen $ uvt-kvm create --password ubuntu b-testattach arch=amd64 release=bionic label=daily $ virsh dumpxml b-testattach | grep controller.*scsi # will show no output - ok $ echo "<controller type='scsi' model='virtio-scsi' />" > controller_scsi.xml # check persistent and live config $ virsh attach-device b-testattach controller_scsi.xml --persistent error: Failed to attach device from controller_scsi.xml error: internal error: Cannot parse controller index -1 $ virsh attach-device b-testattach controller_scsi.xml --live --config error: Failed to attach device from controller_scsi.xml error: internal error: Cannot parse controller index -1 With the fix those attaches should work just fine. [Regression Potential] * The changes are local to attaching devices, no other functionality should be affected. If anything then e.g. due to backporting we could have introduced issues there - I'll take a look at testing the case and some other attach/detach in general to be sure. [Other Info] * n/a --- == Comment: #0 - SRIKANTH AITHAL - 2019-03-28 05:10:54 == ---Problem Description--- Failed to attach scsi contr. with opt. "--config --live" when index attribute isn't specified in XML ---Steps to Reproduce---  1. Use below guest: # virsh list  Id Name State ----------------------------------------------------  11 srik_ubuntu running 2.Use below xml for controller attach # cat /home/srikanth/controller_scsi.xml <controller type='scsi' model='virtio-scsi' /> 3. Check for any previous controllers attached: # virsh dumpxml srik_ubuntu | grep controller.*scsi 4.Issue with persistent hot-attach: # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --persistent error: Failed to attach device from /home/***/controller_scsi.xml error: internal error: Cannot parse controller index -1 5.Issue with persistent live-config: # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --live --config error: Failed to attach device from /home/***/controller_scsi.xml error: internal error: Cannot parse controller index -1 6. Where as index is getting auto generated for live attach, as well as config attach # virsh attach-device srik_ubuntu /home/***/controller_scsi.xml --live Device attached successfully # virsh dumpxml test_vm1 | grep controller.*scsi     <controller type='scsi' index='0' model='virtio-scsi'> Expected result: From Libvirt >=1.3.5 all attach varients of hot controller attach should generate the controller index automatically if not given explicitly. Machine Type = witherspoon ---uname output--- Linux ltcgen6 4.15.0-1017.19-bz175922-ibm-gt #bz175922 SMP Thu Mar 21 09:34:09 CDT 2019 ppc64le ppc64le ppc64le GNU/Linux ---Debugger--- A debugger is not configured Userspace tool common name: libvirt-bin 4.0.0-1ubuntu8.6 The userspace tool has the following bit modes: 64 Userspace rpm: libvirt-bin
2019-04-10 14:00:56 bugproxy attachment added updated patch. https://bugs.launchpad.net/bugs/1823676/+attachment/5254689/+files/0001-qemu-Use-the-correct-vm-def-on-cold-attach.patch
2019-04-12 14:30:26 bugproxy tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin--- architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041
2019-04-22 19:22:31 bugproxy tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041 architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18042
2019-04-22 19:23:00 bugproxy tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18042 architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041
2019-04-24 18:21:38 bugproxy tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041 architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041genesis2
2019-04-30 16:59:23 Brian Murray libvirt (Ubuntu Bionic): status Triaged Fix Committed
2019-04-30 16:59:28 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2019-04-30 16:59:30 Brian Murray bug added subscriber SRU Verification
2019-04-30 16:59:34 Brian Murray tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041genesis2 architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041genesis2 verification-needed verification-needed-bionic
2019-04-30 17:16:09 Andrew Cloke ubuntu-power-systems: status Triaged Fix Committed
2019-05-03 07:44:16 Christian Ehrhardt  tags architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041genesis2 verification-needed verification-needed-bionic architecture-ppc64le bugnameltc-176452 severity-medium targetmilestone-inin18041genesis2 verification-done verification-done-bionic
2019-05-07 19:03:59 Launchpad Janitor libvirt (Ubuntu Bionic): status Fix Committed Fix Released
2019-05-07 19:04:10 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2019-05-07 19:11:38 Frank Heimes ubuntu-power-systems: status Fix Committed Fix Released