virt-aa-helper to learn about VF devspec paths
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libvirt (Ubuntu) |
Expired
|
Wishlist
|
Unassigned |
Bug Description
When on ppc64el attaching a Virtual function there is an error seen in dmesg.
[ 1124.853295] audit: type=1400 audit(149146878
This seems to be multiple levels of wrong, but good messages first - it is non Fatal for the cases I've seen so far.
On ppc when attaching virtual functions it passes the function spapr_phb_
In there is the offending call:
g_strdup_
Host here is the pci device that is about to be attached.
I'm 98% convinced that even if would passing that the following call is broken then still.
g_strdup_
IMHO should be
g_strdup_
Assuming the likely bug above would be fixed along the commit the one fixing it should also extend virt-aa-helper.c to generate entries for the two paths that will be accessed:
So overall three todos:
1. fix device-tree path string
2. add device tree path to virt-aa-helper
3. add loc-code path to virt-aa-helper
Once that is upstream I'm happy to pick and backport if applicable.
So far this is non fatal since spapr_phb_
And IMHO - due to the latter issue even without the apparmor block so far always the fallback code is used. If that is true and really working everywhere one might consider dropping all the logic and only leaving the fallback?
tags: |
added: targetmilestone-inin1710 removed: targetmilestone-inin1704 |
------- Comment From <email address hidden> 2017-04-13 21:09 EDT-------
Please, reverse mirror LP1680386 (virt-aa-helper to learn about VF devspec paths).