Crash when removing <filterref> from interface with update-device

[Mohammed Naser]

===================================================
SRU Justification
1. Impact: crash when removing filterref from a network interface
2. Test case: Create an interface with filterref (see below), then update it and try to remove it.
3. Regression potential: the patch simply avoids attempting to instantiate a filter if the filter has been removed. There should be no regressions.
===================================================

Hello,

We're running into this issue on our 14.04 LTS hosts, when removing all filterref's on an interface, it results in a crash.

# virsh dump-xml e7276b62-887f-443e-b85b-ea3b5c395924
.....
<interface type='bridge'>
  <mac address='fa:16:3e:1c:cf:99'/>
  <source bridge='qbr3f490a54-72'/>
  <target dev='tap3f490a54-72'/>
  <model type='virtio'/>
  <filterref filter='illuminate-smtp-block'/>
  <alias name='net0'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>
....

Update attempt
# cat interface.xml
<interface type="bridge">
  <mac address="fa:16:3e:1c:cf:99"/>
  <source bridge="qbr3f490a54-72"/>
  <target dev="tap3f490a54-72"/>
  <model type="virtio"/>
  <alias name="net0"/>
  <address type="pci" domain="0x0000" bus="0x00" slot="0x03" function="0x0"/>
</interface>
# virsh update-device e7276b62-887f-443e-b85b-ea3b5c395924 interface.xml
.. libvirtd segfaults!

There is an existing patch for this which addresses this issue, but it seems that it's not backported into current sources.

http://www.redhat.com/archives/libvir-list/2014-May/msg00005.html

[Serge Hallyn (serge-hallyn)]

Hi,

given the date of that patch, could you confirm that this is fixed in 15.04?

If so then I'll SRU this to trusty

[Mohammed Naser (mnaser)]

I will check it out and let you know.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "qemu-filterref-crash.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Mohammed Naser (mnaser)]

Hi,

Tested in 15.04, fixed and working properly.

Thanks,
Mohammed

[Serge Hallyn (serge-hallyn)]

Thank you, I'll SRU the patch.

[Chris J Arges (arges)]

Hello Mohammed, or anyone else affected,

Accepted libvirt into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.2.2-0ubuntu13.1.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Mohammed Naser (mnaser)]

Seems to have addressed the issue. :)

[Chris J Arges (arges)]

Hello Mohammed, or anyone else affected,

Accepted libvirt into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.2.2-0ubuntu13.1.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Timo Aaltonen (tjaalton)]

fixed the tag, this was verified already

[Launchpad Janitor (janitor)]

This bug was fixed in the package libvirt - 1.2.2-0ubuntu13.1.12

---------------
libvirt (1.2.2-0ubuntu13.1.12) trusty-proposed; urgency=medium

  * Drop Support-incoming-migration-from-13.10-hosts.patch as it failed
    verification.

libvirt (1.2.2-0ubuntu13.1.11) trusty-proposed; urgency=medium

  * Support-incoming-migration-from-13.10-hosts.patch (LP: #1425619)
  * qemu-filterref-crash.patch: fix crash when removing filterref from
    interfaces (LP: #1448205)
  * storage_backend_rbd-correct-arg-order-to-rbd_create3: fix reversed
    arguments to rbd_create3. (LP: #1447030)

 -- Serge Hallyn <email address hidden> Thu, 18 Jun 2015 14:21:06 -0500

[Chris J Arges (arges)]

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.