remove the deprecation warning about /etc/default/libvirt-bin in libvirt's upstart job

Bug #1280936 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Triaged
Low
Unassigned

Bug Description

In the upstart job it says:

# /etc/default/libvirt-bin will be deprecated soon.
# If you used to set $libvirtd_opts in /etc/default/libvirt-bin,
# change the 'exec' line here instead.
script
        [ -r /etc/default/libvirt-bin ] && . /etc/default/libvirt-bin
        exec /usr/sbin/libvirtd $libvirtd_opts
end script

But, this as it stands doesn't work - I changed /e/default/libvirt-bin to add -l to the libvirtd daemon flags, and it had no effect, when I altered the libvirt-bin.conf upstart job and did the same to the env line near the top it worked.

The bug is the claim that the old, simple, unconflated style is deprecated: its broken. I think it would be better to either keep supporting it (please!) or not claim that its deprecated when (at least AFAICT) its broken.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote : Re: [Bug 1280936] [NEW] /etc/default/libvirt-bin does not affect libvirt's upstart job

Hi Robert,

I'm sorry you're having trouble. However, the upstart job still does

        [ -r /etc/default/libvirt-bin ] && . /etc/default/libvirt-bin

at the top of each stanza, so it is certainly intended that the
libvirtd_opts from that file still be respected.

Could you please attach your /etc/init/libvirt-bin.conf and
/etc/default/libvirt-bin files here?

 status: incomplete

Changed in libvirt (Ubuntu):
status: New → Incomplete
Revision history for this message
Robert Collins (lifeless) wrote : Re: /etc/default/libvirt-bin does not affect libvirt's upstart job

Yeah, thanks - I just rechecked and found operator error. Mea culpa and sorry for the used [human] bandwidth looking at this.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks for the update. Mind you I think sentiments have changed and I think that
warning msg should be removed.

Changed in libvirt (Ubuntu):
importance: Undecided → Low
status: Incomplete → Triaged
summary: - /etc/default/libvirt-bin does not affect libvirt's upstart job
+ remove the deprecation warning about /etc/default/libvirt-bin in
+ libvirt's upstart job
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.