Activity log for bug #1190387

Date Who What changed Old value New value Message
2013-06-12 22:11:29 Bill Mills bug added bug
2013-06-13 08:11:28 Yolanda Robla libvirt (Ubuntu): importance Undecided Medium
2013-06-17 14:08:14 Serge Hallyn libvirt (Ubuntu): status New In Progress
2013-06-17 14:08:17 Serge Hallyn libvirt (Ubuntu): assignee Serge Hallyn (serge-hallyn)
2013-06-17 14:43:46 Serge Hallyn nominated for series Ubuntu Precise
2013-06-17 14:43:46 Serge Hallyn bug task added libvirt (Ubuntu Precise)
2013-06-17 14:44:03 Serge Hallyn libvirt (Ubuntu Precise): status New In Progress
2013-06-17 14:44:06 Serge Hallyn libvirt (Ubuntu Precise): importance Undecided Medium
2013-06-17 14:44:09 Serge Hallyn libvirt (Ubuntu Precise): assignee Serge Hallyn (serge-hallyn)
2013-06-17 14:44:12 Serge Hallyn libvirt (Ubuntu): status In Progress Fix Released
2013-06-17 14:49:08 Serge Hallyn description Running Ubuntu 12.04 x86_64 libvirt0 and libvirt-bin 0.9.8-2ubuntu17.8 causes a regression. I am using QEMU/KVM virtual machines. To reproduce: use virsh to create/start a vm use virsh to attach-device a host usb device use virsh to stop/destroy the vm use virsh to create vm again use virsh to attach the usb device again I get: virsh attach-device vm1 /var/lib/libvirt/hotplug/usb-serial.xml error: Failed to attach device from /var/lib/libvirt/hotplug/usb-serial.xml error: Requested operation is not valid: USB device 002:005 is in use by domain .. Note the ".." characters. That is literal. It is printing garbage characters. The failure is not 100% of the time but is pretty high (50% ?) usb-serial.xml: <hostdev mode='subsystem' type='usb' managed='yes'> <source> <vendor id='0x067b'/> <product id='0x2303'/> </source> </hostdev> backing up libvirt0 and libvirt-bin to 0.9.8-2ubuntu17.7 makes this problem go away. While looking at this I found a Fedora bug that looks similar. The upstream patches they identified may be of interest. https://bugzilla.redhat.com/show_bug.cgi?id=814866 ================================= SRU Justification 1. Impact: cannot attach host usb device to domain 2 after attaching it to domain 1 and shutting down domain 1. 2. Development fix: Reattach usb device to host when domain shuts down 3. Stable fix: same as development fix backport of upstream patch. 4. test case: To test inside a precise kvm guest, 1. create a nested libvirt domain as per https://wiki.ubuntu.com/SergeHallyn_libvirtnest 2. Create usb.xml file containing: <hostdev mode='subsystem' type='usb' managed='yes'> <source> <vendor id='0x1d6b'/> <product id='0x0001'/> </source> </hostdev> 3. start cdboot, and attach the device to it virsh start cdboot virsh attach-device cdboot usb.xml 4. stop cdboot, restart it, and try to attach the device again virsh destroy cdboot virsh start cdboot virsh attach-device cdboot usb.xml Without this fix, the second attach-device will fail. 5. Regression potential: This adds new code to the domain shutdown and libvirt start sequences. However they only affect the list of usb devices, so any regressions should be caught at usb device add/remove and libvirtd start/stop. ================================= Running Ubuntu 12.04 x86_64 libvirt0 and libvirt-bin 0.9.8-2ubuntu17.8 causes a regression. I am using QEMU/KVM virtual machines. To reproduce:    use virsh to create/start a vm    use virsh to attach-device a host usb device    use virsh to stop/destroy the vm    use virsh to create vm again    use virsh to attach the usb device again I get: virsh attach-device vm1 /var/lib/libvirt/hotplug/usb-serial.xml error: Failed to attach device from /var/lib/libvirt/hotplug/usb-serial.xml error: Requested operation is not valid: USB device 002:005 is in use by domain .. Note the ".." characters. That is literal. It is printing garbage characters. The failure is not 100% of the time but is pretty high (50% ?) usb-serial.xml:     <hostdev mode='subsystem' type='usb' managed='yes'>       <source>         <vendor id='0x067b'/>         <product id='0x2303'/>       </source>     </hostdev> backing up libvirt0 and libvirt-bin to 0.9.8-2ubuntu17.7 makes this problem go away. While looking at this I found a Fedora bug that looks similar. The upstream patches they identified may be of interest. https://bugzilla.redhat.com/show_bug.cgi?id=814866
2013-06-17 16:39:15 Serge Hallyn attachment added libvirt-usbreattach.debdiff https://bugs.launchpad.net/bugs/1190387/+attachment/3705831/+files/libvirt-usbreattach.debdiff
2013-10-11 13:19:35 Serge Hallyn bug added subscriber Ubuntu Stable Release Updates Team
2013-10-13 21:37:34 Dave Walker libvirt (Ubuntu Precise): status In Progress Fix Committed
2013-10-13 21:37:38 Dave Walker bug added subscriber SRU Verification
2013-10-13 21:37:41 Dave Walker tags verification-needed
2013-11-11 19:53:05 Serge Hallyn tags verification-needed verification-done
2013-11-12 11:37:02 Launchpad Janitor libvirt (Ubuntu Precise): status Fix Committed Fix Released
2013-11-12 11:37:32 Colin Watson removed subscriber Ubuntu Stable Release Updates Team