"1 songs played today" is not grammatically correct

[James Hunt]

If I play a single song in the music app, the welcome shows "1 songs played today". This is not grammatically correct.

Here's the relevant chunk from the music-app.qml:

Metric {
    id: songsMetric
    name: "music-metrics"
    format: "<b>%1</b> " + i18n.tr("songs played today")
    emptyFormat: i18n.tr("No songs played today")
    domain: "com.ubuntu.music"
}

FWICS, it looks like the problem is due to a limitation of libusermetrics. If so, two possible solutions come to mind:

1) Extending libusermetrics to allow the specification of a "singleFormat:" which in this case would be:

    singleFormat: "<b>%1</b> " + i18n.tr("song played today") // It's now "song", not "songs"

2) Having some JS construct the format dynamically based on the value somehow? The problem there being that every app that wanted to get this right would need to implement the JS.

[Andrew Hayzen (ahayzen)]

Thank you for taking the time to report this bug and helping to make Ubuntu better.
I can confirm that when using the package music-app on ubuntu-touch using the steps provided by James that I can reproduce the bug. Therefore I have set this bug to confirmed.

I have see this with other apps and *thought* this was working for us at one point, however I have just noticed that the photos is now stated in the follow format.
"photos taken today: <b>%1</b>"

Which eliminates the issue.

[James Hunt (jamesodhunt)]

Hi Andrew,

Yes, that's the simplest fix of course. However, care is going to need to be taken to ensure all consumers of libusermetrics apply such a format.

I suggest we atleast review all the core apps since although this issue does not affect the functionality of the apps...

 - the issue is very prominent (you see the welcome screen whenever you switch on the screen)
 - using the original format creates a bad impression imho (atleast when the phone is set to language=English).

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.