libunity ftbfs in wily

[Barry Warsaw]

libunity seems to no longer be buildable in wily. This is a problem because it must be rebuilt for Python 3.5, but it is failing for unrelated reasons. Here's an excerpt of the build log from a local build using the current wily source package:

/usr/bin/glib-compile-resources --sourcedir . --target=unity-tool-res.c --generate-source unity-tool-res.gresource.xml
/usr/bin/valac -C --vapidir ../vapi --vapidir=../protocol --vapidir=../src --pkg config --pkg gtk+-3.0 --pkg gmodule-2.0 --pkg unity-internal --pkg unity-protocol --pkg glib-2.0 --pkg gmodule-2.0 --pkg gobject-2.0 --pkg gio-2.0 --pkg gio-unix-2.0 --pkg dee-1.0 --pkg Dbusmenu-0.4 unity-tool.vala unity-tool-dbus-util.vala unity-tool-ui.vala preview-renderer.vala music-track-model-renderer.vala
unity-tool-ui.vala:846.13-846.21: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    private ListStore uimodel = null;
            ^^^^^^^^^
unity-tool-ui.vala:847.13-847.21: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    private ListStore ui_filter_model = null;
            ^^^^^^^^^
unity-tool-ui.vala:848.13-848.21: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    private ListStore scope_list_model = null;
            ^^^^^^^^^
unity-tool-ui.vala:849.13-849.21: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    private ListStore ui_cat_model = null;
            ^^^^^^^^^
unity-tool-ui.vala:43.62-43.70: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
            uimodel = builder.get_object("results_model") as ListStore;
                                                             ^^^^^^^^^
unity-tool-ui.vala:44.70-44.78: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
            ui_filter_model = builder.get_object("filters_model") as ListStore;
                                                                     ^^^^^^^^^
unity-tool-ui.vala:45.70-45.78: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
            ui_cat_model = builder.get_object("categories_model") as ListStore;
                                                                     ^^^^^^^^^
unity-tool-ui.vala:158.74-158.82: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
            scope_list_model = builder.get_object("scope_list_model") as ListStore;
                                                                         ^^^^^^^^^
music-track-model-renderer.vala:30.12-30.20: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    public ListStore track_view_model { get; construct; }
           ^^^^^^^^^
music-track-model-renderer.vala:30.12-30.20: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    public ListStore track_view_model { get; construct; }
           ^^^^^^^^^
music-track-model-renderer.vala:30.12-30.20: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    public ListStore track_view_model { get; construct; }
           ^^^^^^^^^
music-track-model-renderer.vala:30.12-30.20: error: `ListStore' is an ambiguous reference between `GLib.ListStore' and `Gtk.ListStore'
    public ListStore track_view_model { get; construct; }
           ^^^^^^^^^
Compilation failed: 12 error(s), 0 warning(s)

Seems like the same problem in all cases, and I'm not sure which ListStore is intended. Full buildlog is available in the Python 3.5-as-default PPA:

https://launchpadlibrarian.net/216183170/buildlog_ubuntu-wily-amd64.libunity_7.1.4%2B14.10.20140808-0ubuntu1_BUILDING.txt.gz

This is blocking several other critical packages which need updating for Python 3.5.

[Barry Warsaw (barry)]

The attached patch gets past the compilation problems, but the test suite still fails:

TEST: test-vala... (pid=6684)
  /Unit/ResultsSynchronizer: OK
  /Unit/IO/AsyncDesktopFile: OK
  /Unit/IO/AsyncOpenFromDataDirs: OK
  /Unit/Utils/AsyncOnce: OK
  /Unit/Utils/AsyncMutex: OK
  /Unit/AppInfoManager/Allocation: OK
  /Unit/AppInfoManager/ClearEmpty: OK
  /Unit/AppInfoManager/SyncLookupMissing: OK
  /Unit/AppInfoManager/AsyncLookupMissing: OK
  /Unit/AppInfoManager/SyncLookupOk: OK
  /Unit/AppInfoManager/AsyncLookupOk: OK
  /Unit/Launcher/EmptyEntry:
(test-vala:6684): libunity-CRITICAL **: unity-launcher.vala:154: Unable to connect to session bus: Could not connect: Connection refused
FAIL
GTester: last random seed: R02Se7d86e8456c1108c7728e8e5ac335f5b
/bin/bash: line 1: 6683 Terminated G_DEBUG=gc-friendly MALLOC_CHECK_=2 MALLOC_PERTURB_=$((${RANDOM:-256} % 256)) gtester --verbose test-vala test-scope test-blacklist-crash test-extras
Makefile:1020: recipe for target 'test-nonrecursive' failed
make[6]: *** [test-nonrecursive] Error 143
make[6]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808/test/vala'
make[5]: *** [test-headless] Error 2
Makefile:1069: recipe for target 'test-headless' failed
make[5]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808/test/vala'
make[4]: *** [check-am] Error 2
Makefile:880: recipe for target 'check-am' failed
make[4]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808/test/vala'
make[3]: *** [check] Error 2
Makefile:883: recipe for target 'check' failed
make[3]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808/test/vala'
make[2]: *** [check-recursive] Error 1
Makefile:452: recipe for target 'check-recursive' failed
make[2]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808/test'
make[1]: *** [check-recursive] Error 1
Makefile:570: recipe for target 'check-recursive' failed
make[1]: Leaving directory '/«BUILDDIR»/libunity-7.1.4+14.10.20140808'
dh_auto_test: make -j1 check returned exit code 2
make: *** [build] Error 2
debian/rules:10: recipe for target 'build' failed
dpkg-buildpackage: error: debian/rules build gave error exit status 2

[Launchpad Janitor (janitor)]

This bug was fixed in the package libunity - 7.1.4+15.10.20150911-0ubuntu1

---------------
libunity (7.1.4+15.10.20150911-0ubuntu1) wily; urgency=medium

  * Tools: use proper type prefix to fix FTB (LP: #1491542)

 -- Marco Trevisan (Treviño) <[e-mail]> Fri, 11 Sep 2015 14:54:05 +0000

[Barry Warsaw (barry)]

Thanks for the fix! This unblocked several reverse-depends. :)