[SRU] Set default file_bigendian in struct tep_handle

Bug #2101149 reported by Pragyansh Chaturvedi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libtraceevent (Ubuntu)
In Progress
Medium
Pragyansh Chaturvedi
Noble
Fix Committed
Undecided
Unassigned
Oracular
Fix Committed
Undecided
Unassigned

Bug Description

[ Impact ]

 * This relates to https://bugs.launchpad.net/ubuntu/+source/libtracefs/+bug/2062118.
   The failures on s390x are primarily because tep_alloc sets file
   endianness to LITTLE_ENDIAN by default (with no checks)

 * The changes are already accepted into plucky and upstream:
   https://code.launchpad.net/~r41k0u/ubuntu/+source/libtraceevent/+git/libtraceevent/+merge/477042

 * This will fix autopkgtest segfaults of libtracefs on oracular and noble for s390x.

[ Test Plan ]

 * Clone libtracefs (oracular-devel or noble-devel), compile it and the tests (make && make test),
   then run the tests as root (utest/trace-utest), on an s390x machine (running oracular or noble)

 * You can test the fix by installing the patched version of libtraceevent for the release you are
   testing and trying the libtracefs tests again.

[ Where problems could occur ]

 * This is not likely to break anything, as we can make a safe assumption
   to set file_bigendian to the same value as host_bigendian by default.
   If these are different, the user can set it using event-parse-api

 * In any case, this change seems logical. This does not affect any other
   little-endian architectures, and I think this won't be breaking any workarounds
   people did around this problem.

 * But in case we have some regressions as a result of this change, then there surely would
   be some workaround to this in a patch, which can then be reverted.

[ Other Info ]

 * This does not fix anything in libtraceevent but does fix the tests for libtracefs on s390x.
   But I have opened this bug against libtraceevent.

 * I see a workaround around this problem in the last patch in d/p/series, but this change does not affect
   it

Related branches

Changed in libtraceevent (Ubuntu):
assignee: Pragyansh Chaturvedi (r41k0u) → nobody
Changed in libtraceevent (Ubuntu):
status: New → In Progress
assignee: nobody → Pragyansh Chaturvedi (r41k0u)
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Pragyansh, or anyone else affected,

Accepted libtraceevent into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libtraceevent/1:1.8.2-1ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libtraceevent (Ubuntu Oracular):
status: New → Fix Committed
tags: added: verification-needed verification-needed-oracular
Changed in libtraceevent (Ubuntu Noble):
status: New → Fix Committed
tags: added: verification-needed-noble
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Pragyansh, or anyone else affected,

Accepted libtraceevent into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libtraceevent/1:1.8.2-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (libtraceevent/1:1.8.2-1ubuntu3.1)

All autopkgtests for the newly accepted libtraceevent (1:1.8.2-1ubuntu3.1) for oracular have finished running.
The following regressions have been reported in tests triggered by the package:

linux-realtime/6.11.0-1008.8 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/oracular/update_excuses.html#libtraceevent

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (libtraceevent/1:1.8.2-1ubuntu2.1)

All autopkgtests for the newly accepted libtraceevent (1:1.8.2-1ubuntu2.1) for noble have finished running.
The following regressions have been reported in tests triggered by the package:

libtracefs/1.8.0-1ubuntu1 (arm64)
linux-azure-6.11/6.11.0-1012.12~24.04.1 (amd64, arm64)
linux-hwe-6.11/6.11.0-24.24~24.04.1 (amd64, arm64, s390x)
linux-lowlatency-hwe-6.11/6.11.0-1011.12~24.04.1 (amd64, arm64)
linux-nvidia/6.8.0-1026.29 (arm64)
linux-nvidia-lowlatency/6.8.0-1024.27.1 (arm64)
linux-realtime/6.8.1-1015.16 (amd64)
linux-xilinx/6.8.0-1014.15 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/noble/update_excuses.html#libtraceevent

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.