[SRU] Set default file_bigendian in struct tep_handle
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libtraceevent (Ubuntu) |
In Progress
|
Medium
|
Pragyansh Chaturvedi | ||
Noble |
Fix Committed
|
Undecided
|
Unassigned | ||
Oracular |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
* This relates to https:/
The failures on s390x are primarily because tep_alloc sets file
endianness to LITTLE_ENDIAN by default (with no checks)
* The changes are already accepted into plucky and upstream:
https:/
* This will fix autopkgtest segfaults of libtracefs on oracular and noble for s390x.
[ Test Plan ]
* Clone libtracefs (oracular-devel or noble-devel), compile it and the tests (make && make test),
then run the tests as root (utest/
* You can test the fix by installing the patched version of libtraceevent for the release you are
testing and trying the libtracefs tests again.
[ Where problems could occur ]
* This is not likely to break anything, as we can make a safe assumption
to set file_bigendian to the same value as host_bigendian by default.
If these are different, the user can set it using event-parse-api
* In any case, this change seems logical. This does not affect any other
little-endian architectures, and I think this won't be breaking any workarounds
people did around this problem.
* But in case we have some regressions as a result of this change, then there surely would
be some workaround to this in a patch, which can then be reverted.
[ Other Info ]
* This does not fix anything in libtraceevent but does fix the tests for libtracefs on s390x.
But I have opened this bug against libtraceevent.
* I see a workaround around this problem in the last patch in d/p/series, but this change does not affect
it
Related branches
- Jeremy Bícha (community): Approve
-
Diff: 81 lines (+59/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/0004-fix-file-endianness.patch (+50/-0)
debian/patches/series (+1/-0)
- Jeremy Bícha (community): Approve
-
Diff: 81 lines (+59/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/0004-fix-file-endianness.patch (+50/-0)
debian/patches/series (+1/-0)
Changed in libtraceevent (Ubuntu): | |
assignee: | Pragyansh Chaturvedi (r41k0u) → nobody |
Changed in libtraceevent (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Pragyansh Chaturvedi (r41k0u) |
Hello Pragyansh, or anyone else affected,
Accepted libtraceevent into oracular-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ libtraceevent/ 1:1.8.2- 1ubuntu3. 1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification- needed- oracular to verification- done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- oracular. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance for helping!
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.