[MIR] libtext-unidecode-perl (libemail-mime-contenttype-perl dependency as libemail-mime-perl dependency as libmail-dmarc-perl dependency)

[Miriam España Acebal]

[MIR] libtext-unidecode-perl (libemail-mime-contenttype-perl dependency as libemail-mime-perl dependency as libmail-dmarc-perl dependency)

libtext-unidecode-perl

[Availability]
The package libtext-unidecode-perl is already in Ubuntu universe.
The package libtext-unidecode-perl build for the architectures it is designed to work on.
It currently builds and works for architectures: amd64 (all)
Link to package https://launchpad.net/ubuntu/+source/libtext-unidecode-perl

[Rationale]
The package libtext-unidecode-perl is required in Ubuntu main for libemail-mime-contenttype-perl.
The package libtext-unidecode-perl will not generally be useful for a large part of
our user base, but is important/helpful still because libemail-mime-contenttype-perl requires it as a runtime dependency ( MIR bug https://bugs.launchpad.net/ubuntu/+source/libemail-mime-contenttype-perl/+bug/2030962 )
 and this, in turn, is required as runtime dependency by libemail-mime-perl,
(MIR bug https://bugs.launchpad.net/ubuntu/+source/libemail-mime-perl/+bug/2030880),
 and this, in turn, is required as runtime dependency by libmail-dmarc-perl
( libmail-dmarc-perl is in the MIR process here: https://bugs.launchpad.net/ubuntu/+source/libmail-dmarc-perl/+bug/2023971 )

The package libtext-unidecode-perl is required in Ubuntu main no later than through the same scheduled requested for the libemail-mime-contenttype-perl, libemail-mime-perl and libmail-dmarc-perl promotion, since libemail-mime-contenttype-perl depends on it.

[Security]
No CVEs/security issues in this software in the past.
No `suid` or `sgid` binaries.
No executables in `/sbin` and `/usr/sbin`.
Package does not install services, timers or recurring jobs.
Package does not open privileged ports (ports < 1024).
Package does not expose any external endpoints.
Package does not contain extensions to security-sensitive software (filters, scanners, plugins, UI skins, ...).

[Quality assurance - function/usage]
The package works well right after install

[Quality assurance - maintenance]
The package is maintained well in Debian/Ubuntu and does
not have too many, long-term & critical, open bugs:
   - Ubuntu (0) https://bugs.launchpad.net/ubuntu/+source/libtext-unidecode-perl/+bug
   - Debian (6) https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libtext-unidecode-perl
On Upstream, it seems now like someone is reviewing bugs
- Upstream's bug tracker (9) https://rt.cpan.org/Public/Dist/Display.html?Name=Text-Unidecode
     + Upstream's bug last activity:
       - updated issue/pr: Mar 01, 2023
       - fixed/closed/merged issue: Mar 01, 2023
but for old issues (2011). The repo I've could find is unmaintained:
https://github.com/doherty/Text-Unidecode/

The package does not deal with exotic hardware we cannot support

[Quality assurance - testing]
The package runs a test suite on build time, if it fails
it makes the build fail: https://launchpadlibrarian.net/632296383/buildlog_ubuntu-lunar-amd64.libtext-unidecode-perl_1.30-3_BUILDING.txt.gz :

      dh_auto_test
    make -j4 test TEST_VERBOSE=1
   make[1]: Entering directory '/<<PKGBUILDDIR>>'
   PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" t/*.t

The package runs an autopkgtest (via autodep8 using 'Testsuite: autopkgtest-pkg-perl' in d/control file - https://git.launchpad.net/ubuntu/+source/libtext-unidecode-perl/tree/debian/control#n5 -),
that runs essentialy the above build-time test suite. It is currently passing on
this list of architectures (amd64, arm64, armhf, ppc64el, riscv64, s390x), except on i386: https://autopkgtest.ubuntu.com/packages/l/libtext-unidecode-perl

The package does have failing autopkgtests tests right now, but since
they always failed they are handled as "ignored failure", this is
because the package the test depends on pkg-perl-tools package that is not
build for i386 since focal.

[Quality assurance - packaging]
debian/watch is present and works.

debian/control defines a correct Maintainer field : Debian Perl Group <email address hidden> ( https://git.launchpad.net/ubuntu/+source/libtext-unidecode-perl/tree/debian/control#n2)

This package does not yield massive lintian Warnings, Errors
  - recent build log of the package https://launchpadlibrarian.net/644464042/buildlog_ubuntu-lunar-amd64.libtext-unidecode-perl_1.408-1_BUILDING.txt.gz
  - full output from `lintian --pedantic` :
    # source
    ❯ lintian -EvIL +pedantic --show-overrides
       E: libtext-unidecode-perl changes: bad-distribution-in-changes-file mantic
       W: libtext-unidecode-perl: changelog-distribution-does-not-match-changes-file (unstable != mantic)
       W: libtext-unidecode-perl changes: distribution-and-changes-mismatch mantic unstable # binary
    # binary
    ❯ lintian -EvIL +pedantic --show-overrides ../libtext-unidecode-perl_1.30-3.dsc
      I: libtext-unidecode-perl source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.6.0.1)
      X: libtext-unidecode-perl source: debian-watch-does-not-check-gpg-signature [debian/watch]
      P: libtext-unidecode-perl source: silent-on-rules-requiring-root [debian/control]
      P: libtext-unidecode-perl source: update-debian-copyright 2014 vs 2022 [debian/copyright:11]
      X: libtext-unidecode-perl source: upstream-metadata-file-is-missing

This package does not rely on obsolete or about to be demoted packages.
This package has no python2 or GTK2 dependencies.

The package will not be installed by default.

Packaging and build is easy, link to debian/rules: https://git.launchpad.net/ubuntu/+source/libtext-unidecode-perl/tree/debian/rules

[UI standards]
Application is not end-user facing (does not need translation).

[Dependencies]
No further depends or recommends dependencies that are not yet in main.

[Standards compliance]
This package correctly follows FHS and Debian Policy (3.9.8)

[Maintenance/Owner]
Owning Team will be Ubuntu Server Team.
Team is not yet, but will subscribe to the package before promotion.
This does not use static builds.
This does not use vendored code.
This package is not rust based.

The package successfully built during the most recent test rebuild : https://launchpad.net/ubuntu/+archive/test-rebuild-20230515-lunar-v3/+build/26138908/+files/buildlog_ubuntu-lunar-amd64.libtext-unidecode-perl_1.30-3_BUILDING.txt.gz

[Background information]
The Package description explains the package well.
Upstream Name is Text-Unidecode .
Link to upstream project https://metacpan.org/dist/Text-Unidecode

This has been in the archive since at least 2006 (0.04-1). It's never had a bug filed against it in Launchpad.

[Ioanna Alifieraki (joalif)]

Review for Source Package: libtext-unidecode-perl

[Summary]
This package provides translation from Unicode text to US-ASCII.
MIR team ACK
This does not need a security review
List of specific binary packages to be promoted to main: libtext-unidecode-perl
Specific binary packages built, but NOT to be promoted to main: none

Notes:
The package is unmaintained upstream. However, in debian there has been
a few contributions the past year so I guess we're good.

Required TODOs:
- The package should get a team bug subscriber before being promoted

[Duplication]
There is no other package in main providing the same functionality.
This package is required in main as an indirect dependency of libmail-dmarc-perl.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
  - checked with `check-mir`
  - all dependencies can be found in `seeded-in-ubuntu` (already in main)
  - none of the (potentially auto-generated) dependencies (Depends
    and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
   xml, json, asn.1], network packets, structures, ...) from
   an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Debian/Ubuntu update history is slow
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems:
- Upstream seems unmaintained

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRA...

[Miriam España Acebal (mirespace)]

Server Team's subscription to the bug requested on the MP attached to the bug.