Activity log for bug #813210

Date Who What changed Old value New value Message
2011-07-19 22:25:47 Aurelien Guillaume bug added bug
2011-10-24 15:38:13 Launchpad Janitor libsmbios (Ubuntu): status New Confirmed
2011-10-24 15:38:25 Mark Russell bug added subscriber Mark Russell
2011-11-29 22:53:27 Jose Plans attachment added Debdiff for Lucid https://bugs.launchpad.net/ubuntu/+source/libsmbios/+bug/813210/+attachment/2613005/+files/libsmbios_2.2.13-0ubuntu4.1%7ELP813210.1.debdiff
2011-11-30 00:59:04 Ubuntu Foundations Team Bug Bot tags patch
2011-11-30 00:59:18 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Sponsors Team
2011-11-30 13:59:12 Marc Deslauriers removed subscriber Ubuntu Sponsors Team
2011-11-30 13:59:26 Marc Deslauriers libsmbios (Ubuntu): status Confirmed Incomplete
2011-12-07 14:19:46 Jose Plans attachment removed Debdiff for Lucid https://bugs.launchpad.net/ubuntu/+source/libsmbios/+bug/813210/+attachment/2613005/+files/libsmbios_2.2.13-0ubuntu4.1%7ELP813210.1.debdiff
2011-12-07 14:23:47 Jose Plans attachment added Debdiff Lucid (updated) https://bugs.launchpad.net/ubuntu/+source/libsmbios/+bug/813210/+attachment/2623066/+files/libsmbios_2.2.13-0ubuntu4.1_4.2.debdiff
2011-12-07 14:24:53 Jose Plans bug added subscriber Ubuntu Sponsors Team
2011-12-07 22:03:55 Brian Murray libsmbios (Ubuntu): status Incomplete In Progress
2011-12-07 22:03:58 Brian Murray libsmbios (Ubuntu): assignee Brian Murray (brian-murray)
2011-12-07 22:04:03 Brian Murray libsmbios (Ubuntu): importance Undecided Medium
2011-12-07 22:08:58 Brian Murray nominated for series Ubuntu Lucid
2011-12-07 22:08:58 Brian Murray bug task added libsmbios (Ubuntu Lucid)
2011-12-07 22:10:14 Brian Murray libsmbios (Ubuntu Lucid): status New In Progress
2011-12-07 22:10:20 Brian Murray libsmbios (Ubuntu Lucid): importance Undecided Medium
2011-12-07 22:13:18 Brian Murray description Hello, I encountered a bug while updating some Dell server BIOS, with a 3.0.0 BIOS on Ubuntu 10.04 LTS (lucid). The current version of python-libsmbios on lucid suffers of a parsing bug on the bios version string, due to null bytes (.0.0) in the version string. With the following files: Works: http://linux.dell.com/repo/firmware/bios-hdrs/system_bios_ven_0x1028_dev_0x0236_version_2.3.12/bios.hdr Fails: http://linux.dell.com/repo/firmware/bios-hdrs/system_bios_ven_0x1028_dev_0x0236_version_3.0.0/bios.hdr this can be verified with the following command: # smbios-rbu-bios-update --hdr-info=bios-3.0.0.hdr BIOS HDR file information dump. Filename: /dev/shm/bios.hdr File magic header: $RBU Header length: 84 Header major version: 2 Header minor version: 0 Number of supported systems: 10 Quick check field: Copyright 2011 Dell Inc. Traceback (most recent call last): File "/usr/sbin/smbios-rbu-bios-update", line 185, in <module> sys.exit( main() ) File "/usr/sbin/smbios-rbu-bios-update", line 138, in main dumpHdrFileInfo(h) File "<libsmbios_c._peak_util_decorators.rewrap wrapping libsmbios_c.rbu_hdr.dumpHdrFileInfo at 0x0184C6E0>", line 3, in dumpHdrFileInfo File "/usr/lib/python2.6/dist-packages/libsmbios_c/trace_decorator.py", line 98, in trace result = func(*args, **kw) File "/usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py", line 43, in dumpHdrFileInfo print _("BIOS Version: %s") % hdr.biosVersion() File "<libsmbios_c._peak_util_decorators.rewrap wrapping libsmbios_c.rbu_hdr.biosVersion at 0x018A25F0>", line 3, in biosVersion File "/usr/lib/python2.6/dist-packages/libsmbios_c/trace_decorator.py", line 98, in trace result = func(*args, **kw) File "/usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py", line 87, in biosVersion ver = "%d.%d.%d" % struct.unpack("BBB", self.hdr.biosVersion) struct.error: unpack requires a string argument of length 3 On newer Ubuntu versions, libsmbios has a fix about that ; could it be backported to lucid ? --- /usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py.old 2011-07-19 23:57:50.506269986 +0200 +++ /usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py 2011-07-20 00:14:46.656270075 +0200 @@ -107,7 +107,7 @@ #char quickCheck[40]; ("quickCheck", ctypes.c_char * 40), #char biosVersion[3]; - ("biosVersion", ctypes.c_char * 3), + ("biosVersion", ctypes.c_uint8 * 3), #u8 miscFlags; ("miscFlags", ctypes.c_uint8), #u8 biosInternalUse; Thanks. Description: Ubuntu 10.04.2 LTS Release: 10.04 libsmbios2: Installed: 2.2.13-0ubuntu4.1 Candidate: 2.2.13-0ubuntu4.1 Version table: *** 2.2.13-0ubuntu4.1 0 500 http://fr.archive.ubuntu.com/ubuntu/ lucid-updates/universe Packages 100 /var/lib/dpkg/status 2.2.13-0ubuntu4 0 500 http://fr.archive.ubuntu.com/ubuntu/ lucid/universe Packages 500 http://linux.dell.com/repo/community/deb/latest/ Packages Hello, I encountered a bug while updating some Dell server BIOS, with a 3.0.0 BIOS on Ubuntu 10.04 LTS (lucid). The current version of python-libsmbios on lucid suffers of a parsing bug on the bios version string, due to null bytes (.0.0) in the version string. With the following files: Works: http://linux.dell.com/repo/firmware/bios-hdrs/system_bios_ven_0x1028_dev_0x0236_version_2.3.12/bios.hdr Fails: http://linux.dell.com/repo/firmware/bios-hdrs/system_bios_ven_0x1028_dev_0x0236_version_3.0.0/bios.hdr == SRU Justification == * Impact: users needing to upgrade DELL server's firmware to version 3.0.0 on Ubuntu 10.04 LTS are not be able to do so due to parsing issue. TEST CASE: How to reproduce: 1. wget http://linux.dell.com/repo/firmware/bios-hdrs/system_bios_ven_0x1028_dev_0x0236_version_3.0.0/bios.hdr 2. smbios-rbu-bios-update --hdr-info=bios.hdr Expected results: No error messages, and a proper parse output from the bios. Actual results: Python traceback. Output from step 2 failing follows: # smbios-rbu-bios-update --hdr-info=bios-3.0.0.hdr BIOS HDR file information dump. Filename: /dev/shm/bios.hdr File magic header: $RBU Header length: 84 Header major version: 2 Header minor version: 0 Number of supported systems: 10 Quick check field: Copyright 2011 Dell Inc. Traceback (most recent call last):   File "/usr/sbin/smbios-rbu-bios-update", line 185, in <module>     sys.exit( main() )   File "/usr/sbin/smbios-rbu-bios-update", line 138, in main     dumpHdrFileInfo(h)   File "<libsmbios_c._peak_util_decorators.rewrap wrapping libsmbios_c.rbu_hdr.dumpHdrFileInfo at 0x0184C6E0>", line 3, in dumpHdrFileInfo   File "/usr/lib/python2.6/dist-packages/libsmbios_c/trace_decorator.py", line 98, in trace     result = func(*args, **kw)   File "/usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py", line 43, in dumpHdrFileInfo     print _("BIOS Version: %s") % hdr.biosVersion()   File "<libsmbios_c._peak_util_decorators.rewrap wrapping libsmbios_c.rbu_hdr.biosVersion at 0x018A25F0>", line 3, in biosVersion   File "/usr/lib/python2.6/dist-packages/libsmbios_c/trace_decorator.py", line 98, in trace     result = func(*args, **kw)   File "/usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py", line 87, in biosVersion     ver = "%d.%d.%d" % struct.unpack("BBB", self.hdr.biosVersion) struct.error: unpack requires a string argument of length 3 On newer Ubuntu versions, libsmbios has a fix about that ; could it be backported to lucid ? --- /usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py.old 2011-07-19 23:57:50.506269986 +0200 +++ /usr/lib/python2.6/dist-packages/libsmbios_c/rbu_hdr.py 2011-07-20 00:14:46.656270075 +0200 @@ -107,7 +107,7 @@          #char quickCheck[40];          ("quickCheck", ctypes.c_char * 40),          #char biosVersion[3]; - ("biosVersion", ctypes.c_char * 3), + ("biosVersion", ctypes.c_uint8 * 3),          #u8 miscFlags;          ("miscFlags", ctypes.c_uint8),          #u8 biosInternalUse; Thanks. Description: Ubuntu 10.04.2 LTS Release: 10.04 libsmbios2:   Installed: 2.2.13-0ubuntu4.1   Candidate: 2.2.13-0ubuntu4.1   Version table:  *** 2.2.13-0ubuntu4.1 0         500 http://fr.archive.ubuntu.com/ubuntu/ lucid-updates/universe Packages         100 /var/lib/dpkg/status      2.2.13-0ubuntu4 0         500 http://fr.archive.ubuntu.com/ubuntu/ lucid/universe Packages         500 http://linux.dell.com/repo/community/deb/latest/ Packages
2011-12-07 22:56:24 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2011-12-07 22:56:30 Brian Murray libsmbios (Ubuntu Lucid): assignee Brian Murray (brian-murray)
2011-12-07 22:56:35 Brian Murray libsmbios (Ubuntu): status In Progress Fix Released
2011-12-07 22:56:57 Brian Murray libsmbios (Ubuntu Lucid): importance Medium Undecided
2011-12-07 22:56:57 Brian Murray libsmbios (Ubuntu Lucid): status In Progress New
2011-12-07 22:56:57 Brian Murray libsmbios (Ubuntu Lucid): assignee Brian Murray (brian-murray)
2011-12-07 22:57:11 Brian Murray libsmbios (Ubuntu Lucid): status New Fix Committed
2011-12-07 22:57:16 Brian Murray libsmbios (Ubuntu Lucid): importance Undecided Medium
2011-12-07 22:57:22 Brian Murray libsmbios (Ubuntu Lucid): assignee Brian Murray (brian-murray)
2011-12-10 10:36:38 Benjamin Drung removed subscriber Ubuntu Sponsors Team
2011-12-19 15:07:03 Martin Pitt bug added subscriber SRU Verification
2011-12-21 06:12:24 Launchpad Janitor branch linked lp:ubuntu/lucid-proposed/libsmbios
2012-01-29 10:37:15 Bartosz Kosiorek tags patch patch verification-failed
2012-01-29 10:45:31 Bartosz Kosiorek tags patch verification-failed patch verification-done
2012-01-30 01:17:01 Launchpad Janitor libsmbios (Ubuntu Lucid): status Fix Committed Fix Released
2012-10-15 20:29:33 Chris J Arges bug added subscriber Sustaining Engineering
2014-02-07 16:02:50 Curtis Hovey removed subscriber Registry Administrators