libsigrok: MIME type and icons are not installed

[Maksim Salau]

Hello,

libsigrok installs the following files, but they don't end up in the deb files:

/usr/share/icons/hicolor/48x48/mimetypes/libsigrok.png
/usr/share/icons/hicolor/scalable/mimetypes/libsigrok.svg
/usr/share/mime/packages/vnd.sigrok.session.xml

As a result *.sr files are not associated with PulseView as they should.
It'd be great to add those files to the deb creation rules and update mime database in the post install script:

update-mime-database /usr/share/mime

I tested the following release:
Ubuntu Impish 21.10
libsigrok4-0.5.2-3build1:amd64

Also I confirmed that sigrok-0.5.2 has those files:

git clone git://sigrok.org/libsigrok
cd libsigrok
git checkout libsigrok-0.5.2
./autogen.sh
./configure.sh --prefix=/usr
DESTDIR=$PWD/install make -j5 install
find ./install/usr/share -type f

Output of the last command is:

./install/usr/share/icons/hicolor/48x48/mimetypes/libsigrok.png
./install/usr/share/icons/hicolor/scalable/mimetypes/libsigrok.svg
./install/usr/share/mime/packages/vnd.sigrok.session.xml

Best regards,
Maksim

[Maksim Salau (maksim-salau)]

Hi,

I couldn't find where the build rules are stored for libsigrok package in Ubuntu :(
So I prepared a path for Debian rules which can be found here:
https://salsa.debian.org/electronics-team/sigrok/libsigrok
I'm investigating how to create a merge request for this change.
Any help is welcome :)

Regards,
Maksim

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "0001-Update-install-rules-to-include-icons-and-the-mime-t.patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Maksim Salau (maksim-salau)]

The fix has been merged into libsigrok at
https://salsa.debian.org/electronics-team/sigrok/libsigrok

https://salsa.debian.org/electronics-team/sigrok/libsigrok/-/commit/ea53a42d9d922c0786bc2483d56a99b476faca75

During review the fix has evolved a little.
Are any additional actions required to forward the fix from Debian to Ubuntu?

Regards,
Maksim

[Benjamin Drung (bdrung)]

Thanks for going through Debian with this fix. The next step is that Debian uploads libsigrok 0.5.2-4 to unstable. Then we will sync that version to Ubuntu.