[FFe] Enable Mir video support for 2.0.2

Bug #1295389 reported by Brandon Schaefer
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libsdl2 (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

By default Mir support is turned off. Enable it by default.

The code is isolated and will not affect other platforms running SDL2. It will only provide support for Mir. This will be helpful with unity8 to have Mir support on by default. Allowing support for SDL2 apps on unity8 automatically just by enabling this flag.

Changelog:

libsdl2 (2.0.2+dfsg1-3ubuntu1) trusty; urgency=medium

  * Enable Mir video support. [linux-any]

 -- Brandon Schaefer <email address hidden> Thu, 20 Mar 2014 14:55:50 -0700

Built successfully on 14.04, as well as ensured Mir support was enabled when configure was going off. Installed over the new lisdl2.0.2 that was just sync earlier today bug 1293043.

From there I used my own test application [1] that is an SDL2 app. With this minor change, it now works directly on mir/unity8. As well as tested each test program that lives inside SDL2/tests/.

[1] https://code.launchpad.net/~brandontschaefer/+junk/sdl2-demo-blocks

Related branches

summary: - [FFe] Enable Mir/Wayland video support for 2.0.2
+ [FFe] Enable Mir video support for 2.0.2
description: updated
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote :

I see that the MP review has gone through a couple rounds of feedback, and the latest patch looks solid.

This will introduce a new dependency from the libsdl2-2.0-0 package on libmirclient. Since both packages are in main, and neither package is seeded on any images, this is ok.

FFe granted.

Changed in libsdl2 (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libsdl2 - 2.0.2+dfsg1-3ubuntu1

---------------
libsdl2 (2.0.2+dfsg1-3ubuntu1) trusty; urgency=medium

  * Enable Mir video support (LP: #1295389).
 -- Brandon Schaefer <email address hidden> Thu, 10 Apr 2014 01:15:21 +0100

Changed in libsdl2 (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Scott Howard (showard314) wrote :

I believe something is wrong with MIR support. A daily build of openmw just failed with:
/usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory
 #include <mir_toolkit/mir_client_library.h>

In SDL_syswm.h:
#if defined(SDL_VIDEO_DRIVER_MIR)
#include <mir_toolkit/mir_client_library.h>
#endif

the file is:
/usr/include/mirclient/mir_toolkit/mir_client_library.h
http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any

openmw buildlog:
https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz

it built successfully until this libsdl2 commit hit that enabled mir

Revision history for this message
Scott Howard (showard314) wrote :

reported as new bug #1306629, i'll subscribe @brandontschaefer to that new one

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.