[FFe] sdl1.2 needs mir support patch

Bug #1432741 reported by Brandon Schaefer on 2015-03-16
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libsdl1.2 (Ubuntu)
Medium
Brandon Schaefer
libsdl1.2 (Ubuntu RTM)
Undecided
Unassigned

Bug Description

Asking for FFe for the libsdl1.2 Mir patch. It would be a nice bonus for 16.10 Mir users as there are a lot of interesting SDL 1.2 applications out there.

Builds fine and can be tested from https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/1996/+packages

The diff is in comment #1, I just changed it to be debian/patches/mir-support.patch and only applied the debian/control change directly.

As can be seen, the patch is clean and the codepaths shouldn't be encountered in non-Mir situations so risks should be low.

--- original report below ---

There is a branch here with mir support:
lp:~brandontschaefer/+junk/sdl1.2-mir

From here theres one more patch from Marco I need to get into the main branch then propose an actual patch for main.

Related branches

Changed in libsdl1.2 (Ubuntu):
assignee: nobody → Brandon Schaefer (brandontschaefer)
status: New → In Progress
importance: Undecided → Medium

Tested with on yakkety with mir 0.24 as well as mir trunk (0.25)

Applications tested working:
-mplayer
-viruskiller
-bomberclone
-tuxfootball
(and more)

If anyone wants to test this as well:
 Have a mir server running (yakkety 0.24 preferred)
   If the server is on a tty (MIR_SOCKET=/tmp/mir_socket)
   otherwise you'll be fine on the Mir on X server.
  Run the game you want: SDL_VIDEODRIVER=mir ./game_you_want

Any game that uses glew will not work sadly as there still needs a port there. This also isnt 100% coverage, not a 100% complete port. Some functions missing including custom cursors, relative mouse support and a few others.

X11 will still be picked before Mir, so this will not cause any issues there. You have to manually do SDL_VIDEODRIVER=mir if you want to run Mir over X. Or if you're on a Mir server only it'll just work.

tags: added: patch
summary: - sdl1.2 needs mir support patch
+ [FFe] sdl1.2 needs mir support patch
description: updated
description: updated
description: updated
Changed in libsdl1.2 (Ubuntu RTM):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Timo Jyrinki (timo-jyrinki) wrote :

Asked Brandon to test from PPA https://bileto.ubuntu.com/#/ticket/1996 - I did get a crash when trying to run on Unity 8 on my Chromebook.

O sorry, forgot about testing this! Ill try to get sometime to test on Unity 8, Ive mainly been testing it on miral/demo server.

Daniel Holbach (dholbach) wrote :

I'll unsubscribe Ubuntu sponsors for the time being. Please re-subscribe when ready.

Ok new patch! The crash on U8 was caused due to U8 resizing windows, I now clip it when doing software rendering. The patch has also been brought up to Mir 0.26 deprecations so it should be Mir 1.0 safe. (Which is why I've waited a bit to get this back)

New patch forgot to fallback to X11.

Sorry, with that new change u8 decides to dislike the multiple connections to test if the server is active. Need to dig into this. Patch coming soon! (unsubscribing the ubuntu sponsors for now)

Well its a bug in U8 https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1675448

Theres not really a workaround I could do (with out a pretty bad hack). So this patch will *not* specifically work on U8 until that bug is fixed. Though it'll still be good to get this landed.

Ill put a testing patch that will just return true that you can connect to the mir server with out attempting to connect. This will allow it to work on U8 but wont fallback to x11 (which is why I need that connection check).

Here is the same patch with one line change. When we check if mir is around we just return one vs doing two mir connects. This will work with U8 but *should* not be merged in, as if it is sdl1.2 will no longer work on x11 as it'll always think mir is around to run then it'll fail.

The patch to test with on unity8:
http://paste.ubuntu.com/24237290/

I didn't get what to sponsor (and if there is something to sponsor)

Well this is an older bug now (went into FFe but that was last cycle). Though I think we are in FFe again. Just would like to get the mir-support.patch in for sdl1.2debian? Are sponsors not the correct people to poke? (it was mentioned to add again when the patch was fixed)

Turns out the bug is its own bug:

https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1675448

The debdiff linked will work once thats fixed in U8, but doesnt prevent the fact that this patch is ready!

Timo Jyrinki (timo-jyrinki) wrote :

Great! Indeed we're again in FFe so elt's wait for 17.10 to open in 1.5 weeks!

I have the old ticket/silo still open https://bileto.ubuntu.com/#/ticket/1996 so I can update it here once there is 17.10 series to use.

Changed in libsdl1.2 (Ubuntu RTM):
assignee: Timo Jyrinki (timo-jyrinki) → nobody

what is the status of this bug now that Unity/MIR will be dropped?

will them be dropped? (I see default to gnome-shell and wayland coming on next releases)

Bryan Quigley (bryanquigley) wrote :

Going to mark the general Ubuntu bug incomplete per LocutusOfBorg comment, maybe this is no longer wanted/needed? (The RTM definitely seems obsolete so going to close that)

Changed in libsdl1.2 (Ubuntu):
status: In Progress → New
status: New → Incomplete
Changed in libsdl1.2 (Ubuntu RTM):
status: New → Invalid
Simon Quigley (tsimonq2) wrote :

Unsubscribing ~ubuntu-sponsors as there is nothing to sponsor.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers