SRU the current 2.48.9 stable update

Bug #1903329 reported by Salim B on 2020-11-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
librsvg (Ubuntu)
High
Olivier Tilloy
Focal
High
Olivier Tilloy

Bug Description

* Impact

That's the current GNOME stable update, which fixes a number of issues, including a regression[1] since librsvg 2.40.x which was shipped in Ubuntu 16.04. The NEWS file[2] summarizes the relevant changes between Ubuntu 20.04's current librsvg 2.48.7 (that version was also introduced by an SRU back in July[3]) and the current version 2.48.9. The complete list of changes is available on GNOME GitLab[4].

* Test case

The update is part of GNOME stable updates[5].

Smoke testing by opening SVG images with eog or importing them with gimp can be performed to ensure there are no regressions.

* Regression potential

This is a bugfix-only stable micro-release, however librsvg is a core component with a number of reverse dependencies. A combination of autopkgtests and manual smoke testing to try and detect SVG rendering issues should be performed.

* Notes about this report

This is my first SRU request (and at the same time my first launchpad bug report). I'm not really familiar with the whole SRU process which is why I first asked about it on Ubuntu's official discourse forum[6]. Canonical's Sebastien Bacher encouraged me to open this ticket. I've copied over some parts of the last librsvg SRU ticket[3]. I hope this is fine.

Thanks for considering this SRU.

[1]: https://gitlab.gnome.org/GNOME/librsvg/-/issues/642

[2]: https://gitlab.gnome.org/GNOME/librsvg/-/blob/librsvg-2.48/NEWS

[3]: https://bugs.launchpad.net/bugs/1884326

[4]: https://gitlab.gnome.org/GNOME/librsvg/-/compare/2.48.7...2.48.9

[5]: https://wiki.ubuntu.com/StableReleaseUpdates/GNOME

[6]: https://discourse.ubuntu.com/t/most-straight-forward-way-to-get-librsvg2-microrelease-update-into-focal-updates/19238

Sebastien Bacher (seb128) wrote :

Thank you for the bug report!

Olivier, assigning to you since you usually do the librsvg updates, would be great if you could SRU this one

Changed in librsvg (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → High
status: New → Confirmed
Olivier Tilloy (osomon) wrote :

Thank you Salim, I'll take care of preparing and uploading the SRU.

Salim B (salim-b) on 2020-11-09
description: updated
Olivier Tilloy (osomon) wrote :

Note that the fix for upstream issue 642, which is one of the drivers for this SRU, hasn't been released in the 2.50.x series yet (it's only a commit on the master branch: https://gitlab.gnome.org/GNOME/librsvg/-/commit/da90a31c6604f747f290e236045d8c79d1186747).

The SRU process requires that a bug be fixed in the development release first, before considering a stable update (https://wiki.ubuntu.com/StableReleaseUpdates#Procedure).

I asked Federico what his plans are for a 2.50.2 release (https://gitlab.gnome.org/GNOME/librsvg/-/issues/642#note_957195), let's see what he says before going ahead.

Changed in librsvg (Ubuntu Focal):
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → High
status: New → Confirmed
Changed in librsvg (Ubuntu Focal):
status: Confirmed → Triaged
Changed in librsvg (Ubuntu):
status: Confirmed → Triaged
Olivier Tilloy (osomon) wrote :

Federico confirmed he plans on releasing librsvg 2.50.2 soon (November 21st at the latest). Once that is out, I'll update the package in Debian and Ubuntu 21.04, and we can then proceed with the SRU.

Olivier Tilloy (osomon) wrote :

librsvg 2.50.2+dfsg-1 is now in hirsute. We can proceed with the SRU.

Changed in librsvg (Ubuntu):
status: Triaged → Won't Fix
status: Won't Fix → Fix Released
Olivier Tilloy (osomon) wrote :

Uploaded librsvg 2.48.9-1ubuntu0.20.04.1, now sitting in the focal unapproved queue, waiting for the SRU team to review and accept it.

Changed in librsvg (Ubuntu Focal):
status: Triaged → In Progress
Brian Murray (brian-murray) wrote :

Should groovy also get the fix for upstream issue 642?

Changed in librsvg (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal

Hello Salim, or anyone else affected,

Accepted librsvg into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/librsvg/2.48.9-1ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Salim B (salim-b) wrote :

Hi Brian

I've succesfully installed and tested the `librsvg2-*` v2.48.9-1ubuntu0.20.04.1 packages on focal and can confirm that they work as expected for me, meaning i.a. that the bug I suffered from in the previous v2.48.7 is fixed.

I've used the CLI `rsvg-convert` as well as the R package rsvg[1] (which uses the C bindings provided by `librsvg2-dev`) to convert SVG images to PDF. Everything was fine, no regression as far as I can tell.

Thank you very much, Oliver, Brian and everyone else involved for the SRU work!

[1]: https://github.com/jeroen/rsvg#readme

tags: added: verification-done-focal
removed: verification-needed-focal
Olivier Tilloy (osomon) wrote :

> Should groovy also get the fix for upstream issue 642?

I suppose it wouldn't hurt. Adding the rls-gg-incoming tag to consider whether this is worthwhile.

tags: added: rls-gg-incoming
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package librsvg - 2.48.9-1ubuntu0.20.04.1

---------------
librsvg (2.48.9-1ubuntu0.20.04.1) focal; urgency=medium

  * SRU new upstream release to focal (LP: #1903329)

 -- Olivier Tilloy <email address hidden> Mon, 30 Nov 2020 18:08:14 +0100

Changed in librsvg (Ubuntu Focal):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for librsvg has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.