[MIR] libloader-java, libformula-java, librepository-java, libfonts-java, libserializer-java

[Björn Michaelsen]

All of the above are needed for libreoffice-report-builder-bin. see also related bug 992232.
Note all of the above should already have been in main before that maven madness started.

[Michael Terry (mterry)]

Same question as the other bug:
This isn't needed anymore, right? Per https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/992232/comments/35

[Björn Michaelsen (bjoern-michaelsen)]

postponed to quantal+1

[Michael Terry (mterry)]

libserializer looks fine. Build warnings seem safe enough. No important bugs. In sync. It's too bad it doesn't have a test suite. Would also be nice if Ubuntu had a bug subscriber.

[Michael Terry (mterry)]

I'm assigning libfonts-java to security-team for a quick pass, since it seems to parse the font files themselves.

As for the non-security side of MIR: Although the test suite is run... it doesn't seem to fail the build if it has errors. It currently seems to fail but continues anyway.

Otherwise the packaging seems fine. We're in sync. Would be nice to see a bug subscriber.

[Michael Terry (mterry)]

librepository is fine. No test suite unfortunately. Could use a bug subscriber.

[Michael Terry (mterry)]

liblayout looks mostly good. In sync, no important bugs. However, it has a test suite that isn't being run. Nor does upstream's ant config seem to support the 'test' target. Can that be looked into, to see how easy it would be to enable?

[Michael Terry (mterry)]

libloader looks mostly fine. It even has a test suite and runs it during build. But... it looks like a no-op. That is, it runs a test target, but doesn't seem to run the actual tests:

test:
[junitreport] Processing /home/mike/Projects/raring/libloader-1.1.6.dfsg/bin/reports/test/html/TESTS-TestSuites.xml to /tmp/null1129761652
[junitreport] Loading stylesheet jar:file:/usr/share/java/ant-junit-1.8.2.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 1047ms
[junitreport] Deleting: /tmp/null1129761652

I'm used to seeing some individual test reports and such there. Can that be looked into?

[Michael Terry (mterry)]

libformula is mostly fine. But again with the tests! It has a test suite and it runs, but seems to have the same problem as libfonts-java, where many of the tests fail, but the build doesn't.

There was one other issue (didn't use ${java:Depends}), but it isn't worth a delta, so I just submitted it upstream: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695283

[Jamie Strandboge (jdstrand)]

libfonts-java review:
 * Does it FTBFS currently? It builds fine with universe enabled, but has a lot of build dependencies from universe: libbase-java (from libbase) libitext-java libjcommon-java libloader-java (from libloader)
 * Does it have a test suite? it does, with test failures
 * Does Ubuntu carry a delta? no
 * Does it have a bug subscriber in Ubuntu? no
 * Does it have a watch file? yes, but it is broken: "libfonts-java: remote site does not even have current version"
 * Is its update history slow or sporadic? It hasn't received an update in almost a year
 * Is the current release packaged? No. upstream is at 1.2.5 but Ubuntu has 1.1.6
 * Will entering main make it harder for the people currently keeping it up to date? no
 * Lintian warnings: it has lintian warnings and errors in the source and binaries
 * Is debian/rules a mess? it is readable enough
 * Errors/warnings during the build: yes. javadoc, but also a deprecation warning:
    [javac] /PKGBUILDDIR/source/org/pentaho/reporting/libraries/fonts/FontException.java:42: warning: [deprecation] StackableException(String,Exception) in StackableException has been deprecated
 * Incautious use of malloc/sprintf: n/a. I poked around at the code and from what I saw, it seems to be coded well.
 * Uses of sudo or LD_LIBRARY_PATH: no
 * Important bugs (crashers, etc) in Debian or Ubuntu: no
 * Does the package have a CVE history? no

In general I am not comfortable with promoting libfonts-java in its current form. The package is not in good shape, is out of date and has not seen any maintenance for almost a year in Debian. The good news is that there are very few bugs and upstream is active. Conditional ACK provided:
 * the new upstream version is used
 * the testsuite failures are addressed
 * a bug subscriber is created (esp. since we will likely jump ahead of Debian)
 * fix the watch file
 * fix the lintian errors and warnings
 * address the build errors and warnings

[Michael Terry (mterry)]

libbase is covered in sister bug 1034558, so removing from here.

[Björn Michaelsen (bjoern-michaelsen)]

As we are reducing java dependencies in main, this is the wrong direction to go for such an auxiliary package (report-builder). Closing as wontfix, rather would invest in independantly building report-builder from universe ...

[Olivier Tilloy (osomon)]

It appears libreoffice-report-builder bundles all its java dependencies, so this is obsolete and can be closed:

$ dpkg -L libreoffice-report-builder | grep jar
/usr/lib/libreoffice/program/classes/flow-engine.jar
/usr/lib/libreoffice/program/classes/flute-1.1.6.jar
/usr/lib/libreoffice/program/classes/libbase-1.1.6.jar
/usr/lib/libreoffice/program/classes/libfonts-1.1.6.jar
/usr/lib/libreoffice/program/classes/libformula-1.1.7.jar
/usr/lib/libreoffice/program/classes/liblayout.jar
/usr/lib/libreoffice/program/classes/libloader-1.1.6.jar
/usr/lib/libreoffice/program/classes/librepository-1.1.6.jar
/usr/lib/libreoffice/program/classes/libserializer-1.1.6.jar
/usr/lib/libreoffice/program/classes/libxml-1.1.7.jar
/usr/lib/libreoffice/program/classes/reportbuilder.jar
/usr/lib/libreoffice/program/classes/reportbuilderwizard.jar
/usr/lib/libreoffice/program/classes/sac.jar