Include updated Humanity style

[Sergey "Shnatsel" Davidoff]

Binary package hint: libreoffice

LibreOffice Humanity icons (libreoffice-style-human package) should be updated to include the latest fixes from the attached file. A total of 130 icons are updated in this revision.

User interface freeze exception rationale:
Does not introduce any changes to translations or documentation, it's just a cosmetic update.
Very unlikely to break anything at all.
This update fixes several very visible issues, e.g. the blurry and confusing "new document" icons that are always on panel, which means that every OpenOffice user would encounter that issue.
Might be considered bugfix-only, since it just makes LibO icons catch up with the rest of the system and fixes several highly-visible issues.

See attached archives and screenshots for details.

====
Also, Bug #757304 for correct package name.

[Vish (vish)]

Kindly also fix the naming issue with this update, package needs to be libreoffice-style-humanity .
The icons are from Humanity not Human.

[Björn Michaelsen (bjoern-michaelsen)]

@Sergey: Changes to images.zip is unfortunately rather useless as it contains all the fallback images from tango and galaxy. What is needed for packaging this correctly is a diff against:
http://cgit.freedesktop.org/libreoffice/artwork/tree/ooo_custom_images/human
esp. without any duplicates of galaxy/industrial/tango icons (which we fall back upon from those themes).

For commiting the changes there, exact author information is needed -- are all changes done by <email address hidden> alone or were other sources (themes/icons) used for parts of the new icons (even only as a base)?

Also note that you can commit the changes yourself upstream at LibreOffice and they will get packed automatically with next release.

If you provide the information above, I will try to do the upstreaming again this time, but for the next time please do it yourself as it makes it a lot easier for everyone. I will help you out with that.

@Vish: Renaming is a different issue, please file a separate bug for it. Please also note, that this is too late for natty as:
a) we would require to add transitionals and give them a good testing
b) For consistency would also need to rename the theme in LibreOffice itself, which requires patching the compiled source.

[Vish (vish)]

Yea, fair enough, filed Bug #757304 for renaming the package.
The reason i mentioned it here was because updating the old icons and renaming could be done at the same time and no need to revisit this icons issue :-)

do note http://cgit.freedesktop.org/libreoffice/artwork/tree/ooo_custom_images/human should also be changed to http://cgit.freedesktop.org/libreoffice/artwork/tree/ooo_custom_images/humanity when renaming.

[Sergey "Shnatsel" Davidoff (shnatsel)]

@Björn: Unfortunately, I have no idea how to use git, I've hardly mastered bazaar. I tried googling and finally "git clone http://cgit.freedesktop.org/libreoffice/artwork" worked, but I can't commit anything :(
By the way, I've already provided a diff archive, but it may contain extra directories and the SVGs are in the same folders as PNGs. I'll separate them into a different folder, remove empty folders and upload the modified code tree here and "diff" archive like I did for the images.zip. I don't know how to make proper diffs for binary files, sorry. I tried it with packaging before but dpkg refuses to make .diff.gz + orig.tar.gz if binary files are changed.

I've also tried to reuse existing icons and don't make lots of new ones, so most of the work is done by Humanity authors and contributors:
Daniel Foré <email address hidden>
K.Vishnoo Charan Reddy<email address hidden>
Jonian Guveli <email address hidden>
Sebastian Porta <email address hidden>
Oliver Scholtz <email address hidden>
Daniel Planas <email address hidden>

Also, does "they will get packed automatically with next release" mean that they will get into Natty or not?

[Björn Michaelsen (bjoern-michaelsen)]

@Sergey: That diff tarball should do. I will commit that with you named as author. If you would contribute the artwork directly, each change would also name the authors correctly.
As for Natty, no it wont get in there, sorry, as we are three weeks past UI freeze:

 https://wiki.ubuntu.com/NattyReleaseSchedule

In will however be in the next upstream releases. I will also try to add that in when I do an bugfix release for natty/3.3.2.

[Sergey "Shnatsel" Davidoff (shnatsel)]

I've provided a freeze exception rationale in the bug description according to https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze%20Exceptions, is this not suffiscient? AFAIK freezes are made to ensure the stability and that documentation and translations are relevant, and this update doesn't affect any documentation or translations and is very unlikely to break anything.

[Vish (vish)]

@shnatsel: Documentation includes screenshots. :-) But not sure if any LibO screenshots are affected though

[Björn Michaelsen (bjoern-michaelsen)]

Pushed upstream as:
http://cgit.freedesktop.org/libreoffice/artwork/commit/?id=c9a834db6528a534fdb468f7df4baa30da141dc4

[Björn Michaelsen (bjoern-michaelsen)]

@Shnatsel: Please verify, that the current state of:

 http://cgit.freedesktop.org/libreoffice/artwork/tree/ooo_custom_images/human

is how you expect it too be. There might be a final bugfix release for 3.3.2 and it could contain these icons. No promises though!

[Sergey "Shnatsel" Davidoff (shnatsel)]

Björn, thanks for asking! I've browsed through all the 4,500 icons again and found several inconsistencies, please apply this diff as well and that will be the final revision for now. (I have several more updated icons but I don't want to include them now because their use cases aren't tested well enough).

[Vish (vish)]

Björn, shnatsel,
The contributors :
Sebastian Porta <email address hidden>
Oliver Scholtz <email address hidden>
Daniel Planas <email address hidden>

Have nothing to do with the LibO icons that are being updated, they did a few icons for Humanity, but need not be attributed for the above icon changes.

[Martin Pitt (pitti)]

Tempting indeed, but given that we have pretty much just one shot left for a LibO upload, and it happens after beta-2, I think it's better to postpone that to oneiric.

[Sergey "Shnatsel" Davidoff (shnatsel)]

@Björn: I have one more incremental diff, with imrovements to higly-visible icons this time. More such diffs may follow and I don't want to distract you every time I need to upload a few icons. Would you give me a link to some short manual or maybe a set of common commands for pulling/commiting/pushing for this repo? And is there any process of granting upload permissions?

[Björn Michaelsen (bjoern-michaelsen)]

@Sergey: You would need to get an account on freedesktop (please set me on cc when requesting the account) :

 http://www.freedesktop.org/wiki/AccountRequests

All the tips on the TDF wiki are for developers working on all repositories, not just artwork, so for you it would be a lot simpler. I could give you a walk-through on IRC: I am usually at least on #ubuntu-desktop and #libreoffice-dev on freenode. Just ping me there!

[Björn Michaelsen (bjoern-michaelsen)]

Introduction at:
http://wiki.documentfoundation.org/Design/GitArtworkGuide
announced at:
http://nabble.documentfoundation.org/Git-Artwork-guide-td2842164.html

[Sergey "Shnatsel" Davidoff (shnatsel)]

Thanks Björn, I've commited my changes upstream. Is there any additional info I should provide along with the icons (authors etc)?

[Björn Michaelsen (bjoern-michaelsen)]

You can update the info at
http://cgit.freedesktop.org/libreoffice/artwork/tree/ooo_custom_images/human/CopyrightsHuman?id=bd2790c7590d45f45dbe01793d7fb3aaf3b953a2
if that is needed.
Also you can use 'git commit --author "Some Other Guy <email address hidden>"' when the changes in the commit are mostly from that other person. He will then show up in the DSCM logs as author for the files he created etc.

Thanks for commiting/pushing!

[Scott Kitterman (kitterman)]

Too late for Natty now. Unsubscribing the release team.

[Sergey "Shnatsel" Davidoff (shnatsel)]

The updated style is committed upstream but still not included in Oneiric. What the..?

[Björn Michaelsen (bjoern-michaelsen)]

@Shnatsel: I assume you commited the changes upstream to master after the branch off of the 3.4 release branch, thus they are not included in 3.4 releases but only in later releases. I can try to identify your commits on master and cherry-pick them back to 3.4.

[Sergey "Shnatsel" Davidoff (shnatsel)]

According to http://cgit.freedesktop.org/libreoffice/artwork/log/, my last commit was before 3.4.0-rc1.

[Björn Michaelsen (bjoern-michaelsen)]

@Shnatsel: Are these the commits that need to be backported to 3.4?
beryllium:~/checkouts/libreoffice-master> git log libreoffice-3.4.2.3..e05ccb1672505c16825833ea628e2e82c6b544c0 ooo_custom_images/human/
commit e05ccb1672505c16825833ea628e2e82c6b544c0
Author: Sergey Davidoff <email address hidden>
Date: Tue May 17 18:08:28 2011 +0400

    updated a search icon in Humanity

commit 1457d1dc2dcb71e868e8624f8afc8398b3045430
Author: Sergey Davidoff <email address hidden>
Date: Tue May 17 17:57:58 2011 +0400

    lp#763892: updated leftover systray quick start icons with OO.o branding in Humanity and Oxygen

commit 2e703749d25929b7ec7eec20c0542b3d664dfb91
Author: Sergey Davidoff <email address hidden>
Date: Mon May 16 22:44:26 2011 +0400

    lp#783247: updated a leftover icon with OO.o branding in Humanity theme

commit 901f924beb2d9c56545edd1d646a5acc0528c0a0
Merge: bcac727 46be316
Author: Sergey Davidoff <email address hidden>
Date: Thu Apr 21 16:04:02 2011 +0400

    Merge branch 'master' of ssh://git.freedesktop.org/git/libreoffice/artwork

commit bcac727b262dc4860b181700c425f6c1cd378493
Author: Sergey Davidoff <email address hidden>
Date: Thu Apr 21 16:01:49 2011 +0400

    humanity: used slightly different mail icons

commit 46be3163655458aaba6e24b40ed2fb87fd1aae5d
Author: Bjoern Michaelsen <email address hidden>
Date: Thu Apr 21 09:30:31 2011 +0200

    lp#757304: update email address for vish

commit d538cd7e65924e9aeab9039efca3061049b25814
Author: Sergey Davidoff <email address hidden>
Date: Wed Apr 20 18:07:21 2011 +0400

    one more update of Humanity style (lp#756895)

commit f811108fd182d103049b817f6e562b19f2755aa1
Author: Sergey Davidoff <email address hidden>
Date: Mon Apr 11 17:15:54 2011 +0200

    lp#756895: update humanity style

[Sergey "Shnatsel" Davidoff (shnatsel)]

Yes, this looks like a full list of my commits.

[Björn Michaelsen (bjoern-michaelsen)]

For 3.5 and onwards please note that the repositories have been merged and the artwork is now in:
    http://cgit.freedesktop.org/libreoffice/core
Please also note that the branch off for 3.5 is intended to be Dec 5, 2011 (Mon):
    http://wiki.documentfoundation.org/ReleasePlan#3.5_release
after that, the commits need to be done on the libreoffice-3-5 branch too (after review).

[Björn Michaelsen (bjoern-michaelsen)]

Fix commited:
http://anonscm.debian.org/gitweb/?p=pkg-openoffice/libreoffice.git;a=commit;h=e3d01642f243e81fbe6a66bbd6d779577dbea95d

[Sergey "Shnatsel" Davidoff (shnatsel)]

w00t! Thanks a lot for your help, Björn!