FTBFS on armel, built for ARMv4, should be ARMv7

[Jani Monoses]

Binary package hint: libreoffice

In debian/rules the arm favour is selected.
It should be armv7 on Ubuntu, unlike in Debian
# ARM target
ifeq "$(ARCH)" "armel"
        CONFIGURE_FLAGS += --with-arm-target=4
endif
ifeq "$(ARCH)" "armhf"
        CONFIGURE_FLAGS += --with-arm-target=7
endif

This was not present in 3.3.0 so it built successfully past where it fails now.

[Björn Michaelsen (bjoern-michaelsen)]

fix commited as commit 424e5b5e1c4ea952b210e8244b8987cc02e6bb32:
http://git.debian.org/?p=pkg-openoffice/libreoffice.git;a=commit;h=424e5b5e1c4ea952b210e8244b8987cc02e6bb32

[Launchpad Janitor (janitor)]

This bug was fixed in the package libreoffice - 1:3.3.1-1ubuntu4

---------------
libreoffice (1:3.3.1-1ubuntu4) natty; urgency=low

  * reenable verbose build on ubuntu buildd (LP: #726333)
  * remove duplicate code in control file generation
  * selcting right arm target (LP: #725763)
 -- Bjoern Michaelsen <email address hidden> Mon, 28 Feb 2011 09:57:28 +0100

[Matthias Klose (doko)]

On 26.02.2011 22:09, Jani Monoses wrote:
> In debian/rules the arm favour is selected.
> It should be armv7 on Ubuntu

only for natty and newer. best thing is to use the compiler defaults and not
messing around with explicit settings if possible

[Jani Monoses (jani)]

I agree with using compiler defaults so I filed
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/726529

although I did not know all series were built from the same packaging. I only meant natty for armv7

[Steve Langasek (vorlon)]

The fix for this was wrong; package now fails to build with this error on armel:

debian/rules:1270: *** Recursive variable `CONFIGURE_FLAGS' references itself (eventually). Stop.

http://launchpadlibrarian.net/65277930/buildlog_ubuntu-natty-armel.libreoffice_1%3A3.3.1-1ubuntu4_FAILEDTOBUILD.txt.gz

Instead of setting the arg and then filtering it (with the wrong type of makefile assignment), a better fix would be:

# ARM target
ifeq "$(ARCH)" "armel"
  ifeq "$(DIST)" "Ubuntu"
        CONFIGURE_FLAGS += --with-arm-target=7
  else
        CONFIGURE_FLAGS += --with-arm-target=4
  endif
endif
ifeq "$(ARCH)" "armhf"
        CONFIGURE_FLAGS += --with-arm-target=7
endif

But if bug #726529 is progressing, maybe this will all be obsolete soon anyway?

Regardless, the package still fails to build right now, so reopening this bug.

[Björn Michaelsen (bjoern-michaelsen)]

@Steve: Yes, this should be obsolete with bug #726529 being solved, sorry about the missing update.

[Björn Michaelsen (bjoern-michaelsen)]

doko finished a build with the current fixes (1ubuntu5) but we will go directly to 3.3.2rc1 with that.