[SRU] libreoffice 7.3.7 updates for jammy

[Rico Tzschichholz]

[Impact]

 * LibreOffice 7.3.7 of the 7.3 is EOL since November 30, 2022
     https://wiki.documentfoundation.org/ReleasePlan/7.3

 * Cherry-picked patches mostly based on https://cgit.freedesktop.org/libreoffice/core/log/?h=distro/mimo/mimo-7-3
    * Switch default currency HRK Croatian Kuna to EUR Euro (tdf#150011)
      https://bugs.documentfoundation.org/show_bug.cgi?id=150011
    * Fix bug in copying table where we need to create a primary key
    * Don’t set language to none on defined styles (tdf#126657, tdf#145104)
      https://bugs.documentfoundation.org/show_bug.cgi?id=126657
      https://bugs.documentfoundation.org/show_bug.cgi?id=145104
  [ * Change shortcut of inserting Math objects to Alt+Shift+E (tdf#150682)
      https://bugs.documentfoundation.org/show_bug.cgi?id=150682
      DROPPED from this SRU ]

[Testing]

 * Upstream testing. Bugs fixed upstream typically include unit/regression tests, and the release itself is extensively exercised (both in an automated manner and manually).

  * A recent set of upstream's automated jenkins testing can be found here:
    https://ci.libreoffice.org/job/gerrit_73/2020/

  * More information about the upstream QA testing can be found here:
    * Automated tests
      https://wiki.documentfoundation.org/QA/Testing/Automated_Tests
    * Automated UI tests
      https://wiki.documentfoundation.org/Development/UITests
    * Regression tests
      https://wiki.documentfoundation.org/QA/Testing/Regression_Tests
    * Feature tests
      https://wiki.documentfoundation.org/QA/Testing/Feature_Tests

 * Launchpad testing. The libreoffice packages include autopkgtests that were run and verified as passing.
    Tested build can be found at https://launchpad.net/~ricotz/+archive/ubuntu/ppa/+sourcepub/14441847/+listing-archive-extra

    * [amd64] https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ricotz-ppa/jammy/amd64/libr/libreoffice/20230118_041112_1de9d@/log.gz
    * [arm64] https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ricotz-ppa/jammy/arm64/libr/libreoffice/20230117_123847_1a3af@/log.gz
    * [armhf] https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ricotz-ppa/jammy/armhf/libr/libreoffice/20230117_105914_aa586@/log.gz
    * [ppc64el] https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ricotz-ppa/jammy/ppc64el/libr/libreoffice/20230117_111546_c7e43@/log.gz
    * [s390x] https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ricotz-ppa/jammy/s390x/libr/libreoffice/20230117_150924_08154@/log.gz
 * General smoke testing of all the applications in the office suite were carried out by going through the manual testplan as documented by: https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice

[Regression Potential]

 * A combination of autopkgtests and careful smoke testing as described above should provide reasonable confidence that no regressions sneaked in.

[Chris Halse Rogers (raof)]

Mostly looks ok, but ubuntu-0001-tdf-150682-Change-shortcut-of-inserting-Math-objects.patch doesn't seem like an appropriate change for an SRU.

By my understanding this will change the shortcut for "insert math object" on everyone's system. Is my understanding correct? If so, I think this behaviour change is inappropriate for an SRU. Additionally, the linked bug refers to the shortcut being problematic *on Windows*; is this actually a problem for Ubuntu users?

Finally, ubuntu-0005-make-ValueTransfer-easier-to-understand.patch looks (from a brief skim) like a refactoring patch which is not expected to make any functional difference; is this the case?

[Rico Tzschichholz (ricotz)]

Hey Chris, thank you for reviewing.

Yes, ubuntu-0001-tdf-150682-Change-shortcut-of-inserting-Math-objects.patch is a behavior change, but "CTRL+ALT+=" is not working at all on many keyboard layouts while "=" requires an additional modifier by itself. This is not restricted to Windows platform, but very well concerns Ubuntu users too. Please see the commit message for additional information (This is change present in libreoffice 7.4+)

I believe that ubuntu-0005-make-ValueTransfer-easier-to-understand.patch is follow-up clean-up patch which indeed is not meant to add actual changes. Still picking it up seems appropriate while it got written and tested together with ubuntu-0003-Fix-bug-in-copying-table-where-we-need-to-create-a-p.patch and ubuntu-0004-error-when-copying-table-and-the-copy-table-wizard-c.patch.

[Chris Halse Rogers (raof)]

Is there a way to make the the shortcut change only apply on layouts where this is a problem? I think this is close enough to deliberately introducing a regression (“my keyboard shortcut doesn't work anymore”) that it's inappropriate for an SRU as-is.

[Rico Tzschichholz (ricotz)]

I think writing a custom patch would be way more fragile than going with an existing upstream solution. So I am going to drop the Alt+Shift+E patch from this SRU.

[Chris Halse Rogers (raof)]

Hello Rico, or anyone else affected,

Accepted libreoffice into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libreoffice/1:7.3.7-0ubuntu0.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Rico Tzschichholz (ricotz)]

Upgraded libreoffice from 1:7.3.7-0ubuntu22.04.1 to 1:7.3.7-0ubuntu0.22.04.2 from jammy-proposed in a clean and up-to-date jammy amd64 VM, and successfully ran test plan at https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for libreoffice has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libreoffice - 1:7.3.7-0ubuntu0.22.04.2

---------------
libreoffice (1:7.3.7-0ubuntu0.22.04.2) jammy; urgency=medium

  * Cherry picked bug fixes release (LP: #2003335)

  * Don’t set language to none on defined styles (tdf#126657, tdf#145104)
    - ubuntu-0002-tdf-126657-tdf-145104-Don-t-set-language-to-none-on-.patch
  * Fix bug in copying table where we need to create a primary key
    - ubuntu-0003-Fix-bug-in-copying-table-where-we-need-to-create-a-p.patch
    - ubuntu-0004-error-when-copying-table-and-the-copy-table-wizard-c.patch
    - ubuntu-0005-make-ValueTransfer-easier-to-understand.patch
  * Switch default currency HRK Croatian Kuna to EUR Euro
    - ubuntu-0006-Related-tdf-150011-Add-HRK-Croatian-Kuna-to-Euro-con.patch
    - ubuntu-0007-Resolves-tdf-150011-Switch-default-currency-HRK-Croa.patch

 -- Rico Tzschichholz <email address hidden> Thu, 02 Feb 2023 12:42:49 +0100