autopkgtests flaky on s390x

Bug #1832360 reported by Olivier Tilloy on 2019-06-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libreoffice (Ubuntu)
Medium
Marcus Tomlinson

Bug Description

The "uno" autopkgtest has been failing quite a few times recently, and this seems to have gotten worse on eoan (it happened on disco already). See http://autopkgtest.ubuntu.com/packages/libr/libreoffice/eoan/s390x.

    ### float does not match! failed
    struct comparison test failed
    ### float does not match! failed
    recursive test results failed
    standard test failed
    exception occurred: error: test failed!

I'm attaching the relevant excerpt of the most recent failed test run.

Olivier Tilloy (osomon) wrote :
Changed in libreoffice (Ubuntu):
status: New → In Progress
importance: Undecided → Medium

So turns out the test case is being a little naughty by comparing floats with a "==", which s390x in particular does not handling so well.

You can see in the debug log that the test float value is set to 17.0815f but actually gets stored as '17.081499', '17.081501' and '17.081503' in various places.

Ideally the test should be comparing floats by difference within the bounds of an epsilon.

Preparing a patch for this now.

no longer affects: df-libreoffice
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:6.2.4-0ubuntu2

---------------
libreoffice (1:6.2.4-0ubuntu2) eoan; urgency=medium

  * debian/patches/fix-flaky-bridgetest.diff: add safer float comparisons to
    bridgetest equals() (LP: #1832360)

 -- Marcus Tomlinson <email address hidden> Mon, 17 Jun 2019 13:18:01 +0100

Changed in libreoffice (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.