[Upstream] Applying autocorrect to text with URLs causes Writer to hang

[Tim Hamilton]

When attempting to apply autocorrect to text that contains URLs to convert to hyperlinks (https://ask.libreoffice.org/en/question/6393/how-may-i-do-writer-recognize-hyperlinks-automatically/) causes Writer to stop responding requiring a force quit.

Version 6.2.2.2

Severity: Normal.

Reproducible:
Always

Steps to reproduce:
Open a new Writer document.
Turn URL recognition on - Tools | Auto Correct | Auto correct options | Options tab
Insert text containing URLs (see below)
Set paragraph style to default
Apply auto correct - Tools | Auto Correct | Apply

Actual result:
Libre Office hangs

Expected result:
Auto correct applied, text urls converted to hyperlinks

Bug is evident in both deb and snap versions of LO, but not in earlier 5.x or 6.x series.

Sample test with URLs:
This webpage is and example of a url that should be able to be converted to a hyperlink <https://www.example.com/>. As is this page <http://www.example.org/> and this page <http://adjustment.example.com/aunt>.

These pages should also be able to be converted using the method linked to above <https://www.example.org/#brother>, <http://www.example.com/airport.php#blade>.

A typical use for a page like this would be a bibliography or reference list <http://www.example.com/>.

ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: libreoffice (not installed)
ProcVersionSignature: Ubuntu 5.0.0-13.14-generic 5.0.6
Uname: Linux 5.0.0-13-generic x86_64
ApportVersion: 2.20.10-0ubuntu27
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon May 13 20:38:07 2019
InstallationDate: Installed on 2019-05-11 (2 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
SourcePackage: libreoffice
UpgradeStatus: No upgrade log present (probably fresh install)

[Marcus Tomlinson (marcustomlinson)]

Hi Tim, thank you for your report.

This issue looks to be upstream. I've just confirmed this on Debian Stretch using LibreOffice's own debs from: https://www.libreoffice.org/download/download/?type=deb-x86_64

Would you mind filing an upstream bug report for this at https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice&format=guided and sharing the link to that bug here?

Thank you!

[Marcus Tomlinson (marcustomlinson)]

Sorry, I should mention that this issue was reproduced using the 6.2.3 download. I subsequently downloaded and installed the 6.1.6 deb and the issue is not present there.

[Tim Hamilton (pseudomorph)]

Description:
When attempting to apply autocorrect to text that contains URLs to convert to hyperlinks (https://ask.libreoffice.org/en/question/6393/how-may-i-do-writer-recognize-hyperlinks-automatically/) causes Writer to stop responding requiring a force quit.

Steps to Reproduce:
1. Open a new Writer document.
2. Turn URL recognition on - Tools | Auto Correct | Auto correct options | Options tab
3. Insert text containing URLs (see below)
4. Set paragraph style to default
5. Apply auto correct - Tools | Auto Correct | Apply

Actual Results:
Libre Office hangs

Expected Results:
Auto correct applied, text urls converted to hyperlinks

Reproducible: Always

User Profile Reset: No

Additional Info:
Bug is evident in both deb and snap versions of LO, but not in earlier 5.x or 6.x series.

Sample test with URLs:
This webpage is and example of a url that should be able to be converted to a hyperlink <https://www.example.com/>. As is this page <http://www.example.org/> and this page <http://adjustment.example.com/aunt>.

These pages should also be able to be converted using the method linked to above <https://www.example.org/#brother>, <http://www.example.com/airport.php#blade>.

A typical use for a page like this would be a bibliography or reference list <http://www.example.com/>.

Bug confirmed to be upstream, see https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1828811

[Tim Hamilton (pseudomorph)]

Thanks Marcus. Filed upstream at: https://bugs.documentfoundation.org/show_bug.cgi?id=125261

[Xiscofauli (xiscofauli)]

I can't reproduce it in

Version: 6.3.0.0.alpha0+
Build ID: 630db80d17616d635cf2e5f1d5a0852428b794a3
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build

[timur (ba.timur)]

Repro in Windows LO 6.2 64-bit and current 6.3+ 32-bit. No repro 6.1. So I'll confirm.
Not clear why Xisco wasn't able to reproduce.

[Xiscofauli (xiscofauli)]

Ok, I can reproduce it in

Version: 6.3.0.0.alpha0+
Build ID: 630db80d17616d635cf2e5f1d5a0852428b794a3
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

I didn't set the paragraph style to default...

[Xiscofauli (xiscofauli)]

Regression introduced by:

author Michael Stahl <email address hidden> 2018-11-28 17:09:22 +0100
committer Thorsten Behrens <email address hidden> 2018-12-07 13:08:58 +0100
commit 938f8a6b387828b8c18819184c47a5245bdfac8a (patch)
tree df6c9c2c7e9e4223e1f88e6fb946e4302d1aaae9
parent 4cf5a46f16dec8ce16c6662ce5c17903e28b8fa3 (diff)
sw_redlinehide_4a: SwAutoFormat::AutoCorrect()

Bisected with: bibisect-linux64-6.2

Adding Cc: to Michael Stahl

[Libreoffice-commits (libreoffice-commits)]

Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/afb566b6d3b15b013007a71efe0949800aa22666%5E%21

tdf#125261 sw_redlinehide: fix inf. loop in SwAutoFormat::AutoCorrect()

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[Michael-stahl (michael-stahl)]

fixed on master

[Libreoffice-commits (libreoffice-commits)]

Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/b25317070ed36cc1c1e588871b4dd7e77d0a7f49%5E%21

tdf#125261 sw_redlinehide: fix inf. loop in SwAutoFormat::AutoCorrect()

It will be available in 6.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[Xiscofauli (xiscofauli)]

Verified in

Version: 6.3.0.0.alpha1+
Build ID: a3e649c3384d19a5ad540c3d65d5f79b66fd9090
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Michael Stahl, thanks for fixing this issue!!

[Libreoffice-commits (libreoffice-commits)]

Zdeněk Crhonek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9551a1ed54fc8131b52ee58114398924196313fd%5E%21

uitest for bug tdf#125261

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[Libreoffice-commits (libreoffice-commits)]

Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-6-2-4":

https://git.libreoffice.org/core/+/3a93e29c601078970fb6b2b27d3d9865a93ad4ad%5E%21

tdf#125261 sw_redlinehide: fix inf. loop in SwAutoFormat::AutoCorrect()

It will be available in 6.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

[Marcus Tomlinson (marcustomlinson)]

6.2.4 released to Eoan.

[Libreoffice-commits (libreoffice-commits)]

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1391b1b3eb3d28c7a606a3f0357eef6ca71267e7

tdf#125261: move UItest to CppunitTest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.