FFe UI exception for LibreOffice Breeze Icons

Bug #1435764 reported by Jonathan Riddell on 2015-03-24
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libreoffice (Ubuntu)
Undecided
Björn Michaelsen

Bug Description

The Kubuntu team would like to include Breeze icons with Libreoffice. This is something we've been working with upstream Libreoffice on since last year.

Screenshot:
http://starsky.19inch.net/~jr/tmp/libreoffice.png

Kubuntu todo item:
https://trello.com/c/pXZdfAL4/18-port-libreoffice-themeing-to-kf5

This involves taking a patch which I wrote which is now in upstream master and a tar of the breeze icons

Patch:
http://starsky.19inch.net/~jr/tmp/kubuntu_breeze-icons.diff

complete package is in my PPA
https://launchpad.net/~jr/+archive/ubuntu/ppa/+packages

The Kubuntu Docs Team approve this 1000 times yes.

On Tuesday, March 24, 2015 05:59:08 PM you wrote:
> The Kubuntu Docs Team approve this 1000 times yes.

Still waiting to hear from the LO maintainer.

So the patch looks innocent enough. I assume this is for LibreOffice 4.4/vivid -- not earlier, right? And LibreOffice 4.5/w-series has the patch upstream already.

And just to clarify: This is just about this small patch, you are fine with the media (the icons themselves) as they are on the 4.4 upstream branch/release tarballs?

Changed in libreoffice (Ubuntu):
status: New → Incomplete
Jonathan Riddell (jr) wrote :

Yes the patch is upstream in 4.5

It's also adding the breeze icons tar which is a tar of the directory from upstream
debdiff
http://starsky.19inch.net/~jr/tmp/libreoffice_4.4.1-0ubuntu2.debdiff

sounds good, merging in.

Changed in libreoffice (Ubuntu):
status: Incomplete → In Progress
assignee: nobody → Björn Michaelsen (bjoern-michaelsen)
Scott Kitterman (kitterman) wrote :

Great. FFe approved.

A test build including this has been copied to:

https://launchpad.net/~libreoffice/+archive/ubuntu/ppa/+packages
https://launchpad.net/~libreoffice/+archive/ubuntu/libreoffice-4-4/+packages

as libreoffice-1:4.4.1-0ubuntu2~vivid2 for testing.

Changed in libreoffice (Ubuntu):
status: In Progress → Fix Committed
Marcin Sągol (soee) wrote :

I have tested it (from fresh ppa) on Kubuntu Vivid and Breeze icons seems to work fine.
One question though: the 'New' document icon should be white as it is now for me?

Jonathan Riddell (jr) wrote :

The breeze icons snapshot I took is a few days old and there have been fixes since then but let's get this one in first then update :)

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:4.4.1-0ubuntu2

---------------
libreoffice (1:4.4.1-0ubuntu2) vivid; urgency=medium

  [ Bjoern Michaelsen ]
  * merge from Debian:
    - debian/control.ogltrans.in: capitalize "impress" in description
      (closes: #779479)
    - debian/rules: fix logic to not install sound files (closes: #780497)
  * remove obsolete patches
  * update Ubuntu palette

  [ Jonathan Riddell ]
  * Add kubuntu_breeze-icons.diff and breeze.tar.xz with breeze icons
    for Plasma 5 taken from LibreOffice master (LP: #1435764)
 -- Bjoern Michaelsen <email address hidden> Fri, 27 Mar 2015 13:45:50 +0100

Changed in libreoffice (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments