"Use LibreOffice Dialogs" setting is ignored in KDE

[cleary]

Kubuntu 14.04 (KDE Desktop Environment)

[update]
This is now affecting packages from main ubuntu (trusty) repositories:
libreoffice Version: 4.2.8-0ubuntu2 0
qt4-x11 Version: 4:4.8.5+git192-g085f851+dfsg-2ubuntu4.1
[/update]

LibreOffice uses it's native filepicker/save dialogs, regardless of whether the config option "Use LibreOffice Dialogs" is ticked or not.

Related Bugs:
https://bugreports.qt-project.org/browse/QTBUG-38585
https://bugreports.qt-project.org/browse/QTBUG-34614

According to the LO team, both these bugs have patches that address the automatic disabling of Qt dialogs at runtime (if buggy Qt is detected.)

Initial report/discussion on LO bugtracker (now closed) here: https://bugs.freedesktop.org/show_bug.cgi?id=82598

[obsolete]
Packages from this ppa:
https://launchpad.net/~libreoffice

Version: 4.3.0-3ubuntu2~trusty1 (as reported by dpkg, note updated packages as of about 1 hour ago)
or 4.3.0.4 Build ID: 430m0(Build:4) as reported by LibreOffice about dialog.

This is a regression from 4.2.4-0ubuntu2 currently in the main ubuntu security repository.
[/obsolete]

[cleary (bernard-gray)]

Kubuntu 14.04 (KDE Desktop Environment)

Packages from this ppa:
https://launchpad.net/~libreoffice

Version: 4.3.0-0ubuntu1~trusty1 (as reported by dpkg)
or 4.3.0.4 Build ID: 430m0(Build:4) as reported by LibreOffice about dialog.

LibreOffice uses it's native filepicker/save dialogs, regardless of whether the config option "Use LibreOffice Dialogs" is ticked or not.

This is a regression from 4.2.4-0ubuntu2 currently in the security repository.

[cleary (bernard-gray)]

I'm updating the severity of this bug.

Combined with #78845, which closes the filepicker dialog when you click the New Folder icon, not only is the forced use of the native filepicker inconvenient, but it doesn't actually work.

[chris (ign-christian)]

Sorry I can't test with latest LO version in machine with KDE.

But I can confirm it's not happen with LO 4.0.4.2 (from PPA) under Kubuntu 12.04 x86

@Bernard, perhaps you know whether package from LO website have same behavior?

[cleary (bernard-gray)]

(In reply to comment #2)
> Sorry I can't test with latest LO version in machine with KDE.
>
> But I can confirm it's not happen with LO 4.0.4.2 (from PPA) under Kubuntu
> 12.04 x86
>
> @Bernard, perhaps you know whether package from LO website have same
> behavior?

Hi ign_christian,
Tested as you suggested, the site is listing v4.3.0.4 for download.
It is working as expected in that release (albeit #78845 is still present).

I initially attempted to report the bug in Launchpad, but there isn't (or I couldn't find) a way for that particular ppa.

[chris (ign-christian)]

Hi Bernard, thanks for your confirmation. So the bug is only occured in package from PPA.

AFAIK there is a link for official Ubuntu repository, but I don't if that also used for PPA: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+filebug

After bug filed there, please link that bug here. We'll know soon if your report with that link rejected ;)

[chris (ign-christian)]

(In reply to comment #3)
> It is working as expected in that release (albeit #78845 is still present).
Bug 78845 fixed in 4.3.1 (see the whiteboard). If you still reproduce that issue with 4.3.1 release or daily, just drop a comment in that bug.

[Momonasmon (momonasmon)]

Hi Bernard,

This is not our bug. You should open a bug against Qt4 package of Ubuntu, and ask them to add the patch from https://bugreports.qt-project.org/browse/QTBUG-34614.

[cleary (bernard-gray)]

(In reply to comment #6)
> Hi Bernard,
>
> This is not our bug. You should open a bug against Qt4 package of Ubuntu,
> and ask them to add the patch from
> https://bugreports.qt-project.org/browse/QTBUG-34614.

Hi Maxim,
Thanks for the reply, I'm happy to make the report on the QT tracker, but I can't work out how the QT Clipboard bug you linked to is related to my issue - could you clarify this for me?

[Momonasmon (momonasmon)]

(In reply to comment #7)
> I'm happy to make the report on the QT tracker,
Actually I meant the Ubuntu tracker, for the qt4-x11 package.

> but I
> can't work out how the QT Clipboard bug you linked to is related to my issue
> - could you clarify this for me?
This is explained in the Qt bug I referenced. There are also some comments in the LO code, like [1]. (In also mentions QTBUG-37380, but Ubuntu already has this patch [2]).

And BTW, adding also https://bugreports.qt-project.org/browse/QTBUG-38585 is recommended.

[1] http://opengrok.libreoffice.org/xref/core/vcl/unx/kde4/KDEXLib.cxx#189
[2] https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/1290514

[Momonasmon (momonasmon)]

(In reply to comment #7)
> but I
> can't work out how the QT Clipboard bug you linked to is related to my issue
In short: To avoid crashes, we disable Qt dialogs at runtime, if buggy Qt is detected.

[cleary (bernard-gray)]

(In reply to comment #9)
> (In reply to comment #7)
> > but I
> > can't work out how the QT Clipboard bug you linked to is related to my issue
> In short: To avoid crashes, we disable Qt dialogs at runtime, if buggy Qt is
> detected.

Thanks for your assistance :)

Bug Logged:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1359486

(In reply to comment #4)
> Hi Bernard, thanks for your confirmation. So the bug is only occured in
> package from PPA.
>
> AFAIK there is a link for official Ubuntu repository, but I don't if that
> also used for PPA:
> https://bugs.launchpad.net/ubuntu/+source/libreoffice/+filebug
>
> After bug filed there, please link that bug here. We'll know soon if your
> report with that link rejected ;)

I missed this when I was looking previously, but they have a link to an explanation of how to report bugs against the PPA package here:
https://lists.launchpad.net/libreoffice/msg00072.html

[Björn Michaelsen (bjoern-michaelsen)]

As written in the description LibreOffice 4.3 prevents to use a broken Qt4 version, which is likely the best it can do. A fix for trusty would need to happen on the Qt4 side.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[cleary (bernard-gray)]

I've done a rebuild of qt4-x11 source on ubuntu 14.04 and I can confirm that the patches at:
https://bugreports.qt-project.org/browse/QTBUG-34614
and
https://bugreports.qt-project.org/browse/QTBUG-38585

do resolve this bug.

According to the comment at the bottom of each of these reports:
https://bugreports.qt-project.org/browse/QTBUG-34614?focusedCommentId=247683&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-247683

It requires going through https://codereview.qt-project.org/

Is there any extra work involved to make that happen? I would've thought that any patches submitted to the bug tracker would be (semi-)automatically considered for the code review

[Gruber-6 (gruber-6)]

I observed the same problem in opensuse 13.1 from LO 4.2.0 on.

As the named qt-bugs were patched in my latest tests
(see http://bugzilla.opensuse.org/show_bug.cgi?id=899045) I suppose that the cause is on the libreoffice side.

I suppose no actual linux distribution works correct in this way.

[cleary (bernard-gray)]

(In reply to comment #11)
> I observed the same problem in opensuse 13.1 from LO 4.2.0 on.
>
> As the named qt-bugs were patched in my latest tests
> (see http://bugzilla.opensuse.org/show_bug.cgi?id=899045) I suppose that the
> cause is on the libreoffice side.
>
> I suppose no actual linux distribution works correct in this way.

Hi Stefan,
I did a rebuild of qt4-x11 with the patches applied on Ubuntu 14.04.1 and it actually resolved the issue...

Info on the launchpad bug:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1359486/comments/14

[Gruber-6 (gruber-6)]

Hello Bernard
(In reply to comment #12)
> I did a rebuild of qt4-x11 with the patches applied on Ubuntu 14.04.1 and it
> actually resolved the issue...

I read your post before at launchpad, but for my excuse I'm not familiar with the ubuntu world but with opensuse's. Is this patched build publicly available yet or is it your private build? What is the easiest way to test it?

I just had a try with Kubuntu 14.10 beta without success concerning our problem: still crappy LO-Filepicker instead of KDE/Qt-dialog...

Your report gave me hope, but applying the same patches at opensuse obviously didn't solve it. So there seem to be more traps...

[cleary (bernard-gray)]

(In reply to Stefan Gruber from comment #13)
> Hello Bernard
> (In reply to comment #12)
> > I did a rebuild of qt4-x11 with the patches applied on Ubuntu 14.04.1 and it
> > actually resolved the issue...
>
> I read your post before at launchpad, but for my excuse I'm not familiar
> with the ubuntu world but with opensuse's. Is this patched build publicly
> available yet or is it your private build? What is the easiest way to test
> it?

I've created a ppa with the patched package - right at this moment, the package has built successfully, but the binaries are pending publication. By the time you read this I hope it will be ready to go:

https://launchpad.net/~bernard-gray/+archive/ubuntu/1359486

sudo add-apt-repository ppa:bernard-gray/1359486

[cleary (bernard-gray)]

I've created a ppa with the patched package - right at this moment, the package has built successfully, but the binaries are pending publication. By the time you read this I hope it will be ready to go:

https://launchpad.net/~bernard-gray/+archive/ubuntu/1359486

sudo add-apt-repository ppa:bernard-gray/1359486

[Jmadero-dev (jmadero-dev)]

Never confirmed by QA team - moving to UNCONFIRMED.

[Momonasmon (momonasmon)]

(In reply to Joel Madero from comment #15)
> Never confirmed by QA team - moving to UNCONFIRMED.
Actually NOTABUG/NOTOURBUG could be a better resolution for this bug. See comment 6 and comment 9. From our side it seems to work as designed. And we have several confirmations that it actually works - see comment 12, and the openSUSE bug that in 'See Also'. I also can confirm that it works for me in Fedora 20. So WORKSFORME also would be appropriate here.

[Momonasmon (momonasmon)]

*** Bug 86285 has been marked as a duplicate of this bug. ***

[Murz (murznn)]

Same problem in Ubuntu 14.10 Utopic, but ppa:bernard-gray/1359486 have packages only for 14.04 Trusty.
cleary (bernard-gray), can you add support for Ubuntu 14.10 Utopic in your ppa?

[cleary (bernard-gray)]

@Murz - it's building for utopic now

I'm not planning to support more than I need, but since you asked so nicely ;)

[Mark (mark-wege)]

@bernhard: Thanks for doing this. I am grateful too :-)

[cleary (bernard-gray)]

This is now affecting packages from main ubuntu repositories:
libreoffice Version: 4.2.8-0ubuntu2 0
qt4-x11 Version: 4:4.8.5+git192-g085f851+dfsg-2ubuntu4.1

I'll be updating my ppa shortly

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Murz (murznn)]

cleary (bernard-gray), can you post link to your ppa with fixed packages? Thanks!

[cleary (bernard-gray)]

Hi, sorry I've been off getting married :P

It's mentioned further back in the thread:
https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/1359486/comments/15

https://launchpad.net/~bernard-gray/+archive/ubuntu/1359486

Packages for Trusty LTS only I'm afraid. The binary + source package is so large it can only fit one build in the ppa now

[Murz (murznn)]

cleary, thanks for the info! Repository size: 1.1 GiB (52.62%) of 2.0 GiB - yes, there are no free space to create builds for other versions of Ubuntu, but I use 14.10 :(
Will wait when this will be officially fixed in Ubuntu packages...

[cleary (bernard-gray)]

@Murz - it's time to upgrade. 14.10 is EOL in 2 weeks!

http://fridge.ubuntu.com/2015/07/03/ubuntu-14-10-utopic-unicorn-reaches-end-of-life-on-july-23-2015/

[Adolfo Jayme Barrientos (fitojb)]

LibreOffice has moved to Qt5 in 6.2.