[upstream] RTL Spreadsheet Insert Cells

[EliCoten]

When using a right-to-left spreadsheet, right clicking and selected "insert cells" shows the normal LTR option to shift cells right, although when used it actually shifts cells left.

I believe that shifting cells left is the correct behaviour in this case, but the text of the option should be changed to read "shift cells left". This was first noticed when using the Hebrew language user interface, but the problem is present when using English UI too.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: libreoffice-calc 1:3.5.7-0ubuntu4
ProcVersionSignature: Ubuntu 3.2.0-38.61-generic 3.2.37
Uname: Linux 3.2.0-38-generic i686
ApportVersion: 2.0.1-0ubuntu17.1
Architecture: i386
CheckboxSubmission: ad9a15703e19217cb3448f881e125f6a
CheckboxSystem: abc83e3988b72e7c3a9b3aa684cb92fd
Date: Sun Mar 3 00:47:21 2013
MarkForUpload: True
SourcePackage: libreoffice
UpgradeStatus: Upgraded to precise on 2012-05-01 (305 days ago)

[Olivier Tilloy (osomon)]

@EliCoten: is this issue still present in recent versions of LibreOffice in a supported Ubuntu release?

If so, would you mind filing an upstream bug report at https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice&format=guided and sharing the link to that bug here?

Thanks!

[Elicoten (elicoten)]

Description:
Dialog option text needs to be changed for right to left spreadsheets, currently it could cause confusion as what it does (correctly) is actually opposite to what it says (but the option is mislabelled, the behaviour seems correct).

Steps to Reproduce:
1.Open/create a right to left spreadsheet (with some data in it)
2. Right click on a cell
3. Select "Insert..."

Actual Results:
The second option on the dialog box says "Shift cells right".

Expected Results:
For right to left spreadsheets, this should actually say "Shift cells left"

Reproducible: Always

User Profile Reset: No

Additional Info:
The functionality works correctly, shifting cells to the left - only the dialog text needs to be changed.

[EliCoten (launchpad-elicoten)]

Still present in LibreOffice 6.1.5.2
Build ID: 1:6.1.5-0ubuntu0.18.10.1

https://bugs.documentfoundation.org/show_bug.cgi?id=125868

[Heiko-tietze-g (heiko-tietze-g)]

Shall we rename it to "Shift left/right" or make the text depending on RTL settings?

[Thomas-lendo (thomas-lendo)]

"Shift left/right" sounds like a confusing title. Better is to make it text direction dependent.

[Heiko-tietze-g (heiko-tietze-g)]

In Writer we use Left/Top, Right/Bottom for paragraph style > alignment depending on horizontal/vertical direction. The dynamic label might be not so easy to implement. How about "Shift forward" and backward for left/right?

[Thomas-lendo (thomas-lendo)]

(In reply to Heiko Tietze from comment #3)
> How about "Shift forward" and backward for left/right?
Sounds ok. Is forward to the right in LTR?

[Heiko-tietze-g (heiko-tietze-g)]

(In reply to Thomas Lendo from comment #4)
> (In reply to Heiko Tietze from comment #3)
> > How about "Shift forward" and backward for left/right?
> Sounds ok. Is forward to the right in LTR?

Would be my understanding but the drawback of not perfectly terms with forward/backward instead of left/right is clear.

[Thomas-lendo (thomas-lendo)]

The insert column commands are titled "before" and "after" and the insert rows commands are titled "above" and "below".

If used in RTL cells, the behavior also is false like the text in the 'Insert...' dialog. If something will be changed here also the 'Delete...' dialog and the above mentioned column/row commands must be taken into account.

I doubt this is technically possible? What with only partially RTL columns/rows? How could LibreOffice decide if it's LTR, RTL, whatever?

But to come to this bug report: As columns and rows commands were renamed, also the 'Delete...' and 'Insert...' dialog must be changed:

* Insert... > Shift cells right ----> Shift cells after
* Delete... > Shift cells left ----> Shift cells before

This isn't what the bug opener wants but it would be at least the same naming than in other commands.

[Heiko-tietze-g (heiko-tietze-g)]

"Shift before"... I wouldn't understand this command. So let's not make compromises.

I'm pretty sure we can evaluate LTR/RTL and update the command label and the various captions accordingly.

[Marcus Tomlinson (marcustomlinson)]

Synchronising bug status with upstream.

[Libreoffice-commits (libreoffice-commits)]

Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0fd2012dcedc8f98b14dc478c71f9312d4c26c85

Resolves tdf#125868 - Insert dialog text in case of RTL

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.