[upstream] Search and replace, with tracked changes on, changing only format of text, causes Writer to hang

Bug #1126858 reported by Christopher Barrington-Leigh on 2013-02-16
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LibreOffice
Confirmed
Medium
libreoffice (Ubuntu)
Undecided
Unassigned

Bug Description

Create new text document with contents "Hello, World".
Turn on change tracking (under Edit).
Select Find and Replace (under Edit).
Put "Hello" (no quotes) in both the find and the replace boxes.
Click on "More".
Put cursor in Replace box.
Click on Format.
Set it to, say Italic (leave other options empty). Accept.

And now, for the fatal part: Click "Replace all".
If you just replace one, you'll see why the latter fails. The replacement value gets inserted beofre the original, so then it continues on and sees the original again... ad infinitum.

What should happen: If it just put its position after the original text when searching and replacing, it wouldn't have this problem.

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: libreoffice (not installed)
ProcVersionSignature: Ubuntu 3.5.0-23.35-generic 3.5.7.2
Uname: Linux 3.5.0-23-generic x86_64
ApportVersion: 2.6.1-0ubuntu10
Architecture: amd64
Date: Fri Feb 15 21:37:14 2013
InstallationDate: Installed on 2012-12-13 (65 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.5)
MarkForUpload: True
SourcePackage: libreoffice
UpgradeStatus: No upgrade log present (probably fresh install)

If you turn on recording and showing changes in document find and replace will replace even things already deleted. Example:

1. Create new document.
2. Write "This is a document".
3. Turn on showing and recording changes.
4. Delete the word "document" so you have "This is a".
5. Replace document with "file".
6. The document will contain: "This is a file." instead of "This is a".

PS. In point 5 I mean "Use search and replace to change word 'document' to 'file'". Sorry for being vague.

I tested the bug as described. I can confirm the bug on my system.

Furthermore, the bug is even more serious than described:

* First problem as described by Tomasz: The replace deleted word is active/undeleted after search&replace. This actually destroys the written text.

* Second problem: After hitting "Replace all" a couple of times, it will keep replacing the deleted text with the new text. The dialog never displays "Word not found" and hence does not stop.

Due to the reason that data can be actually made unusable/unreadible, I change the importance to high/major. I hope this is okay.

System: Ubuntu 10.4./Gnome, LibreOffice 3.3.2 PPA, Intel 32Bit

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html

No longer does find & replace work for me.

I have deleted LibeOffice & reinstalled & no change.

Maybe there is a report that I didn't see about this or maybe only me?

I am only a user so not to good & this as this is the first time I have tried to report a problem.

This severe regression is still there in LibreOffice 3.5.
I just 'destroyed' a document myself where track changes was activated (and extensively used) and I wanted to search&replace something.

Please increase the severity of this bug!

Still a problem in LO 3.6.2.2. In summary: When "Show tracked changes" is active, "Find" will find text that has been deleted with "track changes" activated. "Find & replace" will replace already deleted text. When you do "Find & replace" with activated "track changes", it will replace the same (already deleted) text again and again. "Replace all" works insofar as it replaces each occurance only once.

Actually it can be useful if "Find" also searches tracked deletions - after all you use "track changes" to be able to keep deleted text in the document. But I think it's usually not what you want. So you would have to disable "show tracked changes" just to do a "Find". I cannot imagine a situation where you would like already deleted text to be replaced by newly inserted text.

It's definitely a bug that LO does not at least move the cursor behind the replaced text when you choose "Replace" in the "Find & replace" dialogue with "track changes" activated. That leads to the same text being replaced again and again.

please somebody tell me which OOo/LO version did not have this bug.

i can reproduce it going back to OOo 3.0.1, so doesn't look like a regression.

I can't remember that this has ever worked differently. The corresponding OOo bug was filed in 2007 for OOo 2.3:
https://issues.apache.org/ooo/show_bug.cgi?id=82591

sam wytoski (sam-wytoski) wrote :

i have followed your steps through trying to recreate this bug.
using:
libreoffice-writer 1:3.6.2~rc2-0ubuntu4
Ubuntu 12.10 (quantal)
gnome 3.6.0 (Ubuntu 2012-10-04)
kernel 3.5.0-24-generic (#37-Ubuntu SMP Thu Feb 7 01:50:30 UTC 2013)
amd64

i was unable to recreate this bug with my system

Changed in libreoffice (Ubuntu):
status: New → Incomplete

I just tried again and find the same results I advertised.
Why does my first entry not specify the version of LibreOffice?
The "Help-About" box in LibreOffice says: Version 3.6.2.2 (Build ID: 360m1(Build:2))

So.. Since my report said "not installed" (ie I was just using the Libreoffice that came with the distro, rather than as its own package??)

So I installed LibreOffice, redid my test (same result)
And the Help-About box says the same thing, too.

Changed in libreoffice (Ubuntu):
status: Incomplete → Opinion
status: Opinion → Incomplete
status: Incomplete → New

Christopher Barrington-Leigh, thank you for reporting this and helping make Ubuntu better. Could you please demonstrate how to reproduce this bug with a screencast via https://help.ubuntu.com/community/Screencast ?

Changed in libreoffice (Ubuntu):
status: New → Incomplete

Righto. Here it is, just as described.

Changed in libreoffice (Ubuntu):
status: Incomplete → Invalid

Hi Christopher Penalver.

The application locks up and I have to destroy the process. Maybe could you explain why you are saying there's no infinite loop? I gave both a theory for why it happens and evidence of it happening, so more explanation from you to explain my mistake would be kind.

Christopher Barrington-Leigh, I beg your pardon as my previously rationale was incorrect. This issue is reproducible in Xubuntu as demonstrated in your screencast. Hence, the issue you are reporting is an upstream one. It would be nice if somebody having it could send the bug to the developers of the software by following the instructions verbatim at http://wiki.documentfoundation.org/BugReport . If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about the status. Thanks in advance.

Helpful bug reporting tips:
https://help.ubuntu.com/community/ReportingBugs

 lsb_release -rd
Description: Ubuntu 13.04
Release: 13.04

apt-cache policy libreoffice-writer
libreoffice-writer:
  Installed: 1:4.0.2-0ubuntu1
  Candidate: 1:4.0.2-0ubuntu1
  Version table:
 *** 1:4.0.2-0ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ raring/main i386 Packages
        100 /var/lib/dpkg/status

Version: 4.2.0.0.alpha0+
Build ID: 979def88090633bfee0e0445b19999a1dac71ed
Microsoft Windows Vista Business x86 6.0.6002 Service Pack 2 Build 6002

Status -> Triaged
Importance -> Medium

Changed in libreoffice (Ubuntu):
status: Invalid → Confirmed
summary: - text: Search and replace, with tracked changes on, when changing only
- format of text, causes fatal infinite loop
+ Search and replace, with tracked changes on, changing only format of
+ text, causes Writer to hang
tags: added: raring

Create new text document with contents "Hello, World".
Turn on change tracking (under Edit).
Select Find and Replace (under Edit).
Put "Hello" (no quotes) in both the find and the replace boxes.
Click on "More".
Put cursor in Replace box.
Click on Format.
Set it to, say Italic (leave other options empty). Accept.

And now, for the fatal part: Click "Replace all".
If you just replace one, you'll see why the latter fails. The replacement value gets inserted beofre the original, so then it continues on and sees the original again... ad infinitum.

What should happen: If it just put its position after the original text when searching and replacing, it wouldn't have this problem.

Reproducible in:
Version: 4.2.0.0.alpha0+
Build ID: 979def88090633bfee0e0445b19999a1dac71ed
Microsoft Windows Vista Business x86 6.0.6002 Service Pack 2 Build 6002

Changed in df-libreoffice:
importance: Unknown → Medium
status: Unknown → Confirmed

Bulk change: Bibisected bugs can be assumed to be regressions.

removing erroneously added "regression", see comment #7

According to comment 7 this isn't a regression, thus remove bibisected35
bibisected35older from whiteboard

Changed in libreoffice (Ubuntu):
status: Confirmed → Triaged

Still Reproducible in: 4.5.0.0.alpha0+
a8835936e9d3e19443c63b7b365174254741cf76

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.0.5 or later)
   https://www.libreoffice.org/download/

   If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior

 If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:

1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.

4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2015-09-03

This issue is still present in

Version: 5.0.1.2
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: es-ES (es_ES)

on Windows 7 (64-bit)

Still reproducible in

Version: 5.0.5.2
Build ID: 1:5.0.5~rc2-0ubuntu2
Locale: en-CA (en_CA.UTF-8)

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice
(5.1.5 or 5.2.1 https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of LibreOffice and
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20160920

Bug still present in Version: 5.1.4.2
Build-ID: 1:5.1.4-0ubuntu1

*** Bug 65056 has been marked as a duplicate of this bug. ***

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

This bug still exists in LO 6.0 and is still very annoying.

Example:
If you work with long documents in a team, track changes is often enabled. If you then, for example, replace the British "ise" / "isation" with "ize" / "ization", then you end up with lots of rubbish in the document. LibreOffice Writer does also replace the string in all deleted words and displays the replaced string as not deleted (!). In other words, everywhere in the document are nonsense "ize" / "ization" strings, which you have to manually clean. -> extremely annoying and time-consuming bug!

Version: 6.0.3.2
Build-ID: 1:6.0.3~rc2-0ubuntu0.16.04.1~lo2
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: gtk2;
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

IMHO there are two possible ways to fix this bug:

Either:

(1) Writer should not find search strings in deleted text at all (meaning text deleted in Track Changes mode)

Or:

(2) Writer still finds search strings in all text (including deleted text in Track Changes mode) and also replaces them, but replaced text should be flagged as deleted.

Solution 1 is preferable to solution 2. However, if solution 2 is easier to implement, IMHO it would be also okay.

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

The bug is still present in v 6.1.5.2. I don't have the most recent LO release at hand, so please can somebody test this against the newest version?

Generally, I hope that this bug receives some attention. In every larger project (with track changes), I encountered issues related to this bug that I had to clean manually. Is a fix so complicated?

Version: 6.1.5.2
Build ID: 1:6.1.5-0ubuntu0.18.10.1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3;
Locale: en-GB (de_DE.UTF-8); Calc: group threaded

Changed in df-libreoffice:
importance: Medium → Unknown
status: Confirmed → Unknown
Changed in libreoffice (Ubuntu):
status: Triaged → Fix Released
status: Fix Released → Triaged
summary: - Search and replace, with tracked changes on, changing only format of
- text, causes Writer to hang
+ [upstream] Search and replace, with tracked changes on, changing only
+ format of text, causes Writer to hang
Changed in df-libreoffice:
importance: Unknown → Medium
status: Unknown → Confirmed

*** Bug 128982 has been marked as a duplicate of this bug. ***

Created attachment 159953
Screenshot of Word and Writer side by side after following the steps

Still happens in:

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 151d95376a13907553032efc271fb0a7a27c9782
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win;
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Also: this behavior is the same as in Word.

I cannot re(In reply to NISZ LibreOffice Team from comment #23)
> Created attachment 159953 [details]
> Screenshot of Word and Writer side by side after following the steps
>
> Still happens in:
>
> Version: 7.0.0.0.alpha0+ (x64)
> Build ID: 151d95376a13907553032efc271fb0a7a27c9782
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL:
> win;
> Locale: hu-HU (hu_HU); UI-Language: en-US
> Calc: CL
>
> Also: this behavior is the same as in Word.

I cannot reproduce this issue in Microsoft Word. I have an Office 365 subscription and I only use .docx files.

(In reply to NISZ LibreOffice Team from comment #23)
> Created attachment 159953 [details]
> Screenshot of Word and Writer side by side after following the steps
>
> Still happens in:
>
> Version: 7.0.0.0.alpha0+ (x64)
> Build ID: 151d95376a13907553032efc271fb0a7a27c9782
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL:
> win;
> Locale: hu-HU (hu_HU); UI-Language: en-US
> Calc: CL
>
> Also: this behavior is the same as in Word.

Try replacing document with file a few more times.

Clearly a bug to me, deleted content is still gone even when TC is on (comment 19, option 1). Don't see need for input from UX.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.