[SRU] amqp-tools server parameter unusable
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
librabbitmq (Ubuntu) |
Fix Released
|
Medium
|
Bryce Harrington | ||
Xenial |
Fix Released
|
Low
|
Bryce Harrington | ||
Bionic |
Fix Released
|
Medium
|
Bryce Harrington | ||
Cosmic |
Won't Fix
|
Medium
|
Bryce Harrington | ||
Disco |
Fix Released
|
Medium
|
Bryce Harrington | ||
Eoan |
Fix Released
|
Medium
|
Bryce Harrington |
Bug Description
[Impact]
The --server and -url parameters do not function as documented, due to an upstream coding error that was fixed in release 0.8.1.
[Test Case]
$ sudo apt-get -y install librabbitmq-dev
$ sudo apt-get -y install amqp-tools
### Broken behavior:
$ sudo amqp-consume --server=
both --server and --url options specify server host
### Fixed behavior:
$ sudo apt-add-repository -y ppa:bryce/
$ sudo apt-get -y install librabbitmq-dev
$ sudo amqp-consume --server=
Specifying the port number with --server is deprecated
opening socket to foobar:5672
[Regression Potential]
The patch alters C code to change how command line options are processed. Things to watch for, then, would be mishandling of cli options, or compilation errors during package build. The changes do not alter input handling at all, so static testing should give a high degree of confidence of stability. Also, the alterations are focused on tools, so general operation of librabbitmq should not be affected in any way by the changes.
[Fix]
The upstream patch corrects handling of --server, --url, and other options by reorganizing the logic flow.
[Discussion]
The issue appears not to be a regression from a recent change, but a problem that has existed for quite a while:
librabbitmq | 0.0.1.hg216-1 | precise/universe | source
librabbitmq | 0.4.1-1 | trusty | source
librabbitmq | 0.7.1-1 | xenial/universe | source
librabbitmq | 0.8.0-1build1 | bionic/universe | source
librabbitmq | 0.8.0-1build1 | cosmic/universe | source
librabbitmq | 0.9.0-0.2 | disco | source
librabbitmq | 0.9.0-0.2 | eoan | source
The fix should be backported to bionic and probably cosmic. Earlier releases are probably also affected but probably only worth doing if the patch applies cleanly to them.
[Original Report]
The version of amqp-tools in 18.04.1 LTS (and 14.04 iirc) has a bug which renders parts of the cli unusable:
https:/
1) 18.04.1 LTS bionic
2) 0.8.0-1build1
3) `amqp-consume --server=
4) amqp-consume complains that you cannot use --server and --url together
Related branches
- Christian Ehrhardt (community): Approve
- Canonical Server packageset reviewers: Pending requested
- Canonical Server: Pending requested
-
Diff: 147 lines (+126/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/fix-parameter-processing.patch (+117/-0)
debian/patches/series (+1/-0)
- Christian Ehrhardt (community): Approve
- Canonical Server: Pending requested
- Canonical Server packageset reviewers: Pending requested
-
Diff: 147 lines (+126/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/fix-parameter-processing.patch (+117/-0)
debian/patches/series (+1/-0)
- Christian Ehrhardt (community): Approve
- Canonical Server: Pending requested
- Canonical Server packageset reviewers: Pending requested
-
Diff: 147 lines (+126/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/fix-parameter-processing.patch (+117/-0)
debian/patches/series (+1/-0)
tags: | added: bionic |
tags: | added: server-triage-discuss |
Changed in librabbitmq (Ubuntu Eoan): | |
status: | New → Triaged |
tags: |
added: server-next removed: server-triage-discuss |
Changed in librabbitmq (Ubuntu Bionic): | |
status: | New → Triaged |
summary: |
- amqp-tools server parameter unusable + [SRU] amqp-tools server parameter unusable |
Changed in librabbitmq (Ubuntu Bionic): | |
assignee: | nobody → Bryce Harrington (bryce) |
Changed in librabbitmq (Ubuntu Eoan): | |
assignee: | nobody → Bryce Harrington (bryce) |
tags: | added: patch |
description: | updated |
Changed in librabbitmq (Ubuntu Eoan): | |
status: | Triaged → Fix Released |
Changed in librabbitmq (Ubuntu Disco): | |
status: | New → Fix Released |
importance: | Undecided → Medium |
Changed in librabbitmq (Ubuntu Xenial): | |
importance: | Undecided → Low |
Changed in librabbitmq (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
assignee: | nobody → Bryce Harrington (bryce) |
Changed in librabbitmq (Ubuntu Disco): | |
assignee: | nobody → Bryce Harrington (bryce) |
Changed in librabbitmq (Ubuntu Cosmic): | |
status: | New → Triaged |
description: | updated |
Changed in librabbitmq (Ubuntu Cosmic): | |
status: | Triaged → In Progress |
Changed in librabbitmq (Ubuntu Bionic): | |
status: | Triaged → In Progress |
Changed in librabbitmq (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Bryce Harrington (bryce) |
description: | updated |
Status changed to 'Confirmed' because the bug affects multiple users.