FTBFS: Cannot build with BUG_STAT_MISSING defined

[Heather Ellsworth]

0.3-8 is in hirsute and builds fine with :
gcc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -fPIC -DLINUX_PAM -I. -DBUG_STAT_MISSING -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -UBUG_STAT_MISSING -c pam_alreadyloggedin.c

0.3-9 in impish proposed fails with :
gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wall -fPIC -DLINUX_PAM -I. -DBUG_STAT_MISSING -Wdate-time -D_FORTIFY_SOURCE=2 -c pam_alreadyloggedin.c

Comparing these shows that -D_FILE_OFFSET_BITS=64 and -UBUG_STAT_MISSING were lost in the 0.3-9 release. This comes as a result of the debian/rules being overhauled to use dh sequencer. Before the rules update, it had :

export CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) \
        -D_FILE_OFFSET_BITS=64 \
        -UBUG_STAT_MISSING \

This block is gone in impish, so BUG_STAT_MISSING is no longer being undefined (it is defined over in the makefile.diff). And pam_alreadyloggedin.c uses __xstat if BUG_STAT_MISSING is defined, leading to our failure.

[Heather Ellsworth (hellsworth)]

Fix submitted: https://salsa.debian.org/debian/libpam-alreadyloggedin/-/merge_requests/1

[Launchpad Janitor (janitor)]

This bug was fixed in the package libpam-alreadyloggedin - 0.3-9ubuntu1

---------------
libpam-alreadyloggedin (0.3-9ubuntu1) impish; urgency=medium

  [ Heather Ellsworth ]
  * Update patch to no longer define BUG_STAT_MISSING
    (Closes: #990833, LP: #1935081)

 -- Graham Inggs <email address hidden> Tue, 31 Aug 2021 12:38:54 +0000

[Heather Ellsworth (hellsworth)]

It looks like libpam-alreadyloggedin is pulled directly from debian from the Vcs-Git line so that's why I submitted the fix upstream (still open and untouched): https://salsa.debian.org/debian/libpam-alreadyloggedin/-/merge_requests/1

So is libpam-alreadyloggedin now forked from debian and is it worth it for the ftbfs fix? If so, we should update the vcs-git line to point to it's location in launchpad.

[Gunnar Hjalmarsson (gunnarhj)]

It was temporarily forked so to speak, but I merged and uploaded your Debian MR, and have now sync'ed version 0.3-10 from unstable.

[Heather Ellsworth (hellsworth)]

Thanks so much for merging and explaining the temporary fork :)