2011-04-23 16:38:06 |
Benoit Grégoire |
bug |
|
|
added bug |
2011-04-23 16:39:01 |
Benoit Grégoire |
branch linked |
|
lp:~benoitg/ubuntu/natty/libofx/libofx.new-upstream-fix-661809-629996 |
|
2011-04-23 16:39:30 |
Benoit Grégoire |
libofx (Ubuntu): status |
New |
Confirmed |
|
2011-04-26 12:59:51 |
Michael Terry |
nominated for series |
|
Ubuntu Natty |
|
2011-04-26 12:59:51 |
Michael Terry |
bug task added |
|
libofx (Ubuntu Natty) |
|
2011-04-26 14:26:14 |
Michael Terry |
description |
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
=== SRU Justification ===
Impact: Latin-1 (non-utf8) characters cause truncations of strings.
Fixed upstream in 0.9.1.
To reproduce:
0. Download attached ofx-latin1.ofx
1. $ sudo apt-get install gnucash
2. $ gnucash
3. Set up an account, just keep clicking Forward
4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
5. Choose an account to add it to (like Liabilities->Credit Cards or something)
6. The name will show as "d" but it should show as "déjà vu"
Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.
If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.
See also bug 661809 and bug 771233, fixed by this same update.
Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification
=========================
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
|
2011-04-26 14:26:35 |
Michael Terry |
attachment added |
|
ofx-latin1.ofx https://bugs.launchpad.net/ubuntu/+source/libofx/+bug/769554/+attachment/2089999/+files/ofx-latin1.ofx |
|
2011-04-26 14:27:01 |
Michael Terry |
description |
=== SRU Justification ===
Impact: Latin-1 (non-utf8) characters cause truncations of strings.
Fixed upstream in 0.9.1.
To reproduce:
0. Download attached ofx-latin1.ofx
1. $ sudo apt-get install gnucash
2. $ gnucash
3. Set up an account, just keep clicking Forward
4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
5. Choose an account to add it to (like Liabilities->Credit Cards or something)
6. The name will show as "d" but it should show as "déjà vu"
Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.
If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.
See also bug 661809 and bug 771233, fixed by this same update.
Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification
=========================
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
=== SRU Justification ===
Impact: Latin-1 (non-ascii, non-multibyte) characters cause truncations of strings.
Fixed upstream in 0.9.1.
To reproduce:
0. Download attached ofx-latin1.ofx
1. $ sudo apt-get install gnucash
2. $ gnucash
3. Set up an account, just keep clicking Forward
4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
5. Choose an account to add it to (like Liabilities->Credit Cards or something)
6. The name will show as "d" but it should show as "déjà vu"
Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.
If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.
See also bug 661809 and bug 771233, fixed by this same update.
Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification
=========================
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
|
2011-04-26 14:27:23 |
Michael Terry |
tags |
regression |
regression verification-needed |
|
2011-04-26 14:27:35 |
Michael Terry |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2011-04-26 14:27:36 |
Michael Terry |
bug |
|
|
added subscriber Michael Terry |
2011-04-26 14:27:50 |
Michael Terry |
libofx (Ubuntu Natty): status |
Confirmed |
Triaged |
|
2011-04-26 14:27:51 |
Michael Terry |
libofx (Ubuntu Natty): status |
Triaged |
Fix Committed |
|
2011-04-26 14:33:25 |
Michael Terry |
description |
=== SRU Justification ===
Impact: Latin-1 (non-ascii, non-multibyte) characters cause truncations of strings.
Fixed upstream in 0.9.1.
To reproduce:
0. Download attached ofx-latin1.ofx
1. $ sudo apt-get install gnucash
2. $ gnucash
3. Set up an account, just keep clicking Forward
4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
5. Choose an account to add it to (like Liabilities->Credit Cards or something)
6. The name will show as "d" but it should show as "déjà vu"
Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.
If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.
See also bug 661809 and bug 771233, fixed by this same update.
Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification
=========================
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
=== SRU Justification ===
Impact: Latin-1 (non-ascii, non-multibyte) characters cause truncations of strings.
Fixed upstream in 0.9.1.
To reproduce:
0. Download attached ofx-latin1.ofx
1. $ sudo apt-get install gnucash
2. $ gnucash
3. Set up an account, just keep clicking Forward
4. File->Import->OFX/QFX... and pick ofx-latin1.ofx
5. Choose an account to add it to (like Liabilities->Credit Cards or something)
6. The name will show as "d" but it should show as "déjà vu"
Patch:
Because Ubuntu only has 0.9.0 but upstream has released four bugfix releases (up to 0.9.4) that address this and other outstanding issues and Debian hasn't been responsive for years, it is felt that just updating to 0.9.4 is best. I've attached https://launchpadlibrarian.net/70440554/libofx.debian.diff which is just the debian/ changes for such an update.
If this is considered too intrusive, a more targeted patch could be prepared. This was just easier and seemed low-risk as there are no new features.
Full branch: https://code.launchpad.net/~mterry/ubuntu/natty/libofx/libofx.new-upstream-benoit-sru
See also bug 661809 and bug 771233, fixed by this same update.
Testing:
1:0.9.4-0ubuntu0.1 has been pushed to natty-proposed. Please test and verify the fix here. See https://wiki.ubuntu.com/QATeam/PerformingSRUVerification
=========================
The patch that closed bug #629996 causes a serious regression for latin-1 (non-utf-8) characters. Specifically, all string are truncated after the first non-ascii character.
I opening this bug because I don't have access to re-open bug #629996.
While the original patch was indeed accepted upstream months ago, it was changed hours later when the regression was found. Only the original patch was manually applied in Ubuntu.
Proposed merge above re-fixes the bug without the regression, as well as several other segfaults by upgrading to upstream. |
|
2011-05-03 06:25:15 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
2011-05-03 07:18:20 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/natty-proposed/libofx |
|
2011-05-03 13:06:13 |
Nobuto Murata |
bug |
|
|
added subscriber Nobuto MURATA |
2011-05-03 13:06:32 |
Nobuto Murata |
bug |
|
|
added subscriber Yasuaki Taniguchi |
2011-05-04 02:28:46 |
Nobuto Murata |
tags |
regression verification-needed |
regression verification-failed |
|
2011-05-04 18:15:37 |
Benoit Grégoire |
attachment added |
|
Test case for iso-latin-1 encoding https://bugs.launchpad.net/ubuntu/+source/libofx/+bug/769554/+attachment/2112736/+files/ofx-test-iso-latin-1.ofx |
|
2011-05-04 18:16:19 |
Benoit Grégoire |
attachment added |
|
Test case for UTF-8 encoding https://bugs.launchpad.net/ubuntu/+source/libofx/+bug/769554/+attachment/2112749/+files/ofx-test-utf-8.ofx |
|
2011-05-10 06:07:01 |
Martin Pitt |
tags |
regression verification-failed |
regression verification-done |
|
2011-05-10 06:07:37 |
Launchpad Janitor |
libofx (Ubuntu Natty): status |
Fix Committed |
Fix Released |
|
2011-05-10 06:07:56 |
Martin Pitt |
libofx (Ubuntu): status |
Fix Committed |
Fix Released |
|