[SRU] Add quirks support for Goodix touchpad

Bug #2143028 reported by Bin Li
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Committed
Critical
Bin Li
libinput (Ubuntu)
Status tracked in Resolute
Noble
Fix Committed
Undecided
Bin Li
Questing
Fix Committed
Undecided
Bin Li
Resolute
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

 * The Goodix i2c touchpad on Lenovo Laptop are not working:
   vid:pid
   27C6:0F95
   27C6:01E8

 * This SRU will add a device quirk for these touchpad device.

[ Test Plan ]

 * On platform with touchpad that have matched vid:pid

 * left/right button should work normally

 * 1 finger drag and drop should work normally

 * 2 fingers scrolling should work normally

 * 3 fingers scrolling workspace should work normally

 * touchpad cursor movement should work normally

[ Where problems could occur ]

 * The quirk match the PID VID only, it won't impact other touchpad

[ Other Info ]

 * Upstream commits:
https://gitlab.freedesktop.org/libinput/libinput/-/commit/a525b3032681691b7d86bde2f9dd66525071af95
https://gitlab.freedesktop.org/libinput/libinput/-/commit/df8f5a3627e7bb2bf90ec5f2205713eacd642105

Related branches

Bin Li (binli)
summary: - [SRU] Add quirk support for Goodix touchpad 27C6:0F95
+ [SRU] Add quirks support for Goodix touchpad
Bin Li (binli)
description: updated
Bin Li (binli)
description: updated
tags: added: jira-sutton-3862 oem-priority
Bin Li (binli)
Changed in oem-priority:
assignee: nobody → Bin Li (binli)
status: New → In Progress
importance: Undecided → Critical
tags: added: fixed-in-libinput-1.31.0 fixed-upstream
Changed in libinput (Ubuntu Resolute):
status: New → Fix Released
tags: added: noble questing
Revision history for this message
Bin Li (binli) wrote (last edit ):

The original patches use AttrInputProp=+INPUT_PROP_PRESSUREPAD, for 24.04, the libinput is still based on 1.25.0, so I revised the patches to use 'ModelPressurePad=1' instead.

AttrInputProp=+INPUT_PROP_PRESSUREPAD is supported since libinput 1.30.0.

$ git tag --contains db6a04665c3280e2ca97819e63873cfc910ff960
1.30.901
1.31.0

Changed in libinput (Ubuntu Noble):
assignee: nobody → Bin Li (binli)
status: New → In Progress
Revision history for this message
Bin Li (binli) wrote (last edit ):

For 25.10, the libinput is based on 1.28.1, we used the same way with 24.04.

Changed in libinput (Ubuntu Questing):
status: New → In Progress
assignee: nobody → Bin Li (binli)
Revision history for this message
Bin Li (binli) wrote :

Noble

Revision history for this message
Bin Li (binli) wrote :

Questing

Changed in oem-priority:
status: In Progress → Fix Committed
Changed in libinput (Ubuntu Noble):
milestone: none → noble-updates
Changed in libinput (Ubuntu Questing):
milestone: none → questing-updates
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks uploaded to noble and questing review queues

Changed in libinput (Ubuntu Noble):
status: In Progress → Fix Committed
Changed in libinput (Ubuntu Questing):
status: In Progress → Fix Committed
Revision history for this message
Nick Rosbrook (enr0n) wrote : Please test proposed package

Hello Bin, or anyone else affected,

Accepted libinput into questing-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libinput/1.28.1-1ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-questing to verification-done-questing. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-questing. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-questing
tags: added: verification-needed-noble
Revision history for this message
Nick Rosbrook (enr0n) wrote :

Hello Bin, or anyone else affected,

Accepted libinput into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libinput/1.25.0-1ubuntu3.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Bin Li (binli) wrote (last edit ):

I have tested on ThinkPad plaform, the touchpad works fine with the propsed version on 24.04.

* left/right button should work normally
* 1 finger drag and drop should work normally
* 2 fingers scrolling should work normally
* 3 fingers scrolling workspace should work normally
* touchpad cursor movement should work normally

kernel: input: GXTP5420:00 27C6:0F95 Touchpad as /devices/pci0000:00/0000:00:19.1/i2c_designware.3/i2c-3/i2c-GXTP5420:00/0018:27C6:0F95.0002/input/input9

$ apt-cache policy libinput10
libinput10:
  Installed: 1.25.0-1ubuntu3.2
  Candidate: 1.25.0-1ubuntu3.2
  Version table:
     1.25.0-1ubuntu3.3 100
        100 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
 *** 1.25.0-1ubuntu3.2 500
        500 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     1.25.0-1ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu noble/main amd64 Packages

$ sudo apt install libinput10=1.25.0-1ubuntu3.3 libinput-bin=1.25.0-1ubuntu3.3

tags: added: verification-done-noble
removed: verification-needed-noble
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.