non-existent temporary desktop file appears on desktop
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LXQt |
Fix Released
|
Unknown
|
|||
libfm-qt (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Disco |
Fix Released
|
High
|
Simon Quigley |
Bug Description
[Summary]
Due to an error in how additions and deletions are processed in desktop management handled by pcmanfm-
Upstream issued a fix:
https:/
[Test Case]
1. Boot to a freshly installed system (Lubuntu is ideal)
2. Note that desktop shortcuts for Home, Trash, Computer, and Network are all displayed, with no additional files
3. All paths are clickable both on the desktop and in the file manager
4. Right click on the desktop
5. Click on "Desktop Preferences"
6. Click on the "Advanced" tab
7. Uncheck "Home"
8. Click OK
9. No additional files should show on the desktop
10. Repeat steps above, but check "Home" again
11. No additional files should show on the desktop
12. Log out and back in again
13. No additional files should show on the desktop
14. Repeat 4-13 with the other shortcuts
When the bug would occur, any change to the desktop shortcuts would result in a new temporary file remnant. Additionally, logging out and back in again would further affect it.
[Regression Potential]
The immediate concern is that pcmanfm-qt could require a no-change rebuild, since it is closely tied to libfm-qt.
Otherwise the amount of changes are relatively small. There should really be no cause for regression. One part of the change moves the process of changes to a later point in the logic, to allow for all changes to accumulate. Another part is more careful with removing deletions from the queue and and only does so if the file has been removed. The most important part for our bug is that a deleted file is not removed from the addition queue and then ignored in the deletion queue. If anything this code seeks to take more edge cases into account.
---
[Original Description]
STEPS TO REPRODUCE
1. Boot to installed system
2. Note that desktop shortcuts for Home, Trash, Computer, and Network are all displayed, along with a user-home.desktop with a 6 digit alphanumeric string appended to it
3. Note that the file does not exist (e.g. with the file manager)
4. Right click on the desktop
5. Click on "Desktop Preferences"
6. Click on the "Advanced" tab
7. Uncheck "Home"
8. Click OK
9. Note that the desktop shortcut for Home and the extra non-existent file disappears but nothing else changes
10. Repeat steps above, but check "Home" again
11. Note that all of the desktop shortcuts are displayed, but also a new file, most likely computer.deskop, but with a 6 digit alphanumeric string appended to it.
12. Note that the file does not exist (e.g. with the file manager)
13. Log out and back in again
14. Note that now there's a user.desktop instead of a computer.desktop
EXPECTED RESULTS
* non-existent files should not be displayed on the desktop
* if shortcuts files are temporarily renamed with the random string appended, they should be recycled when finished
ACTUAL RESULTS
The shortcuts display correctly, but the additional non-existent file sometimes shows. There is an unambiguous way to reproduce (see below), but it's not consistent:
* Lubuntu 19.04 live does not have the problem
* Lubuntu 19.04 install boots to the problem
* When pcmanfm-qt is restarted in Lubuntu, the errant file goes away, but logging out and back in again returns the problem
NOTES
Also occurs in Debian testing, though it doesn't initially have the problem and only affects the Home shortcut.
WORKAROUND
1. Open pcmanfm-qt
2. Go to the Desktop folder
3. Refresh the folder (F5)
Now the errant file will not return, no matter whether or not you check shortcuts on or off. It will return when you log in again, though.
We're tracking the ultimate resolution of this in Lubuntu here:
https:/
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: pcmanfm-qt 0.14.1-0ubuntu1
ProcVersionSign
Uname: Linux 5.0.0-13-generic x86_64
ApportVersion: 2.20.10-0ubuntu27
Architecture: amd64
CurrentDesktop: LXQt
Date: Fri Apr 19 15:18:20 2019
InstallationDate: Installed on 2019-04-18 (0 days ago)
InstallationMedia: Lubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
SourcePackage: pcmanfm-qt
UpgradeStatus: No upgrade log present (probably fresh install)
Changed in lxqt: | |
status: | Unknown → New |
description: | updated |
Changed in lxqt: | |
status: | New → Fix Released |
description: | updated |
Changed in libfm-qt (Ubuntu Disco): | |
status: | New → Triaged |
Changed in libfm-qt (Ubuntu): | |
importance: | Low → High |
Changed in libfm-qt (Ubuntu Disco): | |
importance: | Undecided → High |
assignee: | nobody → Walter Lapchynski (wxl) |
description: | updated |
description: | updated |
description: | updated |
Changed in libfm-qt (Ubuntu Disco): | |
assignee: | Walter Lapchynski (wxl) → Simon Quigley (tsimonq2) |
status: | Triaged → In Progress |
On Sun, Apr 21, 2019 at 5:35 PM Bug Watch Updater <
<email address hidden>> wrote:
> ** Changed in: lxqt
> Status: New => Fix Released
>
> Problem does seem to have been resolved, even before running an
upgrade??? Thanks for the rapid response on this issue . . . minor
annoyance . . . .
F