libdbusmenu doesn't use the menu item's label if it has a stock icon

Bug #1270486 reported by Alistair Buxton on 2014-01-18
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
libdbusmenu (Ubuntu)
High
Marco Trevisan (Treviño)
Nominated for Trusty by Marco Trevisan (Treviño)

Bug Description

To reproduce, run the attached testcase1.py. You will see a new indicator, inside it will be one menu item with label "Pause" and a pause button icon. The menu item should have the label "Hello".

Also note that this bug has been fixed once before:
https://bugs.launchpad.net/indicator-application/+bug/520048

For trusty, see comment 3. Glade is used by deluge to set the indicator menu, this is where the problem was first observed.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: indicator-application 12.10.1+13.10.20131107-0ubuntu1
Uname: Linux 3.11.0-031100-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.12.5-0ubuntu2.2
Architecture: amd64
Date: Sat Jan 18 20:40:29 2014
InstallationDate: Installed on 2013-08-27 (143 days ago)
InstallationMedia: Xubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130827)
MarkForUpload: True
SourcePackage: indicator-application
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Alistair Buxton (a-j-buxton) wrote :
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in indicator-application (Ubuntu):
status: New → Confirmed
tags: added: regression
description: updated
tags: added: trusty
Alistair Buxton (a-j-buxton) wrote :

testcase1.py does not trigger the bug on trusty, but testcase2.py does:

description: updated
Changed in indicator-application (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Medium
tags: added: ubuntu-desktop-trusty
Sebastien Bacher (seb128) wrote :

Ted said he would have a look, assigning to him

Changed in indicator-application (Ubuntu):
assignee: nobody → Ted Gould (ted)
importance: Medium → High
Ted Gould (ted) wrote :

This issue is in the dbusmenu parser code. Specifically right here:

http://bazaar.launchpad.net/~dbusmenu-team/libdbusmenu/trunk.14.04/view/head:/libdbusmenu-gtk/parser.c#L882

What we're doing is taking the stock label, for stock images. I think this is correct as the idea of a stock image is that there is a consistent application of it across the user experience. Using the stock icon without the label would mean you're trying to change the meaning of that icon, which seems like incorrect usage.

affects: indicator-application (Ubuntu) → libdbusmenu (Ubuntu)
Changed in libdbusmenu (Ubuntu):
status: Triaged → Won't Fix
Cas (calumlind) wrote :

For Deluge we use the stock add icon and have custom text of "Add Torrent" but now it's just "Add", "Pause All" becomes "Pause" etc. so it is an issue and it is breaking with the convention that you can specify custom labels with stock icons in a GTK application.

Matthew Paul Thomas (mpt) wrote :

That seems perfectly reasonable to me. Ubuntu doesn't use images in most command buttons and menu items. But if we did, it would be routine to make button/menu text more specific in particular apps or situations while retaining the stock icon: "Log Out Anyway" rather than "Log Out", "Remove Photo" rather than just "Remove", "Date & Time Settings…" rather than just "Settings…", and so on. It's not changing the meaning of the icon, it's just being helpfully more specific.

Changed in libdbusmenu (Ubuntu):
status: Won't Fix → Triaged
tags: added: regression-release
removed: regression trusty ubuntu-desktop-trusty
Alistair Buxton (a-j-buxton) wrote :

Just for the record this still affects trusty, including transmission which is a default app.

Sebastien Bacher (seb128) wrote :

what item is buggy in the transmission case?

Alistair Buxton (a-j-buxton) wrote :

See screenshot.

"Open" should be "Open a torrent"
"Open" should be "Open URL"
"Pause" should be "Pause all torrents"
"Play" should be "Start all torrents".

Sebastien Bacher (seb128) wrote :

The issue doesn't show on vivid/unity, is that fixed in new versions?

Alistair Buxton (a-j-buxton) wrote :

The bug still appears in vivid/xfce from about 3 days ago.

summary: - indicator-application doesn't use the menu item's label if it has a
- stock icon
+ libdbusmenu doesn't use the menu item's label if it has a stock icon
Changed in libdbusmenu (Ubuntu):
assignee: Ted Gould (ted) → Marco Trevisan (Treviño) (3v1n0)
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libdbusmenu - 12.10.3+15.04.20150410.2-0ubuntu1

---------------
libdbusmenu (12.10.3+15.04.20150410.2-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Marco Trevisan (Treviño) ]
  * Parser: don't override the label for stock items if a custom one is
    provided (LP: #1270486)
 -- CI Train Bot <email address hidden> Fri, 10 Apr 2015 21:56:13 +0000

Changed in libdbusmenu (Ubuntu):
status: In Progress → Fix Released
tags: added: trusty
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers