| 2011-08-13 00:37:47 |
Ryan Lovett |
bug |
|
|
added bug |
| 2011-08-15 18:39:40 |
Serge Hallyn |
libcgroup (Ubuntu): status |
New |
In Progress |
|
| 2011-08-15 18:39:44 |
Serge Hallyn |
libcgroup (Ubuntu): importance |
Undecided |
High |
|
| 2011-08-15 18:39:49 |
Serge Hallyn |
libcgroup (Ubuntu): assignee |
|
Serge Hallyn (serge-hallyn) |
|
| 2011-08-15 18:41:30 |
Serge Hallyn |
libcgroup (Ubuntu): status |
In Progress |
Fix Released |
|
| 2011-08-15 18:41:42 |
Serge Hallyn |
nominated for series |
|
Ubuntu Lucid |
|
| 2011-08-15 18:41:42 |
Serge Hallyn |
nominated for series |
|
Ubuntu Maverick |
|
| 2011-08-15 19:19:17 |
Serge Hallyn |
attachment added |
|
Proposed fix for lucid https://bugs.launchpad.net/ubuntu/+source/libcgroup/+bug/825598/+attachment/2280800/+files/libcgroup.debdiff |
|
| 2011-08-15 19:25:59 |
Serge Hallyn |
description |
The /etc/init.d/cgred startup script looks for the file /etc/default/cgred.conf rather than /etc/default/cgred.
Additionally, the script makes no use of the DAEMON_OPTS variable found in the default file.
Lastly, the log file parameter as provided won't work. (the daemon exits with a usage error) One has to use the -f option instead of --log-file in order for the daemon to start.
It might be good to document LOG_FILE via a comment in /etc/default/cgred.
-if [ -f "/etc/default/cgred.conf" ] ; then
- . /etc/default/cgred.conf
- OPTIONS="$NODAEMON $LOG"
+if [ -f "/etc/default/cgred" ] ; then
+ . /etc/default/cgred
+ OPTIONS="$NODAEMON $LOG $DAEMON_OPTS"
if [ -n "$LOG_FILE" ]; then
- OPTIONS="$OPTIONS --log-file=$LOG_FILE"
+ OPTIONS="$OPTIONS -f $LOG_FILE"
fi |
=======================================
SRU Justification:
1. Impact: startup modifications specified in /etc/default/cgred.conf are ignored.
2. How bug was addressed: the cgred init file is fixed.
3. Patch: see attached debdiff.
4. TEST CASE: add 'LOG_FILE=/var/log/snood' to /etc/default/cgred.conf. It will be ignored.
5. Regression potential: if people have updated their /etc/default/cgred with errors, which had up to now been ignored, then those errors would now be seen.
=======================================
The /etc/init.d/cgred startup script looks for the file /etc/default/cgred.conf rather than /etc/default/cgred.
Additionally, the script makes no use of the DAEMON_OPTS variable found in the default file.
Lastly, the log file parameter as provided won't work. (the daemon exits with a usage error) One has to use the -f option instead of --log-file in order for the daemon to start.
It might be good to document LOG_FILE via a comment in /etc/default/cgred.
-if [ -f "/etc/default/cgred.conf" ] ; then
- . /etc/default/cgred.conf
- OPTIONS="$NODAEMON $LOG"
+if [ -f "/etc/default/cgred" ] ; then
+ . /etc/default/cgred
+ OPTIONS="$NODAEMON $LOG $DAEMON_OPTS"
if [ -n "$LOG_FILE" ]; then
- OPTIONS="$OPTIONS --log-file=$LOG_FILE"
+ OPTIONS="$OPTIONS -f $LOG_FILE"
fi |
|
| 2011-08-15 19:26:08 |
Serge Hallyn |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2011-08-25 13:15:12 |
Martin Pitt |
bug task added |
|
libcgroup (Ubuntu Lucid) |
|
| 2011-08-25 13:15:22 |
Martin Pitt |
bug task added |
|
libcgroup (Ubuntu Maverick) |
|
| 2011-08-25 13:15:47 |
Martin Pitt |
libcgroup (Ubuntu Lucid): status |
New |
Fix Committed |
|
| 2011-08-25 13:15:50 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
| 2011-08-25 13:15:55 |
Martin Pitt |
tags |
|
verification-needed |
|
| 2011-08-25 13:21:56 |
Martin Pitt |
libcgroup (Ubuntu Maverick): status |
New |
Fix Committed |
|
| 2011-08-25 14:16:24 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/lucid-proposed/libcgroup |
|
| 2011-08-25 14:16:31 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/maverick-proposed/libcgroup |
|
| 2011-09-19 19:24:27 |
Ubuntu Foundations Team Bug Bot |
tags |
verification-needed |
testcase verification-needed |
|
| 2012-11-15 15:49:31 |
Serge Hallyn |
tags |
testcase verification-needed |
testcase verification-done |
|
| 2012-11-16 11:46:18 |
Colin Watson |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2012-11-16 11:46:19 |
Colin Watson |
libcgroup (Ubuntu Maverick): status |
Fix Committed |
Won't Fix |
|
| 2012-11-16 11:47:13 |
Launchpad Janitor |
libcgroup (Ubuntu Lucid): status |
Fix Committed |
Fix Released |
|
