0~git20200629+e7aa92a-8 is FTFBS

[Robert Ancell]

Fails to build due to gstreamer using deprecated g_memdup:

/usr/include/gstreamer-1.0/gst/base/gstbytereader.h: In function ‘guint8* gst_byte_reader_dup_data_unchecked(GstByteReader*, guint)’:
/usr/include/gstreamer-1.0/gst/base/gstbytereader.h:365:41: error: ‘void* g_memdup(gconstpointer, guint)’ is deprecated: Use 'g_memdup2' instead [-Werror=deprecated-declarations]
  365 | return (guint8 *) g_memdup (data, size);
      | ^
In file included from /usr/include/glib-2.0/glib.h:82,
                 from /usr/include/gstreamer-1.0/gst/gst.h:27,
                 from ../src/gstreamer/gstlibcamerasrc.h:12,
                 from ../src/gstreamer/gstlibcamerasrc.cpp:34:
/usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
  257 | gpointer g_memdup (gconstpointer mem,

Fixed in gstreamer upstream:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/b16e96dd878e0c5e7baeb8fad62ca43de1f66982

[Heather Ellsworth (hellsworth)]

The gstreamer commit that fixes the issue is on gstreamer master on 2021-06-23:

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/b16e96dd878e0c5e7baeb8fad62ca43de1f66982

So this should be picked up in the next tag, which might be in a month or so. Then that gstreamer needs to be picked up by debian and ubuntu and released. But the whole time we're holding libcamera back while waiting for the one gstreamer commit. So I wonder if the Ubuntu gstreamer maintainers would consider pulling this commit in early.

[Sebastien Bacher (seb128)]

The deprecation warning was fixed in libcamera upstream in
https://github.com/kbingham/libcamera/commit/19652e502

The build still fails with that fix due to

'FAILED: src/libcamera/libcamera.so.0.1.0.p/object.cpp.o
c++ -Isrc/libcamera/libcamera.so.0.1.0.p -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -Wno-unused-parameter -include config.h -g -O2 '-ffile-prefix-map=/<<BUILDDIR>>/libcamera-0~git20200629+e7aa92a=.' -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ src/libcamera/libcamera.so.0.1.0.p/object.cpp.o -MF src/libcamera/libcamera.so.0.1.0.p/object.cpp.o.d -o src/libcamera/libcamera.so.0.1.0.p/object.cpp.o -c ../src/libcamera/object.cpp
In file included from ../src/libcamera/object.cpp:15:
../src/libcamera/object.cpp: In member function ‘libcamera::Object::notifyThreadMove()’:
../include/libcamera/internal/message.h:57:47: error: array subscript ‘const struct InvokeMessage[0]’ is partly outside array bounds of ‘struct Message[1]’ [-Werror=array-bounds]
   57 | Semaphore *semaphore() const { return semaphore_; }
      | ^~~~~~~~~~
../src/libcamera/object.cpp:217:17: note: while referencing ‘msg’
  217 | Message msg(Message::ThreadMoveMessage);
      | ^~~
cc1plus: all warnings being treated as errors'

Failing build on warnings is probably not we want on the package or we will get similar issues again as libraries deprecated functions or compiler change, which aren't enough of a reason to break a package build, let's disable Werror instead

[Launchpad Janitor (janitor)]

This bug was fixed in the package libcamera - 0~git20200629+e7aa92a-9

---------------
libcamera (0~git20200629+e7aa92a-9) impish; urgency=medium

  * debian/patches/ubuntu_disable_werror.patch:
    - disable werror for the package build to avoid starts failing to
      build due to deprecation warnings on library changes (lp: #1931958)

 -- Sebastien Bacher <email address hidden> Tue, 28 Sep 2021 17:03:05 +0200