libbonobo2-0: bashism in postinst

[Debian Bug Importer]

Automatically imported from Debian bug report #255950 http://bugs.debian.org/255950

[Ivan Nestlerode (nestler)]

retitle 255950 libbonobo2-0: bashism in postinst
tags 255950 patch
thanks

The error is on the postinst file. This line is buggy:
       kill -HUP `pidof bonobo-activation-server` &>/dev/null || true

The ampersand redirection is a bashism that doesn't work with dash as
/bin/sh. Changing it to a 2 works in this case to suppress the kill
error message on stderr that you get when bonobo isn't running.

The patch is attached.

-Ivan

[Clint Adams (clint)]

> --- /var/lib/dpkg/info/libbonobo2-0.postinst 2004-06-22 17:53:53.000000000 -0400
> +++ libbonobo2-0.postinst-fixed 2004-06-23 19:30:59.000000000 -0400
> @@ -4,7 +4,7 @@
>
> case "$1" in
> configure)
> - kill -HUP `pidof bonobo-activation-server` &>/dev/null || true
> + kill -HUP `pidof bonobo-activation-server` 2>/dev/null || true
> ;;
>
> abort-upgrade|abort-remove|abort-deconfigure)

One small correction; it should be

 kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true

[Clint Adams (clint)]

severity 255950 serious
quit

[Sebastien Bacher (seb128)]

# Automatically generated email from bts, devscripts version 2.7.95.1
severity 255950 wishlist

[Sebastien Bacher (seb128)]

# Automatically generated email from bts, devscripts version 2.7.95.1
tags 255950 pending

[Sebastien Bacher (seb128)]

Le mar, 29/06/2004 à 16:22 -0400, Clint Adams a écrit :

> kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true

Thanks for the correction, but why are you changing the severity ? I'm
changing it back to wishlist, please include a comment if you do such
changes.

Cheers,

Sebastien Bacher

[Debian Bug Importer (debzilla)]

Automatically imported from Debian bug report #255950 http://bugs.debian.org/255950

[Debian Bug Importer (debzilla)]

Message-Id: <20040623224705.35BDF51BC9@harpua>
Date: Wed, 23 Jun 2004 18:47:05 -0400
From: Ivan Nestlerode <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: libbonobo2-0: strange 'kill' error messages during upgrade

Package: libbonobo2-0
Version: 2.6.2-4
Severity: minor

During the upgrade from 2.6.2-3, I see this:
Setting up libbonobo2-0 (2.6.2-4) ...

kill: 18: Usage: kill [-s sigspec | -signum | -sigspec] [pid | job]...
or
kill -l [exitstatus]
Press return to continue.

It doesn't cause the upgrade to fail, but it is strange looking.
If it is relevant, I had done the workaround for the 2.6.2-3 install
problems (I had deleted /var/lib/dpkg/info/libbonobo2-0.postinst) before
doing this upgrade.

Also, my /bin/sh is dash if that matters.

-Ivan

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7
Locale: LANG=C, LC_CTYPE=C

Versions of packages libbonobo2-0 depends on:
ii libbonobo2-common 2.6.2-4 Bonobo CORBA interfaces library --
ii libc6 2.3.2.ds1-13 GNU C Library: Shared libraries an
ii libglib2.0-0 2.4.2-1 The GLib library of C routines
ii liborbit2 1:2.10.2-1.1 libraries for ORBit2 - a CORBA ORB

-- no debconf information

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Wed, 23 Jun 2004 19:43:26 -0400
From: Ivan Nestlerode <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: patch for the problem

--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

retitle 255950 libbonobo2-0: bashism in postinst
tags 255950 patch
thanks

The error is on the postinst file. This line is buggy:
       kill -HUP `pidof bonobo-activation-server` &>/dev/null || true

The ampersand redirection is a bashism that doesn't work with dash as
/bin/sh. Changing it to a 2 works in this case to suppress the kill
error message on stderr that you get when bonobo isn't running.

The patch is attached.

-Ivan

--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch

--- /var/lib/dpkg/info/libbonobo2-0.postinst 2004-06-22 17:53:53.000000000 -0400
+++ libbonobo2-0.postinst-fixed 2004-06-23 19:30:59.000000000 -0400
@@ -4,7 +4,7 @@

 case "$1" in
     configure)
- kill -HUP `pidof bonobo-activation-server` &>/dev/null || true
+ kill -HUP `pidof bonobo-activation-server` 2>/dev/null || true
     ;;

     abort-upgrade|abort-remove|abort-deconfigure)

--gBBFr7Ir9EOA20Yy--

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Tue, 29 Jun 2004 16:22:52 -0400
From: Clint Adams <email address hidden>
To: Ivan Nestlerode <email address hidden>, <email address hidden>
Subject: Re: Bug#255950: patch for the problem

> --- /var/lib/dpkg/info/libbonobo2-0.postinst 2004-06-22 17:53:53.000000000 -0400
> +++ libbonobo2-0.postinst-fixed 2004-06-23 19:30:59.000000000 -0400
> @@ -4,7 +4,7 @@
>
> case "$1" in
> configure)
> - kill -HUP `pidof bonobo-activation-server` &>/dev/null || true
> + kill -HUP `pidof bonobo-activation-server` 2>/dev/null || true
> ;;
>
> abort-upgrade|abort-remove|abort-deconfigure)

One small correction; it should be

 kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Tue, 29 Jun 2004 16:25:32 -0400
From: Clint Adams <email address hidden>
To: <email address hidden>
Subject: violates policy 10.4

severity 255950 serious
quit

[Debian Bug Importer (debzilla)]

Message-Id: <1088544458.17984.13.camel@seb128>
Date: Tue, 29 Jun 2004 23:27:38 +0200
From: Sebastien Bacher <email address hidden>
To: Clint Adams <email address hidden>, <email address hidden>
Subject: Re: Bug#255950: patch for the problem

Le mar, 29/06/2004 =E0 16:22 -0400, Clint Adams a =E9crit :

> kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true

Thanks for the correction, but why are you changing the severity ? I'm
changing it back to wishlist, please include a comment if you do such
changes.

Cheers,

Sebastien Bacher

[Debian Bug Importer (debzilla)]

Message-Id: <E1BfQ8t-0004n9-00@seb128>
Date: Tue, 29 Jun 2004 23:27:51 +0200
From: Sebastien Bacher <email address hidden>
To: <email address hidden>
Subject: severity of 255950 is wishlist

# Automatically generated email from bts, devscripts version 2.7.95.1
severity 255950 wishlist

[Debian Bug Importer (debzilla)]

Message-Id: <E1BfQ8w-0004nD-00@seb128>
Date: Tue, 29 Jun 2004 23:27:54 +0200
From: Sebastien Bacher <email address hidden>
To: <email address hidden>
Subject: tagging 255950

# Automatically generated email from bts, devscripts version 2.7.95.1
tags 255950 pending

[Clint Adams (clint)]

> > kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true
>
> Thanks for the correction, but why are you changing the severity ? I'm
> changing it back to wishlist, please include a comment if you do such
> changes.

It is not wishlist.

     The standard shell interpreter `/bin/sh' can be a symbolic link to any
     POSIX compatible shell, if `echo -n' does not generate a newline.[1]
     Thus, shell scripts specifying `/bin/sh' as interpreter should only
     use POSIX features. If a script requires non-POSIX features from the
     shell interpreter, the appropriate shell must be specified in the
     first line of the script (e.g., `#!/bin/bash') and the package must
     depend on the package providing the shell (unless the shell package is
     marked "Essential", as in the case of `bash').

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Tue, 29 Jun 2004 19:33:37 -0400
From: Clint Adams <email address hidden>
To: Sebastien Bacher <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#255950: patch for the problem

> > kill -s HUP `pidof bonobo-activation-server` 2>/dev/null || true
>
> Thanks for the correction, but why are you changing the severity ? I'm
> changing it back to wishlist, please include a comment if you do such
> changes.

It is not wishlist.

     The standard shell interpreter `/bin/sh' can be a symbolic link to any
     POSIX compatible shell, if `echo -n' does not generate a newline.[1]
     Thus, shell scripts specifying `/bin/sh' as interpreter should only
     use POSIX features. If a script requires non-POSIX features from the
     shell interpreter, the appropriate shell must be specified in the
     first line of the script (e.g., `#!/bin/bash') and the package must
     depend on the package providing the shell (unless the shell package is
     marked "Essential", as in the case of `bash').

[Sebastien Bacher (seb128)]

Le mar, 29/06/2004 à 19:33 -0400, Clint Adams a écrit :

> It is not wishlist.

Perhaps, but there is no interest to set a RC for this since it doesn't
break the script. I don't want to upload a new package now because we
need to get some GNOME packages autobuilded and that's not time to break
autobuilds with some new upload of libbonobo.

Cheers,

Sebastien Bacher

[Debian Bug Importer (debzilla)]

Message-Id: <1088581607.2481.3.camel@seb128>
Date: Wed, 30 Jun 2004 09:46:47 +0200
From: Sebastien Bacher <email address hidden>
To: Clint Adams <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#255950: patch for the problem

Le mar, 29/06/2004 =E0 19:33 -0400, Clint Adams a =E9crit :

> It is not wishlist.

Perhaps, but there is no interest to set a RC for this since it doesn't
break the script. I don't want to upload a new package now because we
need to get some GNOME packages autobuilded and that's not time to break
autobuilds with some new upload of libbonobo.

Cheers,

Sebastien Bacher

[Sebastien Bacher (seb128)]

This bug is pending in Debian, time to get more GNOME packages ready for sarge

[Matt Zimmerman (mdz)]

Remove myself from all these CCs now that we have the warty-bugs mailing list

[Jordi Mallach (jordi)]

Source: libbonobo
Source-Version: 2.6.2-5

We believe that the bug you reported is fixed in the latest version of
libbonobo, which is due to be installed in the Debian FTP archive:

libbonobo2-0_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-0_2.6.2-5_i386.deb
libbonobo2-common_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-common_2.6.2-5_i386.deb
libbonobo2-dev_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-dev_2.6.2-5_i386.deb
libbonobo_2.6.2-5.diff.gz
  to pool/main/libb/libbonobo/libbonobo_2.6.2-5.diff.gz
libbonobo_2.6.2-5.dsc
  to pool/main/libb/libbonobo/libbonobo_2.6.2-5.dsc

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jordi Mallach <email address hidden> (supplier of updated libbonobo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 23 Jul 2004 12:03:45 +0200
Source: libbonobo
Binary: libbonobo2-dev libbonobo2-common libbonobo2-0
Architecture: source i386
Version: 2.6.2-5
Distribution: unstable
Urgency: low
Maintainer: Takuo KITAME <email address hidden>
Changed-By: Jordi Mallach <email address hidden>
Description:
 libbonobo2-0 - Bonobo CORBA interfaces library
 libbonobo2-common - Bonobo CORBA interfaces library -- support files
 libbonobo2-dev - Bonobo CORBA interfaces library -- development files
Closes: 250962 255950
Changes:
 libbonobo (2.6.2-5) unstable; urgency=low
 .
   * GNOME team upload.
   * Sebastien Bacher:
     + debian/libbonobo2-0.postinst: fixed some bashisms (Closes: #255950).
   * Jordi Mallach:
     + debian/rules: remove broken.server which was polluting system logs
       (closes: #250962).
Files:
 8e1efe6017c11ff5c5152e7513e9385b 1554 devel optional libbonobo_2.6.2-5.dsc
 d836cedbb0bca6da0951a52abc6f5d87 5281 devel optional libbonobo_2.6.2-5.diff.gz
 c2be3c3748605a9d436ec5c4583f3828 310690 devel optional libbonobo2-common_2.6.2-5_i386.deb
 a512f09582fbea7fdeba20ac4faf7451 242468 libdevel optional libbonobo2-dev_2.6.2-5_i386.deb
 38b6f3e2d566150419ce06374d78279e 146692 libs optional libbonobo2-0_2.6.2-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBAPAmJYSUupF6Il4RAoboAJ9drGLu9AbywY7LzhrTEJmosrNjyQCcDkcR
/8y/ABZqcbX75wNC0Fok3QI=
=qZXx
-----END PGP SIGNATURE-----

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Fri, 23 Jul 2004 07:17:05 -0400
From: Jordi Mallach <email address hidden>
To: <email address hidden>
Subject: Bug#255950: fixed in libbonobo 2.6.2-5

Source: libbonobo
Source-Version: 2.6.2-5

We believe that the bug you reported is fixed in the latest version of
libbonobo, which is due to be installed in the Debian FTP archive:

libbonobo2-0_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-0_2.6.2-5_i386.deb
libbonobo2-common_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-common_2.6.2-5_i386.deb
libbonobo2-dev_2.6.2-5_i386.deb
  to pool/main/libb/libbonobo/libbonobo2-dev_2.6.2-5_i386.deb
libbonobo_2.6.2-5.diff.gz
  to pool/main/libb/libbonobo/libbonobo_2.6.2-5.diff.gz
libbonobo_2.6.2-5.dsc
  to pool/main/libb/libbonobo/libbonobo_2.6.2-5.dsc

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jordi Mallach <email address hidden> (supplier of updated libbonobo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 23 Jul 2004 12:03:45 +0200
Source: libbonobo
Binary: libbonobo2-dev libbonobo2-common libbonobo2-0
Architecture: source i386
Version: 2.6.2-5
Distribution: unstable
Urgency: low
Maintainer: Takuo KITAME <email address hidden>
Changed-By: Jordi Mallach <email address hidden>
Description:
 libbonobo2-0 - Bonobo CORBA interfaces library
 libbonobo2-common - Bonobo CORBA interfaces library -- support files
 libbonobo2-dev - Bonobo CORBA interfaces library -- development files
Closes: 250962 255950
Changes:
 libbonobo (2.6.2-5) unstable; urgency=low
 .
   * GNOME team upload.
   * Sebastien Bacher:
     + debian/libbonobo2-0.postinst: fixed some bashisms (Closes: #255950).
   * Jordi Mallach:
     + debian/rules: remove broken.server which was polluting system logs
       (closes: #250962).
Files:
 8e1efe6017c11ff5c5152e7513e9385b 1554 devel optional libbonobo_2.6.2-5.dsc
 d836cedbb0bca6da0951a52abc6f5d87 5281 devel optional libbonobo_2.6.2-5.diff.gz
 c2be3c3748605a9d436ec5c4583f3828 310690 devel optional libbonobo2-common_2.6.2-5_i386.deb
 a512f09582fbea7fdeba20ac4faf7451 242468 libdevel optional libbonobo2-dev_2.6.2-5_i386.deb
 38b6f3e2d566150419ce06374d78279e 146692 libs optional libbonobo2-0_2.6.2-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBAPAmJYSUupF6Il4RAoboAJ9drGLu9AbywY7LzhrTEJmosrNjyQCcDkcR
/8y/ABZqcbX75wNC0Fok3QI=
=qZXx
-----END PGP SIGNATURE-----

[Matt Zimmerman (mdz)]

This bug is now fixed in Debian, but is it fixed in Warty as well?

[Sebastien Bacher (seb128)]

Not, I was waiting for a new libbonobo release upstream, but still no 2.7 tarball.

BTW the 2 little changes in the debian package are good for warty too, so let's
do a sync if possible to fix this bug.

[Matt Zimmerman (mdz)]

Fixed via sync of 2.6.2-5