adplug+libbinio+memory mapped = crash on some files

[Stian Skjelstad]

The build already includes this patch:

https://github.com/adplug/libbinio/commit/76b5346a6196c76a1e9ea1ae0593d695da1dbd37

but it will also need this to remove all crashes (".D00" files, that are memory mapped for instance, when loaded via libadplug)

https://github.com/adplug/libbinio/pull/8/commits/41fddc3a8123ec5455dcc8979f34a8b705eee5e6

(The crashes that happens inside Adplug, is due to memory allocated buffer that only receives the first byte set from a read-call, and further parsing assumes that the full data has been fetched)

[Stian Skjelstad (mywave)]

https://github.com/adplug/libbinio has now actually just tagged version 1.5

libbinio1v5 can now be upgraded to build on this release instead of 1.4 + cherry-picked patches, that also includes this fix

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Stian Skjelstad (mywave)]

OpenCubicPlayer next version depends on this getting fixed

[Lenin (gagarin)]

Indeed, being the maintainer of ocp, I'm interested getting it updated, including adplug support. Builds also without, loses a lot of supported files though (adplug)

[Lenin (gagarin)]

a fixed source deb package is available http://phd-sid.ethz.ch/debian/libbinio/ since oct-2019

[Lenin (gagarin)]

amoog would you mind fixing it please? or allow me join you as a team member to fix it?

[Lenin (gagarin)]

summary: ocp+libbinio 1.5 with adlib player functionality:

http://phd-sid.ethz.ch/debian/libbinio/
http://phd-sid.ethz.ch/debian/ocp/2020/

[Lenin (gagarin)]

https://bugs.debian.org/951571

[Gianfranco Costamagna (costamagnagianfranco)]

Fix uploaded in Ubuntu focal.
Debian is in deferred/10