[Feature Freeze Exception]Update Ledmon in Ubuntu 18.04 05 new upstream 0.90

[Jeff Lane ]

Please update ledmon in Bionic to the latest upstream version 0.90.

0.90 is necessary as the updates to ledmon enable monitoring of Intel VROC[1] (Virtual Raid on CPU) and RSTe[2] (Rapid Storage Technologies enterprise) by enabling the use of the drive LEDs to indicate array state (degraded, disk issues, etc).

Currently, ledmon in Bionic is version 0.79-2. This is pulled from Debian[3] however the debian package is grossly out of date and the Debian maintainer has been radio silent since last year. Attempts to contact him to get the Debian package updated have gone unanswered for several months.

The Debian package we normally pull from has several issues:
1: It appears to have been abandoned by the Debian Maintainer
2: It is several versions out of date by now (current upstream is 0.90, Debian is still at 0.79)
3: The Debian package is pulling from a deprecated upstream source (sourceforge[4]) the upstream was changed to Github[5] some time ago.
4: Intel even went and updated the deprecated sourceforge repo in the hopes that Debian would update, but Debian is still at 0.79.

Also, a test build is available here:

ppa:bladernr/final-builds

[1] https://www.intel.com/content/www/us/en/support/articles/000024498/memory-and-storage/ssd-software.html
[2] https://www.intel.com/content/www/us/en/support/products/54985/memory-and-storage/ssd-software/intel-rapid-storage-technology-enterprise-intel-rste.html
[3] https://qa.debian.org/cgi-bin/watch?pkg=ledmon
[4] https://sourceforge.net/projects/ledmon/
[5] https://github.com/intel/ledmon

[Jeff Lane  (bladernr)]

buildlog (built in a PPA)

[Jeff Lane  (bladernr)]

Changelog (Note, there is no CHANGES in the source prior to this release (0.79 does not have this file)

[Jeff Lane  (bladernr)]

Install Log:
Reading package lists...
Building dependency tree...
Reading state information...
The following package was automatically installed and is no longer required:
  grub-pc-bin
Use 'sudo apt autoremove' to remove it.
The following additional packages will be installed:
  libsgutils2-2
Suggested packages:
  sg3-utils
The following NEW packages will be installed:
  ledmon libsgutils2-2
0 upgraded, 2 newly installed, 0 to remove and 91 not upgraded.
Need to get 109 kB of archives.
After this operation, 419 kB of additional disk space will be used.
Do you want to continue? [Y/n] Get:1 http://ppa.launchpad.net/bladernr/final-builds/ubuntu bionic/main amd64 ledmon amd64 0.90-1 [49.9 kB]
Get:2 http://archive.ubuntu.com/ubuntu bionic/main amd64 libsgutils2-2 amd64 1.42-2ubuntu1 [59.3 kB]
Fetched 109 kB in 6s (17.7 kB/s)
Selecting previously unselected package libsgutils2-2.
(Reading database ... 93720 files and directories currently installed.)
Preparing to unpack .../libsgutils2-2_1.42-2ubuntu1_amd64.deb ...
Unpacking libsgutils2-2 (1.42-2ubuntu1) ...
Selecting previously unselected package ledmon.
Preparing to unpack .../ledmon_0.90-1_amd64.deb ...
Unpacking ledmon (0.90-1) ...
Setting up libsgutils2-2 (1.42-2ubuntu1) ...
Processing triggers for libc-bin (2.27-0ubuntu2) ...
Processing triggers for man-db (2.8.2-1) ...
Setting up ledmon (0.90-1) ...

[Jeff Lane  (bladernr)]

Testing:
I've tested only installation of the package.

Functional testing performed/validated by an engineer at Intel

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Łukasz Zemczak (sil2100)]

This sounds like a valid request to me. One thing I'd still like to see - could you check if the new version builds correctly on all other supported architectures? Your PPA seems to only have amd64 and i386 enabled. Could you also provide test logs of upgrade cases from the old version?

Thank you!

[Jeff Lane  (bladernr)]

Build log for s390x

[Jeff Lane  (bladernr)]

Build Log for arm64

[Jeff Lane  (bladernr)]

Build Log for armhf

[Jeff Lane  (bladernr)]

Build log for Power

[Jeff Lane  (bladernr)]

whoops... build log for Power

[Jeff Lane  (bladernr)]

Upgrade test:
bladernr@bionic-buildtest:~$ apt-cache policy ledmon
ledmon:
  Installed: 0.79-2build1
  Candidate: 0.90-1
  Version table:
     0.90-1 500
        500 http://ppa.launchpad.net/bladernr/final-builds/ubuntu bionic/main amd64 Packages
 *** 0.79-2build1 500
        500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
        100 /var/lib/dpkg/status
bladernr@bionic-buildtest:~$ sudo apt-get install ledmon
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'sudo apt autoremove' to remove it.
The following packages will be upgraded:
  ledmon
1 upgraded, 0 newly installed, 0 to remove and 129 not upgraded.
Need to get 49.9 kB of archives.
After this operation, 58.4 kB of additional disk space will be used.
Get:1 http://ppa.launchpad.net/bladernr/final-builds/ubuntu bionic/main amd64 ledmon amd64 0.90-1 [49.9 kB]
Fetched 49.9 kB in 0s (104 kB/s)
(Reading database ... 35457 files and directories currently installed.)
Preparing to unpack .../ledmon_0.90-1_amd64.deb ...
Unpacking ledmon (0.90-1) over (0.79-2build1) ...
Setting up ledmon (0.90-1) ...
Processing triggers for man-db (2.8.2-1) ...
bladernr@bionic-buildtest:~$ sudo apt-cache policy ledmon
ledmon:
  Installed: 0.90-1
  Candidate: 0.90-1
  Version table:
 *** 0.90-1 500
        500 http://ppa.launchpad.net/bladernr/final-builds/ubuntu bionic/main amd64 Packages
        100 /var/lib/dpkg/status
     0.79-2build1 500
        500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
bladernr@bionic-buildtest:~$ ledmon -v
Intel(R) Enclosure LED Monitor Service 0.90
Copyright (C) 2009-2018 Intel Corporation.

This is free software; see the source for copying conditions. There is NO warranty;
not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[Jeremy Bícha (jbicha)]

I'm not really looking at sponsoring this package right now, but there is one change you need to make.

Please change the version from 0.90-1 to 0.90-0ubuntu1 since the initial number after the - is for versions uploaded to Debian.

[Jeff Lane  (bladernr)]

Thanks Jeremy, this is the first package I've ever built for Ubuntu, before they've always been for PPAs so versioning wasn't super critical. because the version regressed, I've had to start a new PPA and 0.90-0ubuntu1 is building now:

https://launchpad.net/~bladernr/+archive/ubuntu/ledmon-ffe-fixes

[Jared Dominguez (jared-dominguez)]

Hey, I am (was?) the maintainer in Debian, which I'd been maintaining for my old team. I must've missed the pings about the package but saw this LP bug. Anyway, it's fallen really low on my to-do list because of other work, even though I'd hoped to have gotten to it a while ago. I'd really appreciate any help maintaining in Debian/Ubuntu. Honestly it's something I had been maintaining in Debian because Intel wasn't; I think ideally they should be the package maintainer as they're upstream. I'm happy to help with pushing for business case with them on that if desired.

[Jeff Lane  (bladernr)]

If you can convince Intel to maintain this in Debian, ultimately that would be the best. We sync this directly from Debian under normal circumstances, but in this case, since we need 0.90 for new hardware support in 18.04, this was the most expeditious route.

The original idea was to get 0.90 in Bionic this way and then try to get Debian updated on the next go-round and resume syncing from there.

[Jared Dominguez (jared-dominguez)]

That plan makes sense. Again, sorry for not following up earlier. I've reached out to Intel about taking up maintainership (complete with JIRA task :) ).

[Jeff Lane  (bladernr)]

So no one has commented any further, what are the chances this will make Bionic? If not, how about in the 18.04.1 timeframe?

[Michał Żyłowski (mzylowsk-intel)]

Hello!
What is the status here?

Is there any chance ledmon v0.90 will be available in ubuntu 18.04.1?

[Michał Żyłowski (mzylowsk-intel)]

Hello!

Any progress here?

Dimitri can you help also here?

[Woodrow Shen (woodrow-shen)]

Hi Michał,

Please see https://bugs.launchpad.net/ubuntu/+source/ledmon/+bug/1789786/comments/8

[Woodrow Shen (woodrow-shen)]

The bug could be closed due to bug #1789786.