ldm leaves stale processes around due to wrong kill command

Bug #173239 reported by Oliver Grawert on 2007-12-01
8
Affects Status Importance Assigned to Milestone
ldm (Ubuntu)
Undecided
Unassigned

Bug Description

Binary package hint: ldm

in lines 327 to 331 in ldm.c the parent process (/etc/X11/Xsession) is supposed to be killed, apparently that doesnt work properly and stale bonobo or nautilus processes are left behind.

it might be caused by the fact that there is no proper shell quoting for the parent process ID

cmd[i++] = "$PPID";

should likely add some curly brackets as below:

cmd[i++] = "${PPID}";

Oliver Grawert (ogra) wrote :

http://people.ubuntu.com/~ogra/ldm_5.0.39+20071127pre5.1-0ubuntu3_i386.deb has this change to test the fix.

to install it copy it into your chroot (to /opt/ltsp/i386/tmp or so)
sudo chroot /opt/ltsp/i386
dpkg -i /tmp/ldm_5.0.39+20071127pre5.1-0ubuntu3_i386.deb
<hit ctrl-d now to exit the chroot>
sudo ltsp-update-image

boot a client and test if there are stale processes left behind after properly logging out

Oliver Grawert (ogra) wrote :

additionally to the above i changed the signal in the kill command from -1 to -9 in the code

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ldm - 5.0.40~bzr20080212-0ubuntu2

---------------
ldm (5.0.40~bzr20080212-0ubuntu2) hardy; urgency=low

  * security fix for debian bug #469462 that left x open to the local
    network.
  * fix quoting for the parent process id to make sure Xsession gets
    killed properly (LP: #173239)

 -- Oliver Grawert <email address hidden> Wed, 09 Apr 2008 01:34:45 +0200

Changed in ldm:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers